alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: "Nobin Mathew" <nobin.mathew@gmail.com>
To: Liam Girdwood <lg@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org
Subject: [ASoC]one Small Suggestion
Date: Thu, 7 Jun 2007 18:28:56 +0530	[thread overview]
Message-ID: <8d6898730706070558r6c5c08aft8e00563b7a8ba607@mail.gmail.com> (raw)

Liam,

Thank you for your support, my work is almost complete now, driver is
working perfectly now.


I have one suggestion,

I modified the wm9713.c codec driver in probe function , so that


	if(socdev->machine->dai_link->cpu_dai->private_data)
		codec->ac97->bus->private_data =
socdev->machine->dai_link->cpu_dai->private_data;

Here i am assigning the controller private data.


so that my following ac97 read and write to access codec registers become good.

static void aaci_ac97_write(struct snd_ac97 *ac97, unsigned short reg,
unsigned short val)
{
	struct platform_controller *controller = ac97->bus->private_data;
	struct aaci *aaci = (struct aaci *)controller->bus_controller;


static unsigned short aaci_ac97_read(struct snd_ac97 *ac97, unsigned short reg)
{
	struct platform_controller *controller = ac97->bus->private_data;
	struct aaci *aaci = (struct aaci *)controller->bus_controller;
	u32 v;


Is there a way to accomodate this in existing ASoC design?
Or a better way to do this?

             reply	other threads:[~2007-06-07 12:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-07 12:58 Nobin Mathew [this message]
2007-06-08  7:47 ` [ASoC]one Small Suggestion Nobin Mathew
2007-06-08  7:56   ` Graeme Gregory
2007-06-08  8:26     ` Nobin Mathew
2007-06-08  8:47       ` Graeme Gregory
2007-06-08  8:48       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d6898730706070558r6c5c08aft8e00563b7a8ba607@mail.gmail.com \
    --to=nobin.mathew@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lg@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).