From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0F62C433E7 for ; Wed, 2 Sep 2020 18:07:20 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E846208C7 for ; Wed, 2 Sep 2020 18:07:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="jTivZm0V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E846208C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siol.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D04641870; Wed, 2 Sep 2020 20:06:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D04641870 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1599070038; bh=aIo1BugXyYCiERDipcprFtdX21woMAMjZXxJiBWKQAM=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=jTivZm0VUbNvlZ6O6cJnPftcSvwzaYeg3Dq8T6YYijlNN//2dlNBCDnC4h84eLF33 Ghp4NqSgd/RlmlHb8kd9ljJ+4O8PbiTVusw4UVYa4IxR6e5+JLrGTM/qlXZR1Eb/Qi F3kix/P2MH1YUMUH+fAIwCeVdiSKXTuAm5t/ZBYU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6862CF80212; Wed, 2 Sep 2020 20:06:28 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B0E28F8024A; Wed, 2 Sep 2020 20:06:26 +0200 (CEST) Received: from mail.siol.net (mailoutvs48.siol.net [185.57.226.239]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C468EF801DA for ; Wed, 2 Sep 2020 20:06:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C468EF801DA Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id DC7AB526A96; Wed, 2 Sep 2020 20:06:13 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta09.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta09.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id JLXQv0_kZthx; Wed, 2 Sep 2020 20:06:13 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id 5A4CB526A97; Wed, 2 Sep 2020 20:06:13 +0200 (CEST) Received: from kista.localnet (cpe1-5-97.cable.triera.net [213.161.5.97]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id 8177A526A92; Wed, 2 Sep 2020 20:06:12 +0200 (CEST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: peron.clem@gmail.com, Maxime Ripard , Chen-Yu Tsai , Rob Herring , Mark Brown , Liam Girdwood , Samuel Holland Subject: Re: [linux-sunxi] [PATCH 05/16] ASoc: sun4i-i2s: Add 20 and 24 bit support Date: Wed, 02 Sep 2020 20:10:47 +0200 Message-ID: <9148679.oVN3Z7rve9@kista> In-Reply-To: <1e320dfd-9388-54b2-dba9-7def0bf4bbad@sholland.org> References: <20200704113902.336911-1-peron.clem@gmail.com> <20200704113902.336911-6-peron.clem@gmail.com> <1e320dfd-9388-54b2-dba9-7def0bf4bbad@sholland.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Marcus Cooper , linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Samuel! Dne petek, 10. julij 2020 ob 07:44:51 CEST je Samuel Holland napisal(a): > On 7/4/20 6:38 AM, Cl=E9ment P=E9ron wrote: > > From: Marcus Cooper > >=20 > > Extend the functionality of the driver to include support of 20 and > > 24 bits per sample. > >=20 > > Signed-off-by: Marcus Cooper > > Signed-off-by: Cl=E9ment P=E9ron > > --- > >=20 > > sound/soc/sunxi/sun4i-i2s.c | 11 +++++++++-- > > 1 file changed, 9 insertions(+), 2 deletions(-) > >=20 > > diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c > > index f78167e152ce..bc7f9343bc7a 100644 > > --- a/sound/soc/sunxi/sun4i-i2s.c > > +++ b/sound/soc/sunxi/sun4i-i2s.c > > @@ -577,6 +577,9 @@ static int sun4i_i2s_hw_params(struct > > snd_pcm_substream *substream,>=20 > > case 16: > > width =3D DMA_SLAVE_BUSWIDTH_2_BYTES; > > break; > >=20 > > + case 32: > > + width =3D DMA_SLAVE_BUSWIDTH_4_BYTES; > > + break; >=20 > This breaks the sun4i variants, because sun4i_i2s_get_wss returns 4 for a= 32 > bit width, but it needs to return 3. I'm not sure what has WSS with physical width and DMA? >=20 > As a side note, I wonder why we use the physical width (the spacing betwe= en > samples in RAM) to drive the slot width. S24_LE takes up 4 bytes per samp= le > in RAM, which we need for DMA. But I don't see why we would want to > transmit the padding over the wire. I would expect it to be transmitted t= he > same as S24_3LE (which has no padding). It did not matter before, because > the only supported format had no padding. Allwinner DMA engines support only 1, 2, 4 and sometimes 8 bytes for bus=20 width, so if sample is 24 bits in size, we have no other way but to transmi= t=20 padding too. Best regards, Jernej >=20 > Regards, > Samuel >=20 > > default: > > dev_err(dai->dev, "Unsupported physical sample width:=20 %d\n", > > =09 > > params_physical_width(params)); > >=20 > > @@ -1063,6 +1066,10 @@ static int sun4i_i2s_dai_probe(struct snd_soc_dai > > *dai)>=20 > > return 0; > > =20 > > } > >=20 > > +#define SUN4I_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | \ > > + SNDRV_PCM_FMTBIT_S20_LE | \ > > + SNDRV_PCM_FMTBIT_S24_LE) > > + > >=20 > > static struct snd_soc_dai_driver sun4i_i2s_dai =3D { > > =20 > > .probe =3D sun4i_i2s_dai_probe, > > .capture =3D { > >=20 > > @@ -1070,14 +1077,14 @@ static struct snd_soc_dai_driver sun4i_i2s_dai = =3D { > >=20 > > .channels_min =3D 1, > > .channels_max =3D 8, > > .rates =3D SNDRV_PCM_RATE_8000_192000, > >=20 > > - .formats =3D SNDRV_PCM_FMTBIT_S16_LE, > > + .formats =3D SUN4I_FORMATS, > >=20 > > }, > > .playback =3D { > > =09 > > .stream_name =3D "Playback", > > .channels_min =3D 1, > > .channels_max =3D 8, > > .rates =3D SNDRV_PCM_RATE_8000_192000, > >=20 > > - .formats =3D SNDRV_PCM_FMTBIT_S16_LE, > > + .formats =3D SUN4I_FORMATS, > >=20 > > }, > > .ops =3D &sun4i_i2s_dai_ops, > > .symmetric_rates =3D 1,