From: Hin-Tak Leung <htl10@users.sourceforge.net>
To: Yu-Hsuan Hsu <yuhsuan@chromium.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] alsa conformance test fails to run for playback (and works for capture)
Date: Tue, 22 Oct 2019 09:39:41 +0000 (UTC) [thread overview]
Message-ID: <925340775.7968852.1571737181376@mail.yahoo.com> (raw)
In-Reply-To: <CAGvk5PoYYikRL90Vn2GxGWngwaaYzZwe6UX_hcjfAnLeBwvy=w@mail.gmail.com>
On Tuesday, 22 October 2019, 04:12:12 BST, Yu-Hsuan Hsu <yuhsuan@chromium.org> wrote:
> Hi Hin-Tak,
> I finally found out the reason! It is because there is a length limit
> of PCM name in ALSA conformance test.
> I have increased it on
> https://chromium-review.googlesource.com/c/chromiumos/platform/audiotest/+/1871792.
> Waiting for the review and merge.
> Thanks a lot for your catch!
> Best,
> Yu-Hsuan
Dear Yu-Hsuan,
Yes, I hand-applied the one-line change, and it now works. I do wonder if you should change the args_set_capture_dev_name() also?
At the moment, MAX_DEVICE_NAME_LENGTH is only used in exactly one place, for the playback device name. Hence the surprise that
capture works but playback does not:
src/alsa_conformance_args.c-119-void args_set_playback_dev_name(struct alsa_conformance_args *args,
src/alsa_conformance_args.c-120- const char *name)
src/alsa_conformance_args.c-121-{
src/alsa_conformance_args.c-122- free(args->playback_dev_name);
src/alsa_conformance_args.c:123: args->playback_dev_name = strndup(name, MAX_DEVICE_NAME_LENGTH);
src/alsa_conformance_args.c-124-}
src/alsa_conformance_args.c-125-
src/alsa_conformance_args.c-126-void args_set_capture_dev_name(struct alsa_conformance_args *args,
src/alsa_conformance_args.c-127- const char *name)
src/alsa_conformance_args.c-128-{
src/alsa_conformance_args.c-129- free(args->capture_dev_name);
src/alsa_conformance_args.c-130- args->capture_dev_name = strdup(name);
src/alsa_conformance_args.c-131-}
src/alsa_conformance_args.c-132-
Regards,
Hin-Tak
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-10-22 9:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 14:14 [alsa-devel] alsa conformance test fails to run for playback (and works for capture) Hin-Tak Leung
2019-10-18 2:59 ` Yu-hsuan Hsu
2019-10-18 10:56 ` Hin-Tak Leung
2019-10-20 10:51 ` Yu-Hsuan Hsu
2019-10-21 13:57 ` Hin-Tak Leung
2019-10-22 3:11 ` Yu-Hsuan Hsu
2019-10-22 9:39 ` Hin-Tak Leung [this message]
2019-10-22 16:13 ` Yu-Hsuan Hsu
2019-10-23 10:06 ` Hin-Tak Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=925340775.7968852.1571737181376@mail.yahoo.com \
--to=htl10@users.sourceforge.net \
--cc=alsa-devel@alsa-project.org \
--cc=yuhsuan@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox