From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Jerome Anand <jerome.anand@intel.com>,
intel-gfx@lists.freedesktop.org, alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org, rakesh.a.ughreja@intel.com
Subject: Re: [PATCH v4 2/5] drm/i915: Add support for audio driver notifications
Date: Mon, 23 Jan 2017 10:32:45 -0600 [thread overview]
Message-ID: <942a0a36-5d1b-030d-770b-f8bcb3122a4f@linux.intel.com> (raw)
In-Reply-To: <871svu82mt.fsf@intel.com>
>> #include <drm/drmP.h>
>> @@ -630,6 +631,10 @@ void intel_audio_codec_enable(struct intel_encoder *intel_encoder,
>> if (acomp && acomp->audio_ops && acomp->audio_ops->pin_eld_notify)
>> acomp->audio_ops->pin_eld_notify(acomp->audio_ops->audio_ptr,
>> (int) port, (int) pipe);
>> +
>> + if (HAS_LPE_AUDIO(dev_priv))
>> + intel_lpe_audio_notify(dev_priv, connector->eld, port,
>> + crtc_state->port_clock);
>
> Seems unnecessary to check for HAS_LPE_AUDIO (which you'll change to
> dev_priv->lpe_audio.platdev, right ;) both in the caller and
> callee. Pick one.
If we test inside of the function, it'd mean an unconditional jump to
test a feature that exists on only two platforms out of the dozen or so
that this i915 driver handles. No objection to do the change but is this
really desired?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-23 16:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 22:22 [PATCH v4 0/5] Add support for Legacy HDMI audio drivers Jerome Anand
2017-01-20 22:22 ` [PATCH v4 1/5] drm/i915: setup bridge for HDMI LPE audio driver Jerome Anand
2017-01-23 10:54 ` Jani Nikula
2017-01-24 8:21 ` Anand, Jerome
2017-01-20 22:22 ` [PATCH v4 2/5] drm/i915: Add support for audio driver notifications Jerome Anand
2017-01-23 10:57 ` Jani Nikula
2017-01-23 16:32 ` Pierre-Louis Bossart [this message]
2017-01-24 7:00 ` Jani Nikula
2017-01-24 8:42 ` Anand, Jerome
2017-01-20 22:22 ` [PATCH v4 3/5] ALSA: add Intel HDMI LPE audio driver for BYT/CHT-T Jerome Anand
2017-01-20 22:22 ` [PATCH v4 4/5] ALSA: x86: hdmi: Add audio support for BYT and CHT Jerome Anand
2017-01-20 11:15 ` Takashi Iwai
2017-01-20 16:45 ` [alsa-devel] " Pierre-Louis Bossart
2017-01-20 19:09 ` Takashi Iwai
2017-01-20 22:22 ` [PATCH v4 5/5] ALSA: x86: hdmi: continue playback even when display resolution changes Jerome Anand
2017-01-23 10:18 ` [PATCH v4 0/5] Add support for Legacy HDMI audio drivers Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=942a0a36-5d1b-030d-770b-f8bcb3122a4f@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jerome.anand@intel.com \
--cc=rakesh.a.ughreja@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).