From: Bard liao <yung-chuan.liao@linux.intel.com>
To: Jaroslav Kysela <perex@perex.cz>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
alsa-devel@alsa-project.org, broonie@kernel.org
Cc: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
lgirdwood@gmail.com, pierre-louis.bossart@linux.intel.com,
ranjani.sridharan@linux.intel.com, daniel.baluta@nxp.com,
bard.liao@intel.com
Subject: Re: [PATCH 5/6] ASoC: Intel: sof_sdw_rt700: add codec prefix
Date: Wed, 23 Sep 2020 17:57:31 +0800 [thread overview]
Message-ID: <9521d264-a79a-44a4-f78d-f4491d143670@linux.intel.com> (raw)
In-Reply-To: <b9481c23-5a09-0518-b05b-c01b2d04e102@perex.cz>
On 9/23/2020 4:34 PM, Jaroslav Kysela wrote:
> Dne 23. 09. 20 v 10:05 Kai Vehmanen napsal(a):
>> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>>
>> Somehow for this codec we never used any prefix for the controls,
>> likely because the test platform has a single SoundWire device.
>>
>> Follow the convention and use the codec prefix across the board to
>> avoid possible conflicts.
>>
>> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
>> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
>> Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
>> ---
>> sound/soc/intel/boards/sof_sdw_rt700.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/sound/soc/intel/boards/sof_sdw_rt700.c b/sound/soc/intel/boards/sof_sdw_rt700.c
>> index bff69cfe27f4..21e7e4a81779 100644
>> --- a/sound/soc/intel/boards/sof_sdw_rt700.c
>> +++ b/sound/soc/intel/boards/sof_sdw_rt700.c
>> @@ -23,9 +23,9 @@ static const struct snd_soc_dapm_widget rt700_widgets[] = {
>>
>> static const struct snd_soc_dapm_route rt700_map[] = {
>> /* Headphones */
>> - { "Headphones", NULL, "HP" },
>> - { "Speaker", NULL, "SPK" },
>> - { "MIC2", NULL, "AMIC" },
>> + { "Headphones", NULL, "rt700 HP" },
>> + { "Speaker", NULL, "rt700 SPK" },
>> + { "rt700 MIC2", NULL, "AMIC" },
> This line looks suspicious. Perhaps, the prefix should be added before AMIC ?
The "rt700" is a prefix for rt700 codec and the "MIC2" is one of rt700's
widget and "AMIC" is machine driver's widget. So "rt700 MIC2" looks correct
to me.
>
> Jaroslav
>
next prev parent reply other threads:[~2020-09-23 9:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 8:05 [PATCH 0/6] ASoC: Intel: sdw machine driver updates for 5.10 Kai Vehmanen
2020-09-23 8:05 ` [PATCH 1/6] ASOC: Intel: sof_sdw: restore playback functionality with max98373 amps Kai Vehmanen
2020-09-23 16:36 ` Mark Brown
2020-09-23 17:23 ` Kai Vehmanen
2020-09-23 8:05 ` [PATCH 2/6] ASoC: Intel: sof_sdw: remove ternary operator Kai Vehmanen
2020-09-23 8:05 ` [PATCH 3/6] ASoC: Intel: add codec name prefix to ACPI machine description Kai Vehmanen
2020-09-23 8:05 ` [PATCH 4/6] ASoC: Intel: sof_sdw: remove hard-coded codec_conf table Kai Vehmanen
2020-09-23 8:05 ` [PATCH 5/6] ASoC: Intel: sof_sdw_rt700: add codec prefix Kai Vehmanen
2020-09-23 8:34 ` Jaroslav Kysela
2020-09-23 9:25 ` Kai Vehmanen
2020-09-23 9:31 ` Jaroslav Kysela
2020-09-23 9:57 ` Bard liao [this message]
2020-09-23 8:05 ` [PATCH 6/6] ASoC: Intel: add support for new SoundWire hardware layout on TGL Kai Vehmanen
2020-09-23 19:00 ` [PATCH 0/6] ASoC: Intel: sdw machine driver updates for 5.10 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9521d264-a79a-44a4-f78d-f4491d143670@linux.intel.com \
--to=yung-chuan.liao@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).