From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Sathya Prakash M R <sathya.prakash.m.r@intel.com>,
Naveen Manohar <naveen.m@intel.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: boards: Fix compile-testing RT1011/RT5682
Date: Thu, 2 Jan 2020 12:50:29 -0600 [thread overview]
Message-ID: <96bf1ce8-0f96-0c81-130b-970427b82fab@linux.intel.com> (raw)
In-Reply-To: <20200102135322.1841053-1-arnd@arndb.de>
On 1/2/20 7:52 AM, Arnd Bergmann wrote:
> On non-x86, the new driver results in a build failure:
>
> sound/soc/intel/boards/cml_rt1011_rt5682.c:14:10: fatal error: asm/cpu_device_id.h: No such file or directory
>
> The asm/cpu_device_id.h header is not actually needed here,
> so don't include it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Indeed it's not needed, thanks for spotting this.
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> I found this last week, but the patch still seems to be needed
> as I could not find a fix in mainline or -next.
>
> Please ignore if there is already a fix in some other tree.
>
>
> sound/soc/intel/boards/cml_rt1011_rt5682.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/intel/boards/cml_rt1011_rt5682.c b/sound/soc/intel/boards/cml_rt1011_rt5682.c
> index a22f97234201..5f1bf6d3800c 100644
> --- a/sound/soc/intel/boards/cml_rt1011_rt5682.c
> +++ b/sound/soc/intel/boards/cml_rt1011_rt5682.c
> @@ -11,7 +11,6 @@
> #include <linux/clk.h>
> #include <linux/dmi.h>
> #include <linux/slab.h>
> -#include <asm/cpu_device_id.h>
> #include <linux/acpi.h>
> #include <sound/core.h>
> #include <sound/jack.h>
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-01-02 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 13:52 [alsa-devel] [PATCH] ASoC: Intel: boards: Fix compile-testing RT1011/RT5682 Arnd Bergmann
2020-01-02 18:50 ` Pierre-Louis Bossart [this message]
2020-01-03 1:05 ` [alsa-devel] Applied "ASoC: Intel: boards: Fix compile-testing RT1011/RT5682" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96bf1ce8-0f96-0c81-130b-970427b82fab@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.m@intel.com \
--cc=sathya.prakash.m.r@intel.com \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox