From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: bytcr_rt5640: Update quirk for Teclast X89
Date: Tue, 3 Dec 2019 18:36:32 -0600 [thread overview]
Message-ID: <988f40c4-04d8-fab2-ff96-5d4a6ba3b383@linux.intel.com> (raw)
In-Reply-To: <20191203221442.2657-1-hdegoede@redhat.com>
On 12/3/19 4:14 PM, Hans de Goede wrote:
> When the Teclast X89 quirk was added we did not have jack-detection
> support yet.
>
> Note the over-current detection limit is set to 2mA instead of the usual
> 1.5mA because this tablet tends to give false-positive button-presses
> when it is set to 1.5mA.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thanks Hans!
> ---
> sound/soc/intel/boards/bytcr_rt5640.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
> index dd2b5ad08659..243f683bc02a 100644
> --- a/sound/soc/intel/boards/bytcr_rt5640.c
> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
> @@ -707,13 +707,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
> BYT_RT5640_MCLK_EN),
> },
> {
> + /* Teclast X89 */
> .matches = {
> DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"),
> DMI_MATCH(DMI_BOARD_NAME, "tPAD"),
> },
> .driver_data = (void *)(BYT_RT5640_IN3_MAP |
> - BYT_RT5640_MCLK_EN |
> - BYT_RT5640_SSP0_AIF1),
> + BYT_RT5640_JD_SRC_JD1_IN4P |
> + BYT_RT5640_OVCD_TH_2000UA |
> + BYT_RT5640_OVCD_SF_1P0 |
> + BYT_RT5640_SSP0_AIF1 |
> + BYT_RT5640_MCLK_EN),
> },
> { /* Toshiba Satellite Click Mini L9W-B */
> .matches = {
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-12-04 1:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 22:14 [alsa-devel] [PATCH] ASoC: Intel: bytcr_rt5640: Update quirk for Teclast X89 Hans de Goede
2019-12-04 0:36 ` Pierre-Louis Bossart [this message]
2019-12-04 12:15 ` [alsa-devel] Applied "ASoC: Intel: bytcr_rt5640: Update quirk for Teclast X89" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=988f40c4-04d8-fab2-ff96-5d4a6ba3b383@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox