From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Dragos Tarcatu <dragos_tarcatu@mentor.com>,
alsa-devel@alsa-project.org,
sound-open-firmware@alsa-project.org, tiwai@suse.de,
Pan Xiuli <xiuli.pan@linux.intel.com>,
Daniel Baluta <daniel.baluta@gmail.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
liam.r.girdwood@linux.intel.com, vkoul@kernel.org,
andriy.shevchenko@linux.intel.com,
Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH v6 03/14] ASoC: SOF: Add driver debug support.
Date: Fri, 19 Apr 2019 11:09:51 -0500 [thread overview]
Message-ID: <9a5609c3-df05-2dcc-69b7-b10fe2dc221d@linux.intel.com> (raw)
In-Reply-To: <20190419155458.GV2803@sirena.org.uk>
Thanks for the review Mark
On 4/19/19 10:54 AM, Mark Brown wrote:
> On Fri, Apr 12, 2019 at 11:05:08AM -0500, Pierre-Louis Bossart wrote:
>
>> + if (pm_runtime_active(sdev->dev) ||
>> + dfse->access_type == SOF_DEBUGFS_ACCESS_ALWAYS) {
>> + memcpy_fromio(buf, dfse->io_mem + pos, size);
>> + } else {
>> + dev_info(sdev->dev,
>> + "Copying cached debugfs data\n");
>> + memcpy(buf, dfse->cache_buf + pos, size);
>> + }
>
> Might this get a bit noisy if we start hitting the info case?
Indeed, I recall we discussed removing this log but it's still there. We
can fix this with a follow-up patch or in a v7 depending if there are
other comments.
next prev parent reply other threads:[~2019-04-19 16:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 16:05 [PATCH v6 00/14] ASoC: Sound Open Firmware (SOF) core Pierre-Louis Bossart
2019-04-12 16:05 ` [PATCH v6 01/14] ASoC: SOF: Add Sound Open Firmware driver core Pierre-Louis Bossart
2019-04-27 17:53 ` Applied "ASoC: SOF: Add Sound Open Firmware driver core" to the asoc tree Mark Brown
2019-04-12 16:05 ` [PATCH v6 02/14] ASoC: SOF: Add Sound Open Firmware KControl support Pierre-Louis Bossart
2019-04-27 17:53 ` Applied "ASoC: SOF: Add Sound Open Firmware KControl support" to the asoc tree Mark Brown
2019-04-12 16:05 ` [PATCH v6 03/14] ASoC: SOF: Add driver debug support Pierre-Louis Bossart
2019-04-19 15:54 ` Mark Brown
2019-04-19 16:09 ` Pierre-Louis Bossart [this message]
2019-04-27 17:53 ` Applied "ASoC: SOF: Add driver debug support." to the asoc tree Mark Brown
2019-04-12 16:05 ` [PATCH v6 04/14] ASoC: SOF: Add support for IPC IO between DSP and Host Pierre-Louis Bossart
2019-04-27 17:53 ` Applied "ASoC: SOF: Add support for IPC IO between DSP and Host" to the asoc tree Mark Brown
2019-04-12 16:05 ` [PATCH v6 05/14] ASoC: SOF: Add PCM operations support Pierre-Louis Bossart
2019-04-27 17:53 ` Applied "ASoC: SOF: Add PCM operations support" to the asoc tree Mark Brown
2019-04-12 16:05 ` [PATCH v6 06/14] ASoC: SOF: Add support for loading topologies Pierre-Louis Bossart
2019-04-27 17:53 ` Applied "ASoC: SOF: Add support for loading topologies" to the asoc tree Mark Brown
2019-04-12 16:05 ` [PATCH v6 07/14] ASoC: SOF: Add DSP firmware logger support Pierre-Louis Bossart
2019-04-27 17:53 ` Applied "ASoC: SOF: Add DSP firmware logger support" to the asoc tree Mark Brown
2019-04-12 16:05 ` [PATCH v6 08/14] ASoC: SOF: Add DSP HW abstraction operations Pierre-Louis Bossart
2019-04-27 17:52 ` Applied "ASoC: SOF: Add DSP HW abstraction operations" to the asoc tree Mark Brown
2019-04-12 16:05 ` [PATCH v6 09/14] ASoC: SOF: Add firmware loader support Pierre-Louis Bossart
2019-04-27 17:52 ` Applied "ASoC: SOF: Add firmware loader support" to the asoc tree Mark Brown
2019-04-12 16:05 ` [PATCH v6 10/14] ASoC: SOF: Add userspace ABI support Pierre-Louis Bossart
2019-04-27 17:52 ` Applied "ASoC: SOF: Add userspace ABI support" to the asoc tree Mark Brown
2019-04-12 16:05 ` [PATCH v6 11/14] ASoC: SOF: Add PM support Pierre-Louis Bossart
2019-04-27 17:52 ` Applied "ASoC: SOF: Add PM support" to the asoc tree Mark Brown
2019-04-12 16:05 ` [PATCH v6 12/14] ASoC: SOF: Add Nocodec machine driver support Pierre-Louis Bossart
2019-04-27 17:52 ` Applied "ASoC: SOF: Add Nocodec machine driver support" to the asoc tree Mark Brown
2019-04-12 16:05 ` [PATCH v6 13/14] ASoC: SOF: Add xtensa support Pierre-Louis Bossart
2019-04-27 17:52 ` Applied "ASoC: SOF: Add xtensa support" to the asoc tree Mark Brown
2019-04-12 16:05 ` [PATCH v6 14/14] ASoC: SOF: Add utils Pierre-Louis Bossart
2019-04-27 17:52 ` Applied "ASoC: SOF: Add utils" to the asoc tree Mark Brown
2019-04-23 15:40 ` [PATCH v6 00/14] ASoC: Sound Open Firmware (SOF) core Takashi Iwai
2019-04-23 19:25 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a5609c3-df05-2dcc-69b7-b10fe2dc221d@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alan@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=daniel.baluta@gmail.com \
--cc=dragos_tarcatu@mentor.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
--cc=xiuli.pan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).