[PATCH 22/66] sound/oss/v_midi.h: Checkpatch cleanup

[PATCH 22/66] sound/oss/v_midi.h: Checkpatch cleanup

[Andrea Gelmini]

sound/oss/v_midi.h:5: ERROR: code indent should use tabs where possible
sound/oss/v_midi.h:7: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 sound/oss/v_midi.h |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/sound/oss/v_midi.h b/sound/oss/v_midi.h
index 1b86cb4..08e2185 100644
--- a/sound/oss/v_midi.h
+++ b/sound/oss/v_midi.h
@@ -2,9 +2,9 @@ typedef struct vmidi_devc {
 	   int dev;
 
 	/* State variables */
- 	   int opened;
+	   int opened;
 	   spinlock_t lock;
-	
+
 	/* MIDI fields */
 	   int my_mididev;
 	   int pair_mididev;
@@ -12,4 +12,3 @@ typedef struct vmidi_devc {
 	   int intr_active;
 	   void (*midi_input_intr) (int dev, unsigned char data);
 	} vmidi_devc;
-
-- 
1.7.0.90.g251a4

[PATCH 38/66] sound/oss/coproc.h: Checkpatch cleanup

[Andrea Gelmini]

sound/oss/coproc.h:7: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 sound/oss/coproc.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/oss/coproc.h b/sound/oss/coproc.h
index 7306346..7bec21b 100644
--- a/sound/oss/coproc.h
+++ b/sound/oss/coproc.h
@@ -4,7 +4,7 @@
  */
 
 /*
- * Coprocessor access types 
+ * Coprocessor access types
  */
 #define COPR_CUSTOM		0x0001	/* Custom applications */
 #define COPR_MIDI		0x0002	/* MIDI (MPU-401) emulation */
-- 
1.7.0.90.g251a4

[PATCH 48/66] sound/usb/caiaq/midi.h: Checkpatch cleanup

[Andrea Gelmini]

sound/usb/caiaq/midi.h:6: ERROR: "foo* bar" should be "foo *bar"

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 sound/usb/caiaq/midi.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/usb/caiaq/midi.h b/sound/usb/caiaq/midi.h
index 9d16db0..380f984 100644
--- a/sound/usb/caiaq/midi.h
+++ b/sound/usb/caiaq/midi.h
@@ -3,6 +3,6 @@
 
 int snd_usb_caiaq_midi_init(struct snd_usb_caiaqdev *dev);
 void snd_usb_caiaq_midi_handle_input(struct snd_usb_caiaqdev *dev, int port, const char *buf, int len);
-void snd_usb_caiaq_midi_output_done(struct urb* urb);
+void snd_usb_caiaq_midi_output_done(struct urb *urb);
 
 #endif /* CAIAQ_MIDI_H */
-- 
1.7.0.90.g251a4

Re: [PATCH 48/66] sound/usb/caiaq/midi.h: Checkpatch cleanup

[Daniel Mack]

On Sat, Feb 27, 2010 at 05:51:29PM +0100, Andrea Gelmini wrote:
> sound/usb/caiaq/midi.h:6: ERROR: "foo* bar" should be "foo *bar"
> 
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>

Acked-by: Daniel Mack <daniel@caiaq.de>


> ---
>  sound/usb/caiaq/midi.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/usb/caiaq/midi.h b/sound/usb/caiaq/midi.h
> index 9d16db0..380f984 100644
> --- a/sound/usb/caiaq/midi.h
> +++ b/sound/usb/caiaq/midi.h
> @@ -3,6 +3,6 @@
>  
>  int snd_usb_caiaq_midi_init(struct snd_usb_caiaqdev *dev);
>  void snd_usb_caiaq_midi_handle_input(struct snd_usb_caiaqdev *dev, int port, const char *buf, int len);
> -void snd_usb_caiaq_midi_output_done(struct urb* urb);
> +void snd_usb_caiaq_midi_output_done(struct urb *urb);
>  
>  #endif /* CAIAQ_MIDI_H */
> -- 
> 1.7.0.90.g251a4
> 

Re: [PATCH 22/66] sound/oss/v_midi.h: Checkpatch cleanup

[Takashi Iwai]

At Sat, 27 Feb 2010 17:51:03 +0100,
Andrea Gelmini wrote:
> 
> sound/oss/v_midi.h:5: ERROR: code indent should use tabs where possible
> sound/oss/v_midi.h:7: ERROR: trailing whitespace
> 
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>

Applied all three patches for sound/* now.  Thanks.


Takashi

Re: [PATCH 22/66] sound/oss/v_midi.h: Checkpatch cleanup

[Andrea Gelmini]

2010/3/2 Takashi Iwai <tiwai@suse.de>:
Hi Takashi,
    thanks a lot for you reply.

> Applied all three patches for sound/* now.  Thanks.

Thanks a lot.
If you care I can check all sound subtree.

Thanks again,
Andrea