alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	alsa-devel@alsa-project.org
Cc: tiwai@suse.de, Paul Cercueil <paul@crapouillou.net>, broonie@kernel.org
Subject: Re: [PATCH] ASoC: Intel: bytcht_es8316: fix compilation warning and quirk handling
Date: Thu, 18 Apr 2019 13:57:10 +0200	[thread overview]
Message-ID: <9d12bcab-40d8-c6c6-017a-cbaad64903d8@redhat.com> (raw)
In-Reply-To: <cbd7885e-07a0-fadb-b5dd-21e7cdec9b25@linux.intel.com>

Hi,

On 10-04-19 19:58, Pierre-Louis Bossart wrote:
> 
>> There is a good reason to use -1 for quirk-override not set.
>>
>> The user may want to override the quirk variable to actual 0, on
>> CHT we default to:
>>
>>                  /* Others default to internal-mic-in1-map, mono-speaker */
>>                  quirk = BYT_CHT_ES8316_INTMIC_IN1_MAP |
>>                          BYT_CHT_ES8316_MONO_SPEAKER;
>>
>> Which is 0x20000, if the user now justs wants to clear the
>> BYT_CHT_ES8316_MONO_SPEAKER flag through the override, then the user
>> must be able to specify 0 as override.
> 
> ok, I accept the argument but then why don't we do the same in other machine drivers? I could make the same argument for bytcr_rt5640/51, so we should align all machine drivers using this mechanism.

I agree that ideally all machine drivers should be updated to use -1
for "quirk override not set". The drivers which are currently not
using -1 already had their current quirk-override implementation in
place before I started working on them.

Regards,

Hans


_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2019-04-18 11:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-10 16:05 [PATCH] ASoC: Intel: bytcht_es8316: fix compilation warning and quirk handling Pierre-Louis Bossart
2019-04-10 16:16 ` Hans de Goede
2019-04-10 17:58   ` Pierre-Louis Bossart
2019-04-18 11:57     ` Hans de Goede [this message]
2019-04-18 12:57       ` Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d12bcab-40d8-c6c6-017a-cbaad64903d8@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=paul@crapouillou.net \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).