From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9253C433EF for ; Wed, 8 Sep 2021 17:55:47 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86C2D6113D for ; Wed, 8 Sep 2021 17:55:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 86C2D6113D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 87E5916A8; Wed, 8 Sep 2021 19:54:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 87E5916A8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1631123744; bh=AIZ4RSbR2Y4m8IDCdTQOkXLoBaQ495UgNtOybOO34B4=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=OyNzNoDxY63I1FXxwh0VfkWVfQLli92ckxh64PL29tab/UEJqMlwDS+ThCSrkf18c wTRrqNIWR8Y2uHCC7P5phlbtXpbO8NJW05ePvfGDZBOwCGQDWkJIQy4bVZo/kRnT+t //cSOJKF6OmHuJ/pR91qyn09+AYy6pWXSQqsH50s= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 24812F804A9; Wed, 8 Sep 2021 19:54:13 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1F736F802E7; Wed, 8 Sep 2021 19:54:10 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DA65EF80149 for ; Wed, 8 Sep 2021 19:54:02 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DA65EF80149 X-IronPort-AV: E=McAfee;i="6200,9189,10101"; a="207788596" X-IronPort-AV: E=Sophos;i="5.85,278,1624345200"; d="scan'208";a="207788596" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2021 10:53:58 -0700 X-IronPort-AV: E=Sophos;i="5.85,278,1624345200"; d="scan'208";a="693503964" Received: from sgevirtz-mobl.amr.corp.intel.com (HELO [10.209.141.208]) ([10.209.141.208]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2021 10:53:57 -0700 Subject: Re: [PATCH] ASoC: rt1011: add i2s reference control for rt1011 To: Jack Yu , "broonie@kernel.org" , "lgirdwood@gmail.com" References: <20210906101208.11585-1-jack.yu@realtek.com> <3062f5e5-d2d7-8150-ef89-989af3b4b1d6@linux.intel.com> <05e92a24b1c34daeb64e5b222a3ae337@realtek.com> From: Pierre-Louis Bossart Message-ID: <9f76a420-44c6-ad6d-4442-275ba4459b40@linux.intel.com> Date: Wed, 8 Sep 2021 10:22:42 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <05e92a24b1c34daeb64e5b222a3ae337@realtek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Cc: Oder Chiou , "alsa-devel@alsa-project.org" , "lars@metafoo.de" , =?UTF-8?B?a2VudF9jaGVuQHJlYWx0ZWsuY29tIFvpmbPlu7rlro9d?= , =?UTF-8?B?RGVyZWsgW+aWueW+t+e+qV0=?= , =?UTF-8?B?U2h1bWluZyBb6IyD5pu46YqYXQ==?= , "Flove\(HsinFu\)" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 9/7/21 9:17 PM, Jack Yu wrote: > >> -----Original Message----- >> From: Pierre-Louis Bossart >> Sent: Tuesday, September 7, 2021 10:54 PM >> To: Jack Yu ; broonie@kernel.org; >> lgirdwood@gmail.com >> Cc: Oder Chiou ; alsa-devel@alsa-project.org; >> lars@metafoo.de; kent_chen@realtek.com [陳建宏] >> ; Derek [方德義] ; >> Shuming [范書銘] ; Flove(HsinFu) >> >> Subject: Re: [PATCH] ASoC: rt1011: add i2s reference control for rt1011 >> >> On 9/6/21 5:12 AM, Jack Yu wrote: >>> Add i2s reference control for rt1011 amp. >>> >>> Signed-off-by: Jack Yu >> >>> +static const char * const rt1011_i2s_ref[] = { >>> + "None", "Left Channel", "Right Channel" >>> +}; >> >>> +enum { >>> + RT1011_I2S_REF_NONE, >>> + RT1011_I2S_REF_LEFT_CH, >>> + RT1011_I2S_REF_RIGHT_CH, >>> +}; >> >> is it possible to get Left-Right-mix (mixed on rt1011) and Left-Right (two >> channels, with the application selecting what they want)? > > It's a mono amp, so there's no Left-Right-mix setting. > And for the choice of Left-Right channel, it's already available with this patch. So it's just to place a mono reference in either left or right channel of the I2S link? Why not dual-mono as well then?