alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	<alsa-devel@alsa-project.org>
Cc: tiwai@suse.de, broonie@kernel.org, Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH] ASoC: Intel: boards: fix randconfig issue
Date: Wed, 9 Mar 2022 18:04:55 +0100	[thread overview]
Message-ID: <9fc8a959-44d4-6f23-c07f-23da895e674e@intel.com> (raw)
In-Reply-To: <20220308202318.401358-1-pierre-louis.bossart@linux.intel.com>

On 2022-03-08 9:23 PM, Pierre-Louis Bossart wrote:
> on x86_64:
> 
> ERROR: modpost: "sof_dai_get_bclk"
> [sound/soc/intel/boards/snd-soc-intel-sof-cirrus-common.ko] undefined!
> 
> ERROR: modpost: "sof_dai_get_mclk"
> [sound/soc/intel/boards/snd-soc-intel-sof-realtek-common.ko]
> undefined!
> 
> This comes from a missing dependency on at least ONE SOF platform
> being selected. This dependency exists for all other machine drivers,
> this was missed in the earlier reviews.
> 
> Fixes: 2fe14ff61bd6 ("ASoC: Intel: sof_ssp_amp: rename driver and support cs35l41 amplifier")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>


Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>

>   sound/soc/intel/boards/Kconfig | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig
> index a62785893bec..f3873b5bea87 100644
> --- a/sound/soc/intel/boards/Kconfig
> +++ b/sound/soc/intel/boards/Kconfig
> @@ -616,6 +616,8 @@ config SND_SOC_INTEL_SOF_DA7219_MAX98373_MACH
>   
>   endif ## SND_SOC_SOF_JASPERLAKE
>   
> +if SND_SOC_SOF_HDA_LINK
> +
>   config SND_SOC_INTEL_SOF_SSP_AMP_MACH
>   	tristate "SOF with amplifiers in I2S Mode"
>   	depends on I2C && ACPI
> @@ -632,6 +634,7 @@ config SND_SOC_INTEL_SOF_SSP_AMP_MACH
>   	   with RT1308/CS35L41 I2S audio codec.
>   	   Say Y if you have such a device.
>   	   If unsure select "N".
> +endif ## SND_SOC_SOF_HDA_LINK
>   
>   if SND_SOC_SOF_ELKHARTLAKE
>   

  parent reply	other threads:[~2022-03-09 17:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-08 20:23 [PATCH] ASoC: Intel: boards: fix randconfig issue Pierre-Louis Bossart
2022-03-08 21:05 ` Randy Dunlap
2022-03-09 17:04 ` Cezary Rojewski [this message]
2022-03-10 11:35 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9fc8a959-44d4-6f23-c07f-23da895e674e@intel.com \
    --to=cezary.rojewski@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=rdunlap@infradead.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).