From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Marek Vasut <marex@denx.de>, alsa-devel@alsa-project.org
Cc: Igor Opaniuk <igor.opaniuk@toradex.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Oleksandr Suvorov <oleksandr.suvorov@toradex.com>,
Mark Brown <broonie@kernel.org>,
festevam@gmail.com
Subject: Re: [alsa-devel] [PATCH V2 1/2] regulator: core: Add regulator_is_equal() helper
Date: Tue, 14 Jan 2020 13:48:53 -0600 [thread overview]
Message-ID: <9fd0bdd7-4599-a84d-9807-c33541035b4a@linux.intel.com> (raw)
In-Reply-To: <20191220164450.1395038-1-marex@denx.de>
> +static inline bool
> +regulator_is_equal(struct regulator *reg1, struct regulator *reg2);
> +{
> + return false;
> +}
> #endif
this breaks my build... shouldn't this be:
diff --git a/include/linux/regulator/consumer.h
b/include/linux/regulator/consumer.h
index 2c89d886595c..6a92fd3105a3 100644
--- a/include/linux/regulator/consumer.h
+++ b/include/linux/regulator/consumer.h
@@ -596,7 +596,7 @@ regulator_bulk_set_supply_names(struct
regulator_bulk_data *consumers,
}
static inline bool
-regulator_is_equal(struct regulator *reg1, struct regulator *reg2);
+regulator_is_equal(struct regulator *reg1, struct regulator *reg2)
{
return false;
}
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-01-14 19:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 16:44 [alsa-devel] [PATCH V2 1/2] regulator: core: Add regulator_is_equal() helper Marek Vasut
2019-12-20 16:44 ` [alsa-devel] [PATCH V2 2/2] ASoC: sgtl5000: Fix VDDA and VDDIO comparison Marek Vasut
2020-01-14 16:09 ` [alsa-devel] Applied "ASoC: sgtl5000: Fix VDDA and VDDIO comparison" to the asoc tree Mark Brown
2020-01-14 16:09 ` [alsa-devel] Applied "regulator: core: Add regulator_is_equal() helper" " Mark Brown
2020-01-14 19:48 ` Pierre-Louis Bossart [this message]
2020-01-16 11:59 ` [alsa-devel] [PATCH V2 1/2] regulator: core: Add regulator_is_equal() helper Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fd0bdd7-4599-a84d-9807-c33541035b4a@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=igor.opaniuk@toradex.com \
--cc=lgirdwood@gmail.com \
--cc=marcel.ziswiler@toradex.com \
--cc=marex@denx.de \
--cc=oleksandr.suvorov@toradex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox