[PATCH] ASoC: Blackfin TDM: fix missed snd_soc_dai_get_drvdata update

[PATCH] ASoC: Blackfin TDM: fix missed snd_soc_dai_get_drvdata update

[Mike Frysinger]

One spot was missed in this driver when converting from
snd_soc_dai.private_data to snd_soc_dai_get_drvdata.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 sound/soc/blackfin/bf5xx-tdm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/blackfin/bf5xx-tdm.c b/sound/soc/blackfin/bf5xx-tdm.c
index 1251239..b2cf239 100644
--- a/sound/soc/blackfin/bf5xx-tdm.c
+++ b/sound/soc/blackfin/bf5xx-tdm.c
@@ -210,7 +210,7 @@ static int bf5xx_tdm_set_channel_map(struct snd_soc_dai *dai,
 #ifdef CONFIG_PM
 static int bf5xx_tdm_suspend(struct snd_soc_dai *dai)
 {
-	struct sport_device *sport = dai->private_data;
+	struct sport_device *sport = snd_soc_dai_get_drvdata(dai);
 
 	if (!dai->active)
 		return 0;
-- 
1.7.4.rc1

Re: [stable] [PATCH] ASoC: Blackfin TDM: fix missed snd_soc_dai_get_drvdata update

[Greg KH]

On Tue, Jan 11, 2011 at 11:08:19PM -0500, Mike Frysinger wrote:
> One spot was missed in this driver when converting from
> snd_soc_dai.private_data to snd_soc_dai_get_drvdata.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Please read Documentation/stable_kernel_rules.txt for how to get patches
into the stable kernel tree (hint, add cc: stable in the signed-off-by
line).  Copying the patches to the stable and stable-review lists
(stable-review is only for the review of the stable releases) will cause
them to get lost as they aren't in Linus's tree yet, so I don't know the
git commit id of it.

Hope this helps,

greg k-h

Re: [PATCH] ASoC: Blackfin TDM: fix missed snd_soc_dai_get_drvdata update

[Mark Brown]

On Tue, Jan 11, 2011 at 11:08:19PM -0500, Mike Frysinger wrote:
> One spot was missed in this driver when converting from
> snd_soc_dai.private_data to snd_soc_dai_get_drvdata.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Ccing in Liam - Mike, please remember to CC maintainers on patches - and
dropping the stable lists for now.


> ---
>  sound/soc/blackfin/bf5xx-tdm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/blackfin/bf5xx-tdm.c b/sound/soc/blackfin/bf5xx-tdm.c
> index 1251239..b2cf239 100644
> --- a/sound/soc/blackfin/bf5xx-tdm.c
> +++ b/sound/soc/blackfin/bf5xx-tdm.c
> @@ -210,7 +210,7 @@ static int bf5xx_tdm_set_channel_map(struct snd_soc_dai *dai,
>  #ifdef CONFIG_PM
>  static int bf5xx_tdm_suspend(struct snd_soc_dai *dai)
>  {
> -	struct sport_device *sport = dai->private_data;
> +	struct sport_device *sport = snd_soc_dai_get_drvdata(dai);
>  
>  	if (!dai->active)
>  		return 0;
> -- 
> 1.7.4.rc1
> 

Re: [PATCH] ASoC: Blackfin TDM: fix missed snd_soc_dai_get_drvdata update

[Mike Frysinger]

On Thu, Jan 13, 2011 at 08:55, Mark Brown wrote:
> On Tue, Jan 11, 2011 at 11:08:19PM -0500, Mike Frysinger wrote:
>> One spot was missed in this driver when converting from
>> snd_soc_dai.private_data to snd_soc_dai_get_drvdata.
>>
>> Signed-off-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
>
> Ccing in Liam - Mike, please remember to CC maintainers on patches - and
> dropping the stable lists for now.

i thought you were the ASoC maintainer
-mike

Re: [uclinux-dist-devel] [PATCH] ASoC: Blackfin TDM: fix missed snd_soc_dai_get_drvdata update

[Mark Brown]

On Thu, Jan 13, 2011 at 11:52:02AM -0500, Mike Frysinger wrote:
> On Thu, Jan 13, 2011 at 08:55, Mark Brown wrote:

> > Ccing in Liam - Mike, please remember to CC maintainers on patches - and
> > dropping the stable lists for now.

> i thought you were the ASoC maintainer

We comaintain ASoC, we generally both review everything except during
vacations.

Re: [uclinux-dist-devel] [PATCH] ASoC: Blackfin TDM: fix missed snd_soc_dai_get_drvdata update

[Mike Frysinger]

On Thu, Jan 13, 2011 at 12:12, Mark Brown wrote:
> On Thu, Jan 13, 2011 at 11:52:02AM -0500, Mike Frysinger wrote:
>> On Thu, Jan 13, 2011 at 08:55, Mark Brown wrote:
>> > Ccing in Liam - Mike, please remember to CC maintainers on patches - and
>> > dropping the stable lists for now.
>>
>> i thought you were the ASoC maintainer
>
> We comaintain ASoC, we generally both review everything except during
> vacations.

np ... i'll update my .git/mail
-mike

Re: [PATCH] ASoC: Blackfin TDM: fix missed snd_soc_dai_get_drvdata update

[Liam Girdwood]

On Tue, 2011-01-11 at 23:08 -0500, Mike Frysinger wrote:
> One spot was missed in this driver when converting from
> snd_soc_dai.private_data to snd_soc_dai_get_drvdata.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---

Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

Re: [PATCH] ASoC: Blackfin TDM: fix missed snd_soc_dai_get_drvdata update

[Mark Brown]

On Tue, Jan 11, 2011 at 11:08:19PM -0500, Mike Frysinger wrote:
> One spot was missed in this driver when converting from
> snd_soc_dai.private_data to snd_soc_dai_get_drvdata.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Applied, thanks.