Re: [PATCH v5 1/9] davinci: EMAC support for Omapl138-Hawkboard

[Victor Rodriguez <vm.rod25@gmail.com>]

On Thu, Oct 28, 2010 at 9:18 AM, Nori, Sekhar <nsekhar@ti.com> wrote:
> On Thu, Oct 28, 2010 at 19:34:10, Nori, Sekhar wrote:
>> Hi Victor,
>>
>> Sorry for jumping late on this. Some comments below:
>>
>> On Tue, Oct 19, 2010 at 23:36:19, vm.rod25@gmail.com wrote:
>> > From: Victor Rodriguez <victor.rodriguez@sasken.com>
>> >
>> > This patch adds EMAC support for the Hawkboard-L138 system
>> >
>> > Signed-off-by: Victor Rodriguez <victor.rodriguez@sasken.com>
>> > ---
>> >  arch/arm/mach-davinci/board-omapl138-hawk.c |   47 +++++++++++++++++++++++++++
>> >  1 files changed, 47 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c b/arch/arm/mach-davinci/board-omapl138-hawk.c
>> > index c472dd8..8633245 100644
>> > --- a/arch/arm/mach-davinci/board-omapl138-hawk.c
>> > +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c
>> > @@ -19,6 +19,51 @@
>> >
>> >  #include <mach/cp_intc.h>
>> >  #include <mach/da8xx.h>
>> > +#include <mach/mux.h>
>> > +
>> > +#define HAWKBOARD_PHY_ID             "0:07"
>> > +
>> > +static short omapl138_hawk_mii_pins[] __initdata = {
>> > +     DA850_MII_TXEN, DA850_MII_TXCLK, DA850_MII_COL, DA850_MII_TXD_3,
>> > +     DA850_MII_TXD_2, DA850_MII_TXD_1, DA850_MII_TXD_0, DA850_MII_RXER,
>> > +     DA850_MII_CRS, DA850_MII_RXCLK, DA850_MII_RXDV, DA850_MII_RXD_3,
>> > +     DA850_MII_RXD_2, DA850_MII_RXD_1, DA850_MII_RXD_0, DA850_MDIO_CLK,
>> > +     DA850_MDIO_D,
>> > +     -1
>>
>> -1 need not be a new line. In any case, please include a ',' after it.
>
> The justification for a ',' in the end is that it makes it easier
> to add new initialization elements. Since -1 is going to be
> the last one anyway, please ignore this comment.
>
> Thanks,
> Sekhar
>
>

Ok so let me see if I understand The only change that I should do is to remove

> +     if (!machine_is_omapl138_hawkboard())
> +             return;

right ?

Regards

Victor