alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: pl bossart <bossart.nospam@gmail.com>
To: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: add support for disabling period irq
Date: Mon, 8 Nov 2010 15:43:15 -0600	[thread overview]
Message-ID: <AANLkTikCQ_2S8FCVJOVA7Dop22kcsso6+M3+cACTdbz2@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1011082203330.29422@eeebox2.perex-int.cz>

done from the avail_update call invoked from an application.
>>
>> ok, so I re-implemented all the points found in the reviews except for
>> this thread. There's already some code to see if we go beyond the
>> buffer boundaries, so I am not sure what the 'linear position' means.
>
> Linear means that new hw_ptr must be always behind the previous hw_ptr.

I got that. But there are already some checks in pcm_lib.c,

	/* new_hw_ptr might be lower than old_hw_ptr in case when */
	/* pointer crosses the end of the ring buffer */
	if (new_hw_ptr < old_hw_ptr) {
		hw_base += runtime->buffer_size;
		if (hw_base >= runtime->boundary)
			hw_base = 0;
		new_hw_ptr = hw_base + pos;
	}

So do I need to add any additional checks? Or did I miss something in
your discussion with Takashi?
-Pierre

  reply	other threads:[~2010-11-08 21:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-01 22:12 [PATCH] ALSA: add support for disabling period irq Pierre-Louis Bossart
2010-11-01 22:41 ` Jaroslav Kysela
2010-11-02  0:16   ` pl bossart
2010-11-02  7:14     ` Jaroslav Kysela
2010-11-01 23:46 ` Raymond Yau
2010-11-02  7:34 ` Takashi Iwai
2010-11-02  8:17   ` Jaroslav Kysela
2010-11-02  8:22     ` Takashi Iwai
2010-11-02  8:26       ` Jaroslav Kysela
2010-11-02  8:41         ` Takashi Iwai
2010-11-02  9:02           ` Jaroslav Kysela
2010-11-02  9:14             ` Takashi Iwai
2010-11-02  9:22               ` Jaroslav Kysela
2010-11-02  9:26                 ` Takashi Iwai
2010-11-08 20:52                 ` pl bossart
2010-11-08 21:04                   ` Jaroslav Kysela
2010-11-08 21:43                     ` pl bossart [this message]
2010-11-02 12:57         ` pl bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikCQ_2S8FCVJOVA7Dop22kcsso6+M3+cACTdbz2@mail.gmail.com \
    --to=bossart.nospam@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).