alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Raymond Yau <superquad.vortex2@gmail.com>
To: ALSA Development Mailing List <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] Two patches for Alsa-plugins (pulse)
Date: Thu, 24 Jun 2010 07:44:26 +0800	[thread overview]
Message-ID: <AANLkTikRPPlq_3_m37I6wctz4-5OPdnIqNU8v6wcx5bB@mail.gmail.com> (raw)
In-Reply-To: <4C22670D.8010104@epost.diwic.se>

2010/6/24 David Henningsson <launchpad.web@epost.diwic.se>

> These two patches are being used in Ubuntu Lucid (released this April)
> and are working well enough to have people asking us to backport them to
> Karmic. Today I got an email, asking for the upstream status of one of
> these patches, since he wanted them in Fedora. If posting them here
> isn't the correct way to upstream them, please tell me so.
>
> The first one (Fix invalid buffer pointer return value) fixes broken logic:
>
> This patch improves recovering from underruns, and prevents hangs inside
> snd_pcm_write* and snd_pcm_read* due to snd_pcm_avail* returning too
> low values. It especially helps low latency situations.
>
> The second one (Do not report underruns to the ALSA layer) is more a
> change of behavior, which could be questioned. The arguments for
> removing that code are these:
>
>  * If pulseaudio gets an underrun, the normal way to end that underrun
> is to feed it with more buffers. This is different from the ALSA way of
> dealing with underruns, which requires hardware buffer pointers to be
> reset.
>  * In addition, underrun signals are delivered asynchronously from
> pulseaudio. This means that there might be more buffers on the way to
> pulseaudio when the underrun is reported, making the underrun obsolete.
> Unfortunately, there is currently no known way to determine whether this
> is the case or not.
>
> // David
>
>
>
Are there any test program which can reproduce this condition ?

any program similar to alsa-time-test.c which PA developer use to test the
alsa-driver but alsa-time-test.c aborted when I specify to use the pulse
device

  reply	other threads:[~2010-06-23 23:44 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-23 19:57 [PATCH] Two patches for Alsa-plugins (pulse) David Henningsson
2010-06-23 23:44 ` Raymond Yau [this message]
2010-06-24  6:42 ` Takashi Iwai
2010-06-25 10:41   ` David Henningsson
2010-06-25 10:57     ` Colin Guthrie
2010-07-05  6:06     ` Takashi Iwai
2010-07-09 12:10       ` Takashi Iwai
2010-07-09 13:13         ` Raymond Yau
2010-07-09 16:23           ` Takashi Iwai
2010-07-09 17:50             ` David Henningsson
2010-07-09 22:58               ` Raymond Yau
2010-07-10  6:42                 ` David Henningsson
2010-07-13  5:08                   ` Raymond Yau
2010-07-13  6:57                     ` David Henningsson
2010-07-13  8:32                       ` Raymond Yau
2010-07-10  2:07               ` Raymond Yau
2010-07-29  7:11               ` Raymond Yau
2010-07-29  8:14                 ` David Henningsson
2010-07-29 13:38                   ` Raymond Yau
2010-07-17  4:30             ` Raymond Yau
2010-07-12  2:13 ` Raymond Yau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikRPPlq_3_m37I6wctz4-5OPdnIqNU8v6wcx5bB@mail.gmail.com \
    --to=superquad.vortex2@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).