From: pl bossart <bossart.nospam@gmail.com>
To: Jaroslav Kysela <perex@perex.cz>
Cc: ALSA development <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ALSA: add support for disabling period irq
Date: Mon, 1 Nov 2010 19:16:42 -0500 [thread overview]
Message-ID: <AANLkTik_9eh2=TkCjTCOoxp5PMtdxpZ6qk7Eio8ABfmd@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1011012325540.29422@eeebox2.perex-int.cz>
Thanks Jaroslav for this quick review.
> Use one 'if' and a goto behind the last condition to simplify things.
will do
>> struct snd_interval {
>> unsigned int min, max;
>
> The PCM protocol version should be increased.
Humm, this one I don't understand. I didn't change anything, just used
a bit in an existing flag? What are you specifically referring to?
>> @@ -297,6 +297,7 @@ struct snd_pcm_runtime {
>> unsigned int info;
>> unsigned int rate_num;
>> unsigned int rate_den;
>> + bool no_period_irq;
>
> I would use an unsigned int bit field rather than bool in this case to make
> addition in-line with other structures in this file.
will do.
-Pierre
next prev parent reply other threads:[~2010-11-02 0:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 22:12 [PATCH] ALSA: add support for disabling period irq Pierre-Louis Bossart
2010-11-01 22:41 ` Jaroslav Kysela
2010-11-02 0:16 ` pl bossart [this message]
2010-11-02 7:14 ` Jaroslav Kysela
2010-11-01 23:46 ` Raymond Yau
2010-11-02 7:34 ` Takashi Iwai
2010-11-02 8:17 ` Jaroslav Kysela
2010-11-02 8:22 ` Takashi Iwai
2010-11-02 8:26 ` Jaroslav Kysela
2010-11-02 8:41 ` Takashi Iwai
2010-11-02 9:02 ` Jaroslav Kysela
2010-11-02 9:14 ` Takashi Iwai
2010-11-02 9:22 ` Jaroslav Kysela
2010-11-02 9:26 ` Takashi Iwai
2010-11-08 20:52 ` pl bossart
2010-11-08 21:04 ` Jaroslav Kysela
2010-11-08 21:43 ` pl bossart
2010-11-02 12:57 ` pl bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTik_9eh2=TkCjTCOoxp5PMtdxpZ6qk7Eio8ABfmd@mail.gmail.com' \
--to=bossart.nospam@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).