alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Seungwhan Youn <claude.youn@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, lrg@slimlogic.co.uk,
	schen@mvista.com, Seungwhan Youn <sw.youn@samsung.com>
Subject: Re: [PATCH] ASoC: spdif: Add codec driver to use spdif stand-alone
Date: Tue, 1 Jun 2010 04:27:12 +0900	[thread overview]
Message-ID: <AANLkTil7HORYjETZrvF9foVm3zxYLRf9bm5Y9tkVFpSM@mail.gmail.com> (raw)
In-Reply-To: <20100531124228.GA14195@sirena.org.uk>

Hi, Mark,

2010/5/31 Mark Brown <broonie@opensource.wolfsonmicro.com>
>
> On Thu, May 27, 2010 at 06:13:48PM +0900, Seungwhan Youn wrote:
> > This patch adds spdif dummy codec driver for using spdif-dit as
> > a stand-alone. Until this, spdif-dit can be used only with other
> > codecs like tlv320aci3x in davinci platform.
> >
> > Signed-off-by: Seungwhan Youn <sw.youn@samsung.com>
>
> *sigh*
>
> sound/soc/codecs/spdif_transciever.c:67:29: warning: symbol 'soc_codec_dev_spdif_dit' was not declared. Should it be static?
> sound/soc/codecs/spdif_transciever.c:95:17: error: undefined identifier 'kzalloc'
> sound/soc/codecs/spdif_transciever.c:131:9: error: undefined identifier 'kfree'
> sound/soc/codecs/spdif_transciever.c:139:9: error: undefined identifier 'kfree'
>  CC [M]  sound/soc/codecs/spdif_transciever.o
> sound/soc/codecs/spdif_transciever.c: In function ‘spdif_dit_probe’:
> sound/soc/codecs/spdif_transciever.c:95: error: implicit declaration of function ‘kzalloc’
> sound/soc/codecs/spdif_transciever.c:95: warning: assignment makes pointer from integer without a cast
> sound/soc/codecs/spdif_transciever.c:131: error: implicit declaration of function ‘kfree’
>
> I've fixed these up.
>

I'm sorry for missing these. :(
Thank you.

> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>

BestRegards,
claude

      reply	other threads:[~2010-05-31 19:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-27  9:13 [PATCH] ASoC: spdif: Add codec driver to use spdif stand-alone Seungwhan Youn
2010-05-27 13:54 ` Liam Girdwood
2010-05-31 11:23 ` Mark Brown
2010-05-31 12:42 ` Mark Brown
2010-05-31 19:27   ` Seungwhan Youn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTil7HORYjETZrvF9foVm3zxYLRf9bm5Y9tkVFpSM@mail.gmail.com \
    --to=claude.youn@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@slimlogic.co.uk \
    --cc=schen@mvista.com \
    --cc=sw.youn@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).