* [PATCH] ALSA: hda: Use mbp31 quirk for an iMac model
@ 2010-05-30 14:02 Daniel Chen
2010-05-30 14:11 ` Daniel Chen
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Chen @ 2010-05-30 14:02 UTC (permalink / raw)
To: Takashi Iwai, stable; +Cc: alsa-devel
[-- Attachment #1: Type: text/plain, Size: 203 bytes --]
Hi,
Attached is a patch against sound-2.6 master enabling audible playback
and capture for the original reporter's iMac. Please apply.
This patch is applicable to all 2.6.3x stable series.
Best,
-Dan
[-- Attachment #2: 0001-ALSA-hda-Use-mbp31-quirk-for-an-iMac-model.patch --]
[-- Type: text/x-patch, Size: 1470 bytes --]
From 6e0261d5fb064829978976b639e94ecf1f96376d Mon Sep 17 00:00:00 2001
From: Daniel T Chen <crimsun@ubuntu.com>
Date: Sun, 30 May 2010 09:55:23 -0400
Subject: [PATCH] ALSA: hda: Use mbp31 quirk for an iMac model
BugLink: https://launchpad.net/bugs/542550
Symptom: On the reporter's iMac, in Ubuntu 10.04 LTS neither playback
nor capture appear audible out-of-the-box.
Test case: Boot from an Ubuntu 10.04 LTS live cd or from an installed
configuration and attempt to play or capture audio.
Resolution: Specify the mbp31 quirk for this machine in the codec SSID
table.
Reported-and-Tested-By: f3a97
Cc: <stable@kernel.org>
Signed-off-by: Daniel T Chen <crimsun@ubuntu.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 17d4548..d792cdd 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9476,6 +9476,7 @@ static struct snd_pci_quirk alc882_ssid_cfg_tbl[] = {
SND_PCI_QUIRK(0x106b, 0x1000, "iMac 24", ALC885_IMAC24),
SND_PCI_QUIRK(0x106b, 0x2800, "AppleTV", ALC885_IMAC24),
SND_PCI_QUIRK(0x106b, 0x2c00, "MacbookPro rev3", ALC885_MBP3),
+ SND_PCI_QUIRK(0x106b, 0x3000, "iMac", ALC889A_MB31),
SND_PCI_QUIRK(0x106b, 0x3600, "Macbook 3,1", ALC889A_MB31),
SND_PCI_QUIRK(0x106b, 0x3800, "MacbookPro 4,1", ALC885_MBP3),
SND_PCI_QUIRK(0x106b, 0x3e00, "iMac 24 Aluminum", ALC885_IMAC24),
--
1.7.0.4
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ALSA: hda: Use mbp31 quirk for an iMac model
2010-05-30 14:02 [PATCH] ALSA: hda: Use mbp31 quirk for an iMac model Daniel Chen
@ 2010-05-30 14:11 ` Daniel Chen
2010-05-31 7:26 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Chen @ 2010-05-30 14:11 UTC (permalink / raw)
To: Takashi Iwai, stable; +Cc: alsa-devel
[-- Attachment #1: Type: text/plain, Size: 489 bytes --]
On Sun, May 30, 2010 at 10:02 AM, Daniel Chen <seven.steps@gmail.com> wrote:
> Attached is a patch against sound-2.6 master enabling audible playback
> and capture for the original reporter's iMac. Please apply.
Oops, I just noticed that the description is imprecise. Please use
this patch instead, which correctly lists the model quirk used in the
description as mb31 (not mbp31). While the driver change is not
affected, I'd like the description to match the actual change.
Best,
-Dan
[-- Attachment #2: 0001-ALSA-hda-Use-mb31-quirk-for-an-iMac-model.patch --]
[-- Type: text/x-patch, Size: 1468 bytes --]
From f6ebd06e8fef41adb94a6deb6d0284d0261cac65 Mon Sep 17 00:00:00 2001
From: Daniel T Chen <crimsun@ubuntu.com>
Date: Sun, 30 May 2010 09:55:23 -0400
Subject: [PATCH] ALSA: hda: Use mb31 quirk for an iMac model
BugLink: https://launchpad.net/bugs/542550
Symptom: On the reporter's iMac, in Ubuntu 10.04 LTS neither playback
nor capture appear audible out-of-the-box.
Test case: Boot from an Ubuntu 10.04 LTS live cd or from an installed
configuration and attempt to play or capture audio.
Resolution: Specify the mb31 quirk for this machine in the codec SSID
table.
Reported-and-Tested-By: f3a97
Cc: <stable@kernel.org>
Signed-off-by: Daniel T Chen <crimsun@ubuntu.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 17d4548..d792cdd 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9476,6 +9476,7 @@ static struct snd_pci_quirk alc882_ssid_cfg_tbl[] = {
SND_PCI_QUIRK(0x106b, 0x1000, "iMac 24", ALC885_IMAC24),
SND_PCI_QUIRK(0x106b, 0x2800, "AppleTV", ALC885_IMAC24),
SND_PCI_QUIRK(0x106b, 0x2c00, "MacbookPro rev3", ALC885_MBP3),
+ SND_PCI_QUIRK(0x106b, 0x3000, "iMac", ALC889A_MB31),
SND_PCI_QUIRK(0x106b, 0x3600, "Macbook 3,1", ALC889A_MB31),
SND_PCI_QUIRK(0x106b, 0x3800, "MacbookPro 4,1", ALC885_MBP3),
SND_PCI_QUIRK(0x106b, 0x3e00, "iMac 24 Aluminum", ALC885_IMAC24),
--
1.7.0.4
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ALSA: hda: Use mbp31 quirk for an iMac model
2010-05-30 14:11 ` Daniel Chen
@ 2010-05-31 7:26 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2010-05-31 7:26 UTC (permalink / raw)
To: Daniel Chen; +Cc: alsa-devel, stable
At Sun, 30 May 2010 10:11:50 -0400,
Daniel Chen wrote:
>
> On Sun, May 30, 2010 at 10:02 AM, Daniel Chen <seven.steps@gmail.com> wrote:
> > Attached is a patch against sound-2.6 master enabling audible playback
> > and capture for the original reporter's iMac. Please apply.
>
> Oops, I just noticed that the description is imprecise. Please use
> this patch instead, which correctly lists the model quirk used in the
> description as mb31 (not mbp31). While the driver change is not
> affected, I'd like the description to match the actual change.
OK, applied this fixed one. Thanks.
Takashi
>
> Best,
> -Dan
> [2 0001-ALSA-hda-Use-mb31-quirk-for-an-iMac-model.patch <text/x-patch; US-ASCII (base64)>]
> From f6ebd06e8fef41adb94a6deb6d0284d0261cac65 Mon Sep 17 00:00:00 2001
> From: Daniel T Chen <crimsun@ubuntu.com>
> Date: Sun, 30 May 2010 09:55:23 -0400
> Subject: [PATCH] ALSA: hda: Use mb31 quirk for an iMac model
>
> BugLink: https://launchpad.net/bugs/542550
>
> Symptom: On the reporter's iMac, in Ubuntu 10.04 LTS neither playback
> nor capture appear audible out-of-the-box.
>
> Test case: Boot from an Ubuntu 10.04 LTS live cd or from an installed
> configuration and attempt to play or capture audio.
>
> Resolution: Specify the mb31 quirk for this machine in the codec SSID
> table.
>
> Reported-and-Tested-By: f3a97
> Cc: <stable@kernel.org>
> Signed-off-by: Daniel T Chen <crimsun@ubuntu.com>
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 17d4548..d792cdd 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9476,6 +9476,7 @@ static struct snd_pci_quirk alc882_ssid_cfg_tbl[] = {
> SND_PCI_QUIRK(0x106b, 0x1000, "iMac 24", ALC885_IMAC24),
> SND_PCI_QUIRK(0x106b, 0x2800, "AppleTV", ALC885_IMAC24),
> SND_PCI_QUIRK(0x106b, 0x2c00, "MacbookPro rev3", ALC885_MBP3),
> + SND_PCI_QUIRK(0x106b, 0x3000, "iMac", ALC889A_MB31),
> SND_PCI_QUIRK(0x106b, 0x3600, "Macbook 3,1", ALC889A_MB31),
> SND_PCI_QUIRK(0x106b, 0x3800, "MacbookPro 4,1", ALC885_MBP3),
> SND_PCI_QUIRK(0x106b, 0x3e00, "iMac 24 Aluminum", ALC885_IMAC24),
> --
> 1.7.0.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-05-31 7:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-30 14:02 [PATCH] ALSA: hda: Use mbp31 quirk for an iMac model Daniel Chen
2010-05-30 14:11 ` Daniel Chen
2010-05-31 7:26 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).