Re: [PATCH v6 9/9] davinci: USB1.1 support for Omapl138-Hawkboard

[Victor Rodriguez <vm.rod25@gmail.com>]

On Tue, Nov 2, 2010 at 12:20 PM, Nori, Sekhar <nsekhar@ti.com> wrote:
> Hi Victor,
>
> On Fri, Oct 29, 2010 at 20:40:45, vm.rod25@gmail.com wrote:
>> From: Victor Rodriguez <victor.rodriguez@sasken.com>
>>
>> This patch adds USB1.1 support for the Hawkboard-L138 system
>>
>> Signed-off-by: Victor Rodriguez <victor.rodriguez@sasken.com>
>> ---
>
>> +static int hawk_usb_ocic_notify(da8xx_ocic_handler_t handler)
>> +{
>> +     int irq         = gpio_to_irq(DA850_USB1_OC_PIN);
>> +     int error       = 0;
>> +
>> +     if (handler != NULL) {
>> +             hawk_usb_ocic_handler = handler;
>> +
>> +             error = request_irq(irq, omapl138_hawk_usb_ocic_irq,
>> +                                     IRQF_DISABLED | IRQF_TRIGGER_RISING |
>> +                                     IRQF_TRIGGER_FALLING,
>> +                                     "OHCI over-current indicator", NULL);
>> +             if (error)
>> +                     pr_err(KERN_ERR "%s: could not request IRQ to watch "
>> +                             "over-current indicator changes\n", __func__);
>> +     } else
>> +             free_irq(irq, NULL);
>
> Per Documentation/CodingStyle, else should have braces too.

Ok thanks

>> +static struct da8xx_ohci_root_hub omapl138_hawk_usb11_pdata = {
>> +     .set_power      = hawk_usb_set_power,
>> +     .get_power      = hawk_usb_get_power,
>> +     .get_oci        = hawk_usb_get_oci,
>> +     .ocic_notify    = hawk_usb_ocic_notify,
>> +     /* TPS2087 switch @ 5V */
>
> Do we have this part on the hawkboard as well?

Yes the  TPS2087 is the   USB POWER MANAGER that we have on the board
AFAIK this is the same and besides it is working, I have tested by my
self by plugging different kind of USB devices, mas storage , Mouses
and keyboards.


> [...]
>
>> +static __init void omapl138_hawk_usb_init(void)
>> +{
>> +     int ret;
>> +     u32 cfgchip2;
>> +
>> +     ret = davinci_cfg_reg_list(da850_hawk_usb11_pins);
>> +     if (ret) {
>> +             pr_warning("%s: USB 1.1 PinMux setup failed: %d\n",
>> +                     __func__, ret);
>> +             return;
>> +     }
>> +
>> +     /*
>> +      * Setup the Ref. clock frequency for the HAWK at 24 MHz.
>> +      */
>
> No need of multi-line comment style here.


Ok changed to

	/* Setup the Ref. clock frequency for the HAWK at 24 MHz. */

> Sorry about the piecemeal review (you really generated new versions quickly).

Sorry about it I will take much more time for comments.

> That is all I have on this series.
>
> Also, you are CCing a whole lot of folks on each patch. Instead, you can
> automate CCing the relevant folks using --cc-cmd=<command> option  of
> git-send-email
>
> Use --cc-cmd="scripts/get_maintainer.pl --pattern-depth=2 -s" to generate
> list of relevant CCs.
>
> Example:
>
> scripts/get_maintainer.pl -f arch/arm/mach-davinci/board-omapl138-hawk.c --pattern-depth=2 -s
>
> gives:
>
> Kevin Hilman <khilman@deeprootsystems.com>
> Russell King <linux@arm.linux.org.uk>
> davinci-linux-open-source@linux.davincidsp.com
> linux-arm-kernel@lists.infradead.org
>
> Recently Kevin requested all patches to CC Linux ARM Kernel mailing list so this
> should be OK.
>
> scripts/get_maintainer.pl -f sound/soc/davinci/davinci-evm.c --pattern-depth=2 -s
>
> gives:
>
> Liam Girdwood <lrg@slimlogic.co.uk>
> Mark Brown <broonie@opensource.wolfsonmicro.com>
> alsa-devel@alsa-project.org
>
> This is as per what Liam and Mark have been asking for.
>
> Also, use --dry-run with git-send-email before sending actual emails to make
> sure the To and CC lists look good.

Ok I have done this

git send-email --dry-run --from "<vm.rod25@gmail.com>" --to
"<vm.rod25@gmail.com>" --cc-cmd =scripts/get_maintainer.pl
patches/sendedv6/*

I just have one question on the --to i think I should put the davinci
mailing list as minimum right ? because the cover letter just will be
send to me

From: <vm.rod25@gmail.com>
To: <vm.rod25@gmail.com>
Cc: Victor Rodriguez <victor.rodriguez@sasken.com>
Subject: [PATCH v6 0/9] Add Omapl138-Hawkboard support
Date: Tue,  2 Nov 2010 17:48:03 -0600
Message-Id: <1288741692-20096-1-git-send-email-vm.rod25@gmail.com>
X-Mailer: git-send-email 1.7.0.4

Thanks for the help

Sincerely yours

Victor Rodriguez


> Thanks,
> Sekhar
>
>