From: Eric Miao <eric.y.miao@gmail.com>
To: Wan ZongShun <mcuos.com@gmail.com>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/2] pxa: modify the pxa2xx-ac97 file for pxa168
Date: Tue, 8 Jun 2010 19:23:34 +0800 [thread overview]
Message-ID: <AANLkTimNwtScfKYVc4qPZFEP6GYklPoHLgr2AE7yquQL@mail.gmail.com> (raw)
In-Reply-To: <4C0E21A1.4000909@gmail.com>
2010/6/8 Wan ZongShun <mcuos.com@gmail.com>:
> In order to allow the sharing of the pxa2xx-ac97 driver file with pxa168,
> we have to do a little change to pxa2xx-ac97 file.
>
> All private register addresses were located in mach/include/ac97.h.
This is not the right way to go, as suggested already. I hope the ac97
driver is more self-contained. i.e. having a platform device for:
- where the registers are mapped from
- drcmr channel numbers can be encoded within dma resource
- ac97 register definitions are not exposed everywhere
next prev parent reply other threads:[~2010-06-08 11:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 10:55 [PATCH 2/2] pxa: modify the pxa2xx-ac97 file for pxa168 Wan ZongShun
2010-06-08 11:23 ` Eric Miao [this message]
2010-06-08 14:49 ` Wan ZongShun
2010-06-08 15:01 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimNwtScfKYVc4qPZFEP6GYklPoHLgr2AE7yquQL@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lrg@slimlogic.co.uk \
--cc=mcuos.com@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox