Re: [PATCH] ASoC: SAMSUNG: Add Aquila sound driver

From: Jassi Brar <jassisinghbrar@gmail.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Joonyoung Shim <jy0922.shim@samsung.com>
Subject: Re: [PATCH] ASoC: SAMSUNG: Add Aquila sound driver
Date: Thu, 8 Jul 2010 17:19:15 +0900	[thread overview]
Message-ID: <AANLkTinKT2LvSrfcI2-aw2iXnnCe1R_jCfq09rxlNa3x@mail.gmail.com> (raw)
In-Reply-To: <4C358807.1000502@samsung.com>

On Thu, Jul 8, 2010 at 5:10 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> Jassi Brar wrote:
>> On Thu, Jul 8, 2010 at 1:57 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>>> This patch add sound support for the Aquila board based on S5PC110.
>>>
>>> The Aquila board is based on Samsung SoC(S5PC110) and include
>>> WM8994 codec over I2Sv5 to support sound. As there is currently
>>> no driver for the I2Sv5, the code to use I2Sv5 is deleted
>>> on this patch.
>>>
>>> After I2Sv5 driver is posted in a few weeks, I will post incremental
>>> patch which some codes for using I2Sv5. The owner of I2Sv5 said that
>>> he will post I2Sv5 driver after a few weeks.
>>
>> I don't plan to create a copy of an almost copy of s3c64xx-i2s.c
>> Please try to use the existing sound/soc/s3c24xx/s3c64xx-i2s-v4.c
>> I intend to only enhance that code to enable features of 'v4', 'v5' etc.
>>
>
> As your comment, I did modify some codes to use sound/soc/s3c24xx/
> s3c64xx-i2s-v4.c instead of I2Sv5. When I try to compile kernel
> with arch/arm/configs/s5pv210_defconfig.
>

.....

>
> When compiling kernel, it is occurred below error because
> arch/arm/mach-s5pv210/include/mach/gpio-bank-*.h file
> isn't included to upstream kernel.
>
> sound/soc/s3c34xx/s3c64xx-i2s-v4.c included the header files
> in arch/arm/mach-s3c64xx/include/*.
>
> What is your opinion for this error?
>
> - compile error log :
> CHK     include/generated/compile.h
> CC      sound/soc/s3c24xx/s3c64xx-i2s-v4.o
> sound/soc/s3c24xx/s3c64xx-i2s-v4.c:19: fatal error:mach/gpio-bank-c.h:
>  No such file or directory

The gpio config stuff needs to be removed from the CPU driver. It was pending
due to fear of cross-tree merge issues. The platform specific code to do the
same is already upstream now.
One engineer in my team is already looking into it while testing
Liam's multi-codec
changes.

>> Please try to use the existing sound/soc/s3c24xx/s3c64xx-i2s-v4.c
'try to' is the key word here. The driver is not expected to work rightaway.
One might need to make some changes to the CPU driver to just make it
work on platforms with very similar IP.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel