From: Timur Tabi <timur@freescale.com>
To: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [RFC 02/16] ASoC: multi-component - cs4720, cs42l51 and da7210 CODECs
Date: Fri, 25 Jun 2010 13:29:00 -0500 [thread overview]
Message-ID: <AANLkTinmu4myhe1dGuG_fEdQUpYKQ4bbN1xDCSWzmNWC@mail.gmail.com> (raw)
In-Reply-To: <1277488383-31287-3-git-send-email-lrg@slimlogic.co.uk>
On Fri, Jun 25, 2010 at 12:52 PM, Liam Girdwood <lrg@slimlogic.co.uk> wrote:
> /* Private data for the CS4270 */
> struct cs4270_private {
> - struct snd_soc_codec codec;
> + enum snd_soc_control_type control_type;
> + void *control_data;
Because of this change, there is a comment later in the file that is
no longer valid:
/* Allocate enough space for the snd_soc_codec structure
and our private data together. */
cs4270 = kzalloc(sizeof(struct cs4270_private), GFP_KERNEL);
if (!cs4270) {
dev_err(&i2c_client->dev, "could not allocate codec\n");
return -ENOMEM;
}
Other than that ...
CS4270 portions:
Acked-by: Timur Tabi <timur@freescale.com>
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2010-06-25 18:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 17:52 [RFC 00/16] ASoC: multi-component - CODECs Liam Girdwood
2010-06-25 17:52 ` [RFC 01/16] ASoC: multi-component - AKM CODECs Liam Girdwood
2010-06-25 17:58 ` Liam Girdwood
2010-06-25 17:52 ` [RFC 02/16] ASoC: multi-component - cs4720, cs42l51 and da7210 CODECs Liam Girdwood
2010-06-25 18:29 ` Timur Tabi [this message]
2010-06-26 17:36 ` Liam Girdwood
2010-06-25 17:52 ` [RFC 03/16] ASoC: multi-component - pcm3008, ssm2602, jz4740 and uda1380 Liam Girdwood
2010-06-25 17:52 ` [RFC 04/16] ASoC: multi-component - TI CODECs Liam Girdwood
2010-06-30 12:08 ` peter.ujfalusi
2010-06-30 12:53 ` Mark Brown
2010-07-01 19:02 ` Mark Brown
2010-07-05 21:15 ` Liam Girdwood
2010-06-30 19:39 ` Bedia, Vaibhav
2010-06-25 17:52 ` [RFC 05/16] ASoC: multi-component - open firmware Liam Girdwood
2010-06-25 17:52 ` [RFC 06/16] ASoC: multi-component - Generic AC97 and SPDIF CODECs Liam Girdwood
2010-06-25 17:52 ` [RFC 07/16] ASoC: multi-component - cq93vc, cx20442, stac9766 and UDA134x CODECs Liam Girdwood
2010-06-25 17:52 ` [RFC 08/16] ASoC: multi-component - Wolfson WM85xx CODECs Liam Girdwood
2010-06-25 17:52 ` [RFC 09/16] ASoC: multi-component - Wolfson WM87xx CODECs Liam Girdwood
2010-06-25 17:52 ` [RFC 10/16] ASoC: multi-component - Wolfson wm8900, 8903, 8904 and 8955 CODECs Liam Girdwood
2010-06-25 17:52 ` [RFC 11/16] ASoC: multi-component - Wolfson wm8960, 8961 and 8940 CODECs Liam Girdwood
2010-06-25 17:52 ` [RFC 12/16] ASoC: multi-component - Wolfson WM8971, 8993, 8990 and 8974 CODECs Liam Girdwood
2010-06-25 17:53 ` [RFC 13/16] ASoC: multi-component - Wolfson WM8978, 8988 and 8994 CODECs Liam Girdwood
2010-06-25 17:53 ` [RFC 14/16] ASoC: multi-component - Wolfson WM90xx CODECs Liam Girdwood
2010-06-25 17:53 ` [RFC 15/16] ASoC: multi-component - Wolfson AudioPlus CODECs Liam Girdwood
2010-06-25 17:53 ` [RFC 16/16] ASoC: multi-component - Wolfson WM97xx AC97 CODECs Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinmu4myhe1dGuG_fEdQUpYKQ4bbN1xDCSWzmNWC@mail.gmail.com \
--to=timur@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).