From: Mike Frysinger <vapier@gentoo.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: device-driver-devel@blackfin.uclinux.org,
uclinux-dist-devel@blackfin.uclinux.org,
alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [uclinux-dist-devel] [PATCH 1/4] Blackfin: Use 8bit spi transfers for the ad1836
Date: Thu, 5 May 2011 18:56:38 -0400 [thread overview]
Message-ID: <BANLkTi=u+_LBkv2=DAwhZ53FEoRaYcHErA@mail.gmail.com> (raw)
In-Reply-To: <1304617966-4410-1-git-send-email-lars@metafoo.de>
On Thu, May 5, 2011 at 13:52, Lars-Peter Clausen wrote:
> Currently there is a special case for the ad1836 in the ASoC generic spi write
> functions, which swaps the upper and the lower byte for 4/12 transfers.
> This was done, because the 4/12 spi write function was added for the ad1836
> for which all of the users are configured to use use 16-bit transfers.
> In order to be able to get rid of this special casing switch all users of
> ad1836 to 8-bit transfers.
16bit spi transfers are inherently less overhead than 8bit transfers.
so if the codec supports it, we should use it rather than drop 16bit
support everywhere because 8bit is simpler. am i missing something
obvious ?
-mike
next prev parent reply other threads:[~2011-05-05 22:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 17:52 [PATCH 1/4] Blackfin: Use 8bit spi transfers for the ad1836 Lars-Peter Clausen
2011-05-05 17:52 ` [PATCH 2/4] ASoC: Do not swap upper and lower byte in snd_soc_4_12_spi_write Lars-Peter Clausen
2011-05-05 17:52 ` [PATCH 3/4] ASoC: Get rid of snd_soc_*_*_spi_write wrapper functions Lars-Peter Clausen
2011-05-12 12:25 ` Barry Song
2011-05-05 17:52 ` [PATCH 4/4] ASoC: Use spi_write in do_spi_write Lars-Peter Clausen
2011-05-05 22:56 ` Mike Frysinger [this message]
2011-05-06 12:28 ` [uclinux-dist-devel] [PATCH 1/4] Blackfin: Use 8bit spi transfers for the ad1836 Lars-Peter Clausen
2011-05-06 12:48 ` Mark Brown
2011-05-06 13:12 ` [Device-drivers-devel] " Mike Frysinger
2011-05-06 13:19 ` Lars-Peter Clausen
2011-05-06 13:26 ` Mark Brown
2011-05-06 13:31 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=u+_LBkv2=DAwhZ53FEoRaYcHErA@mail.gmail.com' \
--to=vapier@gentoo.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=device-driver-devel@blackfin.uclinux.org \
--cc=lars@metafoo.de \
--cc=lrg@slimlogic.co.uk \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).