alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Grant Diffey <gdiffey@gmail.com>
To: Daniel Mack <zonque@gmail.com>
Cc: "Frédéric Jaume" <frederic.jaume@gmail.com>,
	alsa-devel@alsa-project.org,
	"Clemens Ladisch" <clemens@ladisch.de>,
	"Felix Homann" <linuxaudio@showlabor.de>
Subject: Re: Alsa Support for Korg Pandora Mini, Vox ToneLab ST
Date: Tue, 17 May 2011 01:20:59 +1000	[thread overview]
Message-ID: <BANLkTimUPRYXcpY9fhcyOACJG+NaurOZxA@mail.gmail.com> (raw)
In-Reply-To: <BANLkTikjU3KiL9HJJSwjHQ8qO-eLG3HWzQ@mail.gmail.com>

2011/5/16 Daniel Mack <zonque@gmail.com>

> 2011/5/15 Daniel Mack <zonque@gmail.com>:
> > 2011/5/14 Frédéric Jaume <frederic.jaume@gmail.com>:
> >> Hi!
> >>
> >> Here's the "lsusb -v" for the Korg Pandora PX5D, attached. Hope this
> helps.
> >
> > The MIDI part of the descriptors is clearly marked as vendor specific,
> > so there is nothing the driver can do about this, except for adding a
> > quirk.
> >
> > Assuming the MIDI interface is class compliant, the following patch
> > should help. Can you give it a try?
>
> For the Pandora PX5D, we also have to use the USB_DEVICE_VENDOR_SPEC
> macro, so the class compliant audio interfaces are not ignored by
> adding the quirk.
>
> Daniel
>

A winner.

[  115.420064] usb 4-1: new high speed USB device using ehci_hcd and address
3
[  115.553783] usb 4-1: config 1 interface 3 altsetting 0 bulk endpoint 0x7
has invalid maxpacket 8
[  115.553789] usb 4-1: config 1 interface 3 altsetting 0 bulk endpoint 0x87
has invalid maxpacket 8
[  115.554896] usb 4-1: New USB device found, idVendor=0763, idProduct=2080
[  115.554898] usb 4-1: New USB device strings: Mfr=1, Product=2,
SerialNumber=0
[  115.554901] usb 4-1: Product: Fast Track Ultra
[  115.554903] usb 4-1: Manufacturer: M-Audio
nevyn@cetacea:~/linux$ amidi -l
Dir Device    Name
IO  hw:1,0,0  Fast Track Ultra MIDI 1

Huzzah! Please commit. your 8 character diff ;) oh. and you probably should
change the 8R at the same time given it's essentially the same hardware with
different analog bits. (8 pre's instead of 4)

diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
index 196c753..6d7b357 100644
--- a/sound/usb/quirks-table.h
+++ b/sound/usb/quirks-table.h
@@ -1926,7 +1926,7 @@ YAMAHA_DEVICE(0x7010, "UB99"),
        }
 },
 {
-       USB_DEVICE(0x0763, 0x2080),
+       USB_DEVICE_VENDOR_SPEC(0x0763, 0x2080),
        .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk)
{
                /* .vendor_name = "M-Audio", */
                /* .product_name = "Fast Track Ultra", */
@@ -1993,7 +1993,7 @@ YAMAHA_DEVICE(0x7010, "UB99"),
        }
 },
 {
-       USB_DEVICE(0x0763, 0x2081),
+       USB_DEVICE_VENDOR_SPEC(0x0763, 0x2081),
        .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk)
{
                /* .vendor_name = "M-Audio", */
                /* .product_name = "Fast Track Ultra 8R", */



Grant

  parent reply	other threads:[~2011-05-16 15:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-19  7:39 Alsa Support for Korg Pandora Mini, Vox ToneLab ST Pawel Siemienski
2011-04-23  8:52 ` Daniel Mack
2011-05-12 16:01 ` Daniel Mack
2011-05-13  9:25   ` Pawel Siemienski
2011-05-13 12:13     ` Daniel Mack
2011-05-14 16:57   ` Frédéric Jaume
2011-05-14 17:13     ` Grant Diffey
2011-05-14 17:24       ` Daniel Mack
2011-05-14 18:16         ` Daniel Mack
2011-05-14 20:34           ` Frédéric Jaume
2011-05-15 13:12             ` Daniel Mack
2011-05-16  6:56               ` Daniel Mack
2011-05-16 12:57                 ` Felix Homann
2011-05-16 15:20                 ` Grant Diffey [this message]
2011-05-16 15:25                   ` Daniel Mack
2011-05-16 18:39                     ` Frédéric Jaume
2011-05-15 17:54           ` Grant Diffey
2011-05-15 20:43             ` Daniel Mack
2011-05-15 21:30               ` Daniel Mack
2011-05-16  2:55                 ` Grant Diffey
2011-05-16  6:48                   ` Daniel Mack
2011-05-17 13:44                     ` Felix Homann
2011-05-15 23:22               ` Grant Diffey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTimUPRYXcpY9fhcyOACJG+NaurOZxA@mail.gmail.com \
    --to=gdiffey@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=frederic.jaume@gmail.com \
    --cc=linuxaudio@showlabor.de \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).