From: Mike Frysinger <vapier@gentoo.org>
To: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: uclinux-dist-devel@blackfin.uclinux.org,
Barry Song <barry.song@analog.com>,
Scott Jiang <scott.jiang@analog.com>
Subject: Re: [uclinux-dist-devel] [PATCH 3/3] ASoC: Blackfin: push down SPORT settings from global variables
Date: Thu, 7 Apr 2011 14:55:48 -0400 [thread overview]
Message-ID: <BANLkTin1d9ZT86fCzKqCgF21Zaabs+oUhg@mail.gmail.com> (raw)
In-Reply-To: <1301291110-2443-3-git-send-email-vapier@gentoo.org>
On Mon, Mar 28, 2011 at 01:45, Mike Frysinger wrote:
> + struct bfin_snd_platform_data *pdata = dev->platform_data;
hrm, i noticed that this struct is fairly generic and could be reused
in other SPORT drivers, but i'd want to replace the "_snd_" in the
struct name with "_sport_". i think you've already merged this patch
and so you dont want to go squashing any changes into it ? so i
should send a small follow up patch to change the name ?
-mike
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2011-04-07 18:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 5:45 [PATCH 1/3] ASoC: Blackfin: drop "-codec" from codec names Mike Frysinger
2011-03-28 5:45 ` [PATCH 2/3] ASoC: Blackfin: standardize machine driver names Mike Frysinger
2011-03-28 5:45 ` [PATCH 3/3] ASoC: Blackfin: push down SPORT settings from global variables Mike Frysinger
2011-04-07 18:55 ` Mike Frysinger [this message]
2011-04-07 23:25 ` [uclinux-dist-devel] " Mark Brown
2011-03-28 19:25 ` [uclinux-dist-devel] [PATCH 1/3] ASoC: Blackfin: drop "-codec" from codec names Mike Frysinger
2011-03-29 20:30 ` Liam Girdwood
2011-03-29 22:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTin1d9ZT86fCzKqCgF21Zaabs+oUhg@mail.gmail.com \
--to=vapier@gentoo.org \
--cc=alsa-devel@alsa-project.org \
--cc=barry.song@analog.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=scott.jiang@analog.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).