alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Raymond Yau <superquad.vortex2@gmail.com>
To: Maarten Lankhorst <m.b.lankhorst@gmail.com>,
	ALSA Development Mailing List <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] Alsa-plugins: Pulse: Fix snd_pcm_avail returning 0 in some cases
Date: Wed, 27 Apr 2011 09:00:56 +0800	[thread overview]
Message-ID: <BANLkTinXTK541r+2ae-iadn7jTzD2O4QOQ@mail.gmail.com> (raw)
In-Reply-To: <4DB67BD3.7090706@canonical.com>

2011/4/26 David Henningsson <david.henningsson@canonical.com>

> On 2011-04-22 01:25, Raymond Yau wrote:
>
>> 2011/4/21 David Henningsson<david.henningsson@canonical.com>
>>
>>  Due to a round-off error, snd_pcm_avail could in some cases
>>> return 0 even though more data could be written to the stream.
>>>
>>> This was discovered by Maarten Lankhorst [1], and there is also a test
>>> program available that triggers this error [2].
>>>
>>> [1]
>>>
>>> https://tango.0pointer.de/pipermail/pulseaudio-discuss/2011-April/009935.html
>>>
>>> [2]
>>>
>>> https://tango.0pointer.de/pipermail/pulseaudio-discuss/attachments/20110420/3c852d6e/attachment.c
>>>
>>>
>> if the test program can force under-run occur with "hw" device and "pulse"
>> device with his patch in
>>
>> https://tango.0pointer.de/pipermail/pulseaudio-discuss/2011-April/009918.html
>>
>> Is it normal that underrun does not occur with the test program and your
>> patch
>>
>
> Yes; underruns are not reported to the application due to the risk of the
> underrun being obsolete at that time. As for Maarten's patch in the post you
> refer to,
>
> 1) if underruns are being reported (this is configurable), it might be a
> good idea to call "pulse_start".
>
> 2) it changes underruns to being reported by default, which is what I'm
> opposed to.
>
> >>> However if I force underruns to occur, the state will stay running and
it appears
>>> there is still some data left in the buffer, so sound stalls entirely.
The latency gets >>> updated to something like 0x7bdXXXXXXXXXXXXX which
looks suspiciously
>>> much like a pointer to me, which may be a bug.
>>> So my questions are.
>>> 1. Is the weird latency value update a bug? Digging it up I can only
assume it's a
>>> bug in src/stream.c , but I haven't figured out why yet.  Tested with
pulseaudio.c
>>> 2. Any comments on this patch for alsa-plugins?

There are some difference between devices "hw" , "plug:dmix" and "pulse"
when I run "aplay -v --test-position any.wav" with different period size and
buffer size

It seem that the delay of  device "pulse" is much larger than those of
"dmix" and "hw"

  parent reply	other threads:[~2011-04-27  1:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-21 13:22 [PATCH] Alsa-plugins: Pulse: Fix snd_pcm_avail returning 0 in some cases David Henningsson
2011-04-21 23:25 ` Raymond Yau
2011-04-26  8:01   ` David Henningsson
2011-04-26 14:39     ` Takashi Iwai
2011-05-07  3:18       ` Raymond Yau
2011-04-27  1:00     ` Raymond Yau [this message]
2011-04-29  2:32     ` Raymond Yau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTinXTK541r+2ae-iadn7jTzD2O4QOQ@mail.gmail.com \
    --to=superquad.vortex2@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=m.b.lankhorst@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).