From: Linus Torvalds <torvalds@linux-foundation.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: alsa-devel@alsa-project.org, htejun@gmail.com, mszeredi@suse.cz,
gmane@colin.guthr.ie, linux-kernel@vger.kernel.org,
smcnam@gmail.com, jamescaldwell1@gmail.com,
linux-fsdevel@vger.kernel.org, s.maddox@lantizia.me.uk,
david.henningsson@canonical.com
Subject: Re: [PATCH 2/2] cuse: implement memory mapping
Date: Fri, 13 Jan 2012 10:19:50 -0800 [thread overview]
Message-ID: <CA+55aFy7xLkMThg8+G=e7v7x7WaHSkLWGRiRF8hCq4WEUHxymw@mail.gmail.com> (raw)
In-Reply-To: <1326474399-27278-3-git-send-email-miklos@szeredi.hu>
On Fri, Jan 13, 2012 at 9:06 AM, Miklos Szeredi <miklos@szeredi.hu> wrote:
> From: Tejun Heo <htejun@gmail.com>
>
> This implements memory mapping of char devices.
I don't think this is how you want to do it.
It seems to maintain a page list of its own, and do the magic page
fault etc behavior. Which to me smells like a really bad design.
I would expect that what you actually want to do is to expose it as a
shared mmap, and depend on all the normal shmem support. Is there any
reason not to do that?
I guess you don't generally have big mappings, so an argument like
"that way you can page out pages etc" may not strike you as a very
strong argument, but I'd still prefer to at least see that approach
explored. Hmm?
Linus
next prev parent reply other threads:[~2012-01-13 18:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 17:06 [PATCH 0/2] cuse: implement mmap/munmap Miklos Szeredi
2012-01-13 17:06 ` [PATCH 1/2] fuse: create fuse_conn_operations Miklos Szeredi
2012-01-13 17:06 ` [PATCH 2/2] cuse: implement memory mapping Miklos Szeredi
2012-01-13 18:19 ` Linus Torvalds [this message]
2012-01-13 18:49 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFy7xLkMThg8+G=e7v7x7WaHSkLWGRiRF8hCq4WEUHxymw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=david.henningsson@canonical.com \
--cc=gmane@colin.guthr.ie \
--cc=htejun@gmail.com \
--cc=jamescaldwell1@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mszeredi@suse.cz \
--cc=s.maddox@lantizia.me.uk \
--cc=smcnam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).