From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Alexandre Torgue <alexandre.torgue@st.com>,
Arnaud Pouliquen <arnaud.pouliquen@st.com>,
alsa-devel@alsa-project.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Benjamin Gaignard <benjamin.gaignard@st.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sound: stm32: replace "%p" with "%pK"
Date: Sat, 7 Jul 2018 13:29:18 +0200 [thread overview]
Message-ID: <CA+M3ks7QL6t+HLHAiW3T8hDFDNyR494y4dM20jc8YXJ7-Xbd_g@mail.gmail.com> (raw)
In-Reply-To: <s5hpo00quk4.wl-tiwai@suse.de>
2018-07-06 16:59 GMT+02:00 Takashi Iwai <tiwai@suse.de>:
> On Fri, 06 Jul 2018 15:07:03 +0200,
> Benjamin Gaignard wrote:
>>
>> The format specifier "%p" can leak kernel addresses.
>> Use "%pK" instead.
>>
>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
>
> The code change itself is OK (apart from the subject prefix to be
> "ASoC"). But do we really want to patch manually every single place
> like this? There are thousands of files using '%p'.
I have limited myself to the few remaining %p in STM32 architecture.
>
>
> thanks,
>
> Takashi
next prev parent reply other threads:[~2018-07-07 11:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 13:07 [PATCH] sound: stm32: replace "%p" with "%pK" Benjamin Gaignard
2018-07-06 14:59 ` Takashi Iwai
2018-07-07 11:29 ` Benjamin Gaignard [this message]
2018-07-09 11:16 ` Applied "ASoC: stm32: replace "%p" with "%pK"" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+M3ks7QL6t+HLHAiW3T8hDFDNyR494y4dM20jc8YXJ7-Xbd_g@mail.gmail.com \
--to=benjamin.gaignard@linaro.org \
--cc=alexandre.torgue@st.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.pouliquen@st.com \
--cc=benjamin.gaignard@st.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).