* [PATCH] ALSA: hda - Enable subwoofer on Dell Inspiron 7559
@ 2016-08-30 5:27 Kai-Heng Feng
2016-08-30 5:33 ` Takashi Iwai
0 siblings, 1 reply; 5+ messages in thread
From: Kai-Heng Feng @ 2016-08-30 5:27 UTC (permalink / raw)
To: tiwai; +Cc: hui.wang, alsa-devel, linux-kernel, Kai-Heng Feng
The subwoofer on Inspiron 7559 does not work originally.
Applying a pin fixup can make it work.
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
sound/pci/hda/patch_realtek.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 7100f05..2a3dd18 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -4855,6 +4855,7 @@ enum {
ALC221_FIXUP_HP_FRONT_MIC,
ALC292_FIXUP_TPT460,
ALC298_FIXUP_SPK_VOLUME,
+ ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER,
};
static const struct hda_fixup alc269_fixups[] = {
@@ -5516,6 +5517,15 @@ static const struct hda_fixup alc269_fixups[] = {
.chained = true,
.chain_id = ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
},
+ [ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER] = {
+ .type = HDA_FIXUP_PINS,
+ .v.pins = (const struct hda_pintbl[]) {
+ { 0x1b, 0x90170151 },
+ { }
+ },
+ .chained = true,
+ .chain_id = ALC255_FIXUP_DELL1_MIC_NO_PRESENCE
+ },
};
static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -5560,6 +5570,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1028, 0x06df, "Dell", ALC293_FIXUP_DISABLE_AAMIX_MULTIJACK),
SND_PCI_QUIRK(0x1028, 0x06e0, "Dell", ALC293_FIXUP_DISABLE_AAMIX_MULTIJACK),
SND_PCI_QUIRK(0x1028, 0x0704, "Dell XPS 13 9350", ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE),
+ SND_PCI_QUIRK(0x1028, 0x0706, "Dell Inspiron 7559", ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER),
SND_PCI_QUIRK(0x1028, 0x0725, "Dell Inspiron 3162", ALC255_FIXUP_DELL_SPK_NOISE),
SND_PCI_QUIRK(0x1028, 0x075b, "Dell XPS 13 9360", ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE),
SND_PCI_QUIRK(0x1028, 0x075d, "Dell AIO", ALC298_FIXUP_SPK_VOLUME),
--
2.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: hda - Enable subwoofer on Dell Inspiron 7559
2016-08-30 5:27 [PATCH] ALSA: hda - Enable subwoofer on Dell Inspiron 7559 Kai-Heng Feng
@ 2016-08-30 5:33 ` Takashi Iwai
2016-08-30 6:25 ` Kai Heng Feng
0 siblings, 1 reply; 5+ messages in thread
From: Takashi Iwai @ 2016-08-30 5:33 UTC (permalink / raw)
To: Kai-Heng Feng; +Cc: alsa-devel, hui.wang, linux-kernel
On Tue, 30 Aug 2016 07:27:41 +0200,
Kai-Heng Feng wrote:
>
> The subwoofer on Inspiron 7559 does not work originally.
> Applying a pin fixup can make it work.
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
> sound/pci/hda/patch_realtek.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 7100f05..2a3dd18 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4855,6 +4855,7 @@ enum {
> ALC221_FIXUP_HP_FRONT_MIC,
> ALC292_FIXUP_TPT460,
> ALC298_FIXUP_SPK_VOLUME,
> + ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER,
> };
>
> static const struct hda_fixup alc269_fixups[] = {
> @@ -5516,6 +5517,15 @@ static const struct hda_fixup alc269_fixups[] = {
> .chained = true,
> .chain_id = ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
> },
> + [ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER] = {
> + .type = HDA_FIXUP_PINS,
> + .v.pins = (const struct hda_pintbl[]) {
> + { 0x1b, 0x90170151 },
What's the original value of this pin?
Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: hda - Enable subwoofer on Dell Inspiron 7559
2016-08-30 5:33 ` Takashi Iwai
@ 2016-08-30 6:25 ` Kai Heng Feng
2016-08-30 7:05 ` Takashi Iwai
0 siblings, 1 reply; 5+ messages in thread
From: Kai Heng Feng @ 2016-08-30 6:25 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel, Hui Wang, linux-kernel
On Tue, Aug 30, 2016 at 1:33 PM, Takashi Iwai <tiwai@suse.de> wrote:
> On Tue, 30 Aug 2016 07:27:41 +0200,
> Kai-Heng Feng wrote:
>>
>> The subwoofer on Inspiron 7559 does not work originally.
>> Applying a pin fixup can make it work.
>>
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>> ---
>> sound/pci/hda/patch_realtek.c | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>> index 7100f05..2a3dd18 100644
>> --- a/sound/pci/hda/patch_realtek.c
>> +++ b/sound/pci/hda/patch_realtek.c
>> @@ -4855,6 +4855,7 @@ enum {
>> ALC221_FIXUP_HP_FRONT_MIC,
>> ALC292_FIXUP_TPT460,
>> ALC298_FIXUP_SPK_VOLUME,
>> + ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER,
>> };
>>
>> static const struct hda_fixup alc269_fixups[] = {
>> @@ -5516,6 +5517,15 @@ static const struct hda_fixup alc269_fixups[] = {
>> .chained = true,
>> .chain_id = ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
>> },
>> + [ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER] = {
>> + .type = HDA_FIXUP_PINS,
>> + .v.pins = (const struct hda_pintbl[]) {
>> + { 0x1b, 0x90170151 },
>
> What's the original value of this pin?
>
>
> Takashi
The original value of 0x1b is 0x411111f0.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: hda - Enable subwoofer on Dell Inspiron 7559
2016-08-30 6:25 ` Kai Heng Feng
@ 2016-08-30 7:05 ` Takashi Iwai
2016-08-30 7:25 ` Kai Heng Feng
0 siblings, 1 reply; 5+ messages in thread
From: Takashi Iwai @ 2016-08-30 7:05 UTC (permalink / raw)
To: Kai Heng Feng; +Cc: alsa-devel, Hui Wang, linux-kernel
On Tue, 30 Aug 2016 08:25:18 +0200,
Kai Heng Feng wrote:
>
> On Tue, Aug 30, 2016 at 1:33 PM, Takashi Iwai <tiwai@suse.de> wrote:
> > On Tue, 30 Aug 2016 07:27:41 +0200,
> > Kai-Heng Feng wrote:
> >>
> >> The subwoofer on Inspiron 7559 does not work originally.
> >> Applying a pin fixup can make it work.
> >>
> >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> >> ---
> >> sound/pci/hda/patch_realtek.c | 11 +++++++++++
> >> 1 file changed, 11 insertions(+)
> >>
> >> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> >> index 7100f05..2a3dd18 100644
> >> --- a/sound/pci/hda/patch_realtek.c
> >> +++ b/sound/pci/hda/patch_realtek.c
> >> @@ -4855,6 +4855,7 @@ enum {
> >> ALC221_FIXUP_HP_FRONT_MIC,
> >> ALC292_FIXUP_TPT460,
> >> ALC298_FIXUP_SPK_VOLUME,
> >> + ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER,
> >> };
> >>
> >> static const struct hda_fixup alc269_fixups[] = {
> >> @@ -5516,6 +5517,15 @@ static const struct hda_fixup alc269_fixups[] = {
> >> .chained = true,
> >> .chain_id = ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
> >> },
> >> + [ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER] = {
> >> + .type = HDA_FIXUP_PINS,
> >> + .v.pins = (const struct hda_pintbl[]) {
> >> + { 0x1b, 0x90170151 },
> >
> > What's the original value of this pin?
> >
> >
> > Takashi
>
> The original value of 0x1b is 0x411111f0.
OK, so it was disabled. Maybe better to mention it in the patch
description.
Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: hda - Enable subwoofer on Dell Inspiron 7559
2016-08-30 7:05 ` Takashi Iwai
@ 2016-08-30 7:25 ` Kai Heng Feng
0 siblings, 0 replies; 5+ messages in thread
From: Kai Heng Feng @ 2016-08-30 7:25 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel, Hui Wang, linux-kernel
On Tue, Aug 30, 2016 at 3:05 PM, Takashi Iwai <tiwai@suse.de> wrote:
> On Tue, 30 Aug 2016 08:25:18 +0200,
> Kai Heng Feng wrote:
>>
>> On Tue, Aug 30, 2016 at 1:33 PM, Takashi Iwai <tiwai@suse.de> wrote:
>> > On Tue, 30 Aug 2016 07:27:41 +0200,
>> > Kai-Heng Feng wrote:
>> >>
>> >> The subwoofer on Inspiron 7559 does not work originally.
>> >> Applying a pin fixup can make it work.
>> >>
>> >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>> >> ---
>> >> sound/pci/hda/patch_realtek.c | 11 +++++++++++
>> >> 1 file changed, 11 insertions(+)
>> >>
>> >> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>> >> index 7100f05..2a3dd18 100644
>> >> --- a/sound/pci/hda/patch_realtek.c
>> >> +++ b/sound/pci/hda/patch_realtek.c
>> >> @@ -4855,6 +4855,7 @@ enum {
>> >> ALC221_FIXUP_HP_FRONT_MIC,
>> >> ALC292_FIXUP_TPT460,
>> >> ALC298_FIXUP_SPK_VOLUME,
>> >> + ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER,
>> >> };
>> >>
>> >> static const struct hda_fixup alc269_fixups[] = {
>> >> @@ -5516,6 +5517,15 @@ static const struct hda_fixup alc269_fixups[] = {
>> >> .chained = true,
>> >> .chain_id = ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
>> >> },
>> >> + [ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER] = {
>> >> + .type = HDA_FIXUP_PINS,
>> >> + .v.pins = (const struct hda_pintbl[]) {
>> >> + { 0x1b, 0x90170151 },
>> >
>> > What's the original value of this pin?
>> >
>> >
>> > Takashi
>>
>> The original value of 0x1b is 0x411111f0.
>
> OK, so it was disabled. Maybe better to mention it in the patch
> description.
>
>
> Takashi
OK, I'll resend one with better description. Thanks for the advice.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-08-30 7:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-30 5:27 [PATCH] ALSA: hda - Enable subwoofer on Dell Inspiron 7559 Kai-Heng Feng
2016-08-30 5:33 ` Takashi Iwai
2016-08-30 6:25 ` Kai Heng Feng
2016-08-30 7:05 ` Takashi Iwai
2016-08-30 7:25 ` Kai Heng Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).