From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH] ASoC: amd: added error checks in dma driver Date: Fri, 24 Nov 2017 00:11:47 -0800 Message-ID: References: <1511454602-7259-1-git-send-email-Vijendar.Mukunda@amd.com> <20171123172904.4akrfhlonlwkmgs6@sirena.org.uk> <5ec79579-c6c6-6a74-5eca-fecf87defb59@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <5ec79579-c6c6-6a74-5eca-fecf87defb59@amd.com> Sender: linux-kernel-owner@vger.kernel.org To: "Mukunda,Vijendar" Cc: Mark Brown , alsa-devel@alsa-project.org, Takashi Iwai , Liam Girdwood , perex@perex.cz, Alex Deucher , Akshu.Agrawal@amd.com, Guenter Roeck , linux-kernel , Dominik Behr , Daniel Kurtz , Guenter Roeck List-Id: alsa-devel@alsa-project.org On Fri, Nov 24, 2017 at 3:07 AM, Mukunda,Vijendar wrote: > > > > On Thursday 23 November 2017 10:59 PM, Mark Brown wrote: >> >> On Thu, Nov 23, 2017 at 08:59:43AM -0800, Guenter Roeck wrote: >>> >>> On Thu, Nov 23, 2017 at 8:30 AM, Vijendar Mukunda >>> wrote: >>>> >>>> added error checks in acp dma driver >>>> Signed-off-by: Vijendar Mukunda >>>> Signed-off-by: Akshu Agrawal >>>> Signed-off-by: Guenter Roeck >>> >>> This is inappropriate. >> >> Specifically: if Guenter wasn't involved in writing or forwarding the >> patch he shouldn't have a signoff in there, and if you're the one >> sending the mail you should be the last person in the chain of signoffs. >> Please see SubmittingPatches for details of what a signoff means and why >> they're important. > > > This patch was implemented on top of changes implemented by Guenter. > There is a separate thread - RE: [PATCH] ASoC: amd: Add error checking > to probe function in which Guenter posted changes. That was my patch. This is yours. Guenter > Got it, apologies will post changes as v2 version. >