From: Daniel Mack <zonque@gmail.com>
To: Kristian Amlie <kristian@amlie.name>
Cc: alsa-devel@alsa-project.org, Clemens Ladisch <clemens@ladisch.de>
Subject: Re: How to add a new MIDI device to the usbaudio driver
Date: Wed, 24 Aug 2011 12:29:45 +0200 [thread overview]
Message-ID: <CACTFLAPMg75au0VX_rAF3dLRsSyX8Wex+LFj7pfPXygvZrR7qw@mail.gmail.com> (raw)
In-Reply-To: <4E54CF09.90001@amlie.name>
On Wed, Aug 24, 2011 at 12:14 PM, Kristian Amlie <kristian@amlie.name> wrote:
> On 08/24/11 10:32, Daniel Mack wrote:
>> Hmm? Can you trace where this happens and which dereferenced pointer
>> is NULL? I don't see it, sorry.
>
> The attached patch solves the NULL pointer dereference. With this patch,
> the device shows up as a MIDI device, but still produces no events
> according to aseqdump.
Eh, quite obvious. Thanks for spotting.
> I did a more thorough examination of the calls to usb_control_msg() from
> the ftdi_sio driver, and this is what I came up with:
>
> Plugging it in:
>
> Calling usb_control_msg() from read_latency_timer(): value=0, index=0
> Calling usb_control_msg() from write_latency_timer(): value=1, index=0
> usb 3-2: FTDI USB Serial Device converter now attached to ttyUSB0
>
> Starting cu:
>
> Calling usb_control_msg() from ftdi_open(): value=0, index=0
> Calling usb_control_msg() from ftdi_set_termios(): value=8, index=0
> Calling usb_control_msg() from change_speed(): value=16696, index=0
> Calling usb_control_msg() from ftdi_set_termios(): value=0, index=0
> Calling usb_control_msg() from update_mctrl(): value=771, index=0
> Calling usb_control_msg() from ftdi_set_termios(): value=8, index=0
> Calling usb_control_msg() from change_speed(): value=49230, index=0
> Calling usb_control_msg() from ftdi_set_termios(): value=0, index=0
> Calling usb_control_msg() from ftdi_set_termios(): value=8, index=0
> Calling usb_control_msg() from change_speed(): value=49230, index=0
> Calling usb_control_msg() from ftdi_set_termios(): value=0, index=0
> Calling usb_control_msg() from ftdi_set_termios(): value=8, index=0
> Calling usb_control_msg() from change_speed(): value=49230, index=0
> Calling usb_control_msg() from ftdi_set_termios(): value=4881, index=1024
Ok - can you play around with these commands and add them to the MIDI
driver? The stubs are all there now, and I think all that's missing
is the termios call and maybe write_latency_timer(). I could prepare
another patch, but I think it's faster if you just try around which
command sequence helps :)
Daniel
next prev parent reply other threads:[~2011-08-24 10:29 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 10:52 How to add a new MIDI device to the usbaudio driver Kristian Amlie
2011-08-22 10:54 ` Daniel Mack
2011-08-22 11:40 ` Kristian Amlie
2011-08-22 11:49 ` Daniel Mack
2011-08-23 7:35 ` Kristian Amlie
2011-08-23 8:43 ` Daniel Mack
2011-08-23 9:03 ` Paul Menzel
2011-08-23 9:22 ` Daniel Mack
2011-08-23 9:42 ` Kristian Amlie
2011-08-23 10:02 ` Paul Menzel
2011-08-27 10:38 ` Kristian Amlie
2011-08-23 9:38 ` Clemens Ladisch
2011-08-23 9:42 ` Daniel Mack
2011-08-23 10:07 ` Kristian Amlie
2011-08-23 10:16 ` Daniel Mack
2011-08-23 11:57 ` Kristian Amlie
2011-08-23 12:20 ` Daniel Mack
2011-08-23 13:12 ` Kristian Amlie
2011-08-23 13:16 ` Daniel Mack
2011-08-23 13:28 ` Kristian Amlie
2011-08-23 13:44 ` Daniel Mack
2011-08-24 8:09 ` Kristian Amlie
2011-08-24 8:32 ` Daniel Mack
2011-08-24 10:14 ` Kristian Amlie
2011-08-24 10:29 ` Daniel Mack [this message]
2011-08-24 13:14 ` Kristian Amlie
2011-08-24 13:18 ` Daniel Mack
2011-08-24 19:51 ` Clemens Ladisch
2011-08-25 11:28 ` Kristian Amlie
2011-08-25 11:35 ` [PATCH] Added support for Starr Labs USB MIDI devices Kristian Amlie
2011-08-25 12:20 ` Daniel Mack
2011-08-25 13:40 ` Kristian Amlie
2011-08-26 11:24 ` Clemens Ladisch
2011-08-25 12:38 ` How to add a new MIDI device to the usbaudio driver Daniel Mack
2011-08-24 11:44 ` Clemens Ladisch
2011-08-24 12:05 ` Daniel Mack
2011-08-24 13:19 ` Kristian Amlie
2011-08-24 16:01 ` Clemens Ladisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACTFLAPMg75au0VX_rAF3dLRsSyX8Wex+LFj7pfPXygvZrR7qw@mail.gmail.com \
--to=zonque@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=kristian@amlie.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).