From: Dylan Reid <dgreid@chromium.org>
To: Mark Brown <broonie@kernel.org>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
srinivas.sripathi@intel.com, Yang Fang <yang.a.fang@intel.com>,
Praveen K Jain <praveen.k.jain@intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Vinod Koul <vinod.koul@intel.com>,
"Nujella, Sathyanarayana" <sathyanarayana.nujella@intel.com>,
Denny Iriawan <denny.iriawan@intel.com>,
kevin.strasser@linux.intel.com
Subject: Re: [PATCH] ASoC: Intel: Enabled button jack for BSW platform with rt5650 codec
Date: Tue, 5 May 2015 15:02:01 -0700 [thread overview]
Message-ID: <CAEUnVG7MW4z4kHipcCWEFAvkqFEu42k4ax4+S2YDvexwJjHdPw@mail.gmail.com> (raw)
In-Reply-To: <20150505214902.GG15510@sirena.org.uk>
On Tue, May 5, 2015 at 2:49 PM, Mark Brown <broonie@kernel.org> wrote:
> On Mon, May 04, 2015 at 05:19:20PM -0700, yang.a.fang@intel.com wrote:
>> From: "Fang, Yang A" <yang.a.fang@intel.com>
>>
>> rt5650 codec supports 4 buttons detections so enabled it
>
>> @@ -43,6 +43,7 @@ struct cht_acpi_card {
>> struct cht_mc_private {
>> struct snd_soc_jack hp_jack;
>> struct snd_soc_jack mic_jack;
>> + struct snd_soc_jack btn_jack;
>> struct cht_acpi_card *acpi_card;
>
> This is a bit weird - why are we adding an additional jack here, surely
> the button is attached to the mic jack here? The jacks should
> correspond to the physical jacks on the system rather than the function
> so that users and applications can tie the jacks that we have in
> software to those physically on the system.
>
> Now I'm wondering if the headphone and microphone are expected to be a
> single jack here?
At least the Chromebook version will have a single combo jack. I
would expect there to be a single jack created that reports all of hp,
mic, and buttons.
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
next prev parent reply other threads:[~2015-05-05 22:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 0:19 [PATCH] ASoC: Intel: Enabled button jack for BSW platform with rt5650 codec yang.a.fang
2015-05-05 21:49 ` Mark Brown
2015-05-05 22:02 ` Dylan Reid [this message]
2015-05-05 22:14 ` Yang Fang
2015-05-05 22:27 ` Dylan Reid
2015-05-05 22:30 ` Mark Brown
2015-05-05 22:39 ` Fang, Yang A
2015-05-05 22:42 ` Dylan Reid
2015-05-05 22:59 ` Fang, Yang A
2015-05-05 23:00 ` Mark Brown
2015-05-05 22:27 ` Mark Brown
2015-05-05 23:55 ` [PATCH v2] " yang.a.fang
2015-05-06 10:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEUnVG7MW4z4kHipcCWEFAvkqFEu42k4ax4+S2YDvexwJjHdPw@mail.gmail.com \
--to=dgreid@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=denny.iriawan@intel.com \
--cc=kevin.strasser@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=praveen.k.jain@intel.com \
--cc=sathyanarayana.nujella@intel.com \
--cc=srinivas.sripathi@intel.com \
--cc=vinod.koul@intel.com \
--cc=yang.a.fang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).