From: Caleb Crome <caleb@crome.org>
To: Arnaud Mouiche <arnaud.mouiche@invoxia.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Timur Tabi <timur@tabi.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Mark Brown <broonie@kernel.org>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH v4 3/6] ASoC: fsl_ssi: Save a dev reference for dev_err() purpose.
Date: Tue, 10 May 2016 09:34:02 -0700 [thread overview]
Message-ID: <CAG5mAdy=g+MrWFP2DCZOkEU=1_ZYKWWUjY9aqAqQXXA8NtWcLQ@mail.gmail.com> (raw)
In-Reply-To: <1462277640-20052-4-git-send-email-arnaud.mouiche@invoxia.com>
On Tue, May 3, 2016 at 5:13 AM, Arnaud Mouiche
<arnaud.mouiche@invoxia.com> wrote:
> Most of functions only receive the ssi_private reference and don't have
> a knowledge of 'dev' pointer, even for debug purpose.
>
> Signed-off-by: Arnaud Mouiche <arnaud.mouiche@invoxia.com>
> ---
> sound/soc/fsl/fsl_ssi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
> index 1a9d0ad..695f041 100644
> --- a/sound/soc/fsl/fsl_ssi.c
> +++ b/sound/soc/fsl/fsl_ssi.c
> @@ -262,6 +262,7 @@ struct fsl_ssi_private {
> struct fsl_ssi_dbg dbg_stats;
>
> const struct fsl_ssi_soc_data *soc;
> + struct device *dev;
> };
>
> /*
> @@ -1405,6 +1406,7 @@ static int fsl_ssi_probe(struct platform_device *pdev)
> }
>
> ssi_private->soc = of_id->data;
> + ssi_private->dev = &pdev->dev;
>
> sprop = of_get_property(np, "fsl,mode", NULL);
> if (sprop) {
> --
> 1.9.1
>
Tested-by: Caleb Crome <caleb@crome.org>
next prev parent reply other threads:[~2016-05-10 16:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 12:13 [PATCH v4 0/6] ASoC: fsl_ssi: Fixing various channel slips and bad samples insertions Arnaud Mouiche
2016-05-03 12:13 ` [PATCH v4 1/6] ASoC: fsl_ssi: Real hardware channels max number is 32 Arnaud Mouiche
2016-05-03 12:23 ` Fabio Estevam
2016-05-10 16:32 ` Caleb Crome
2016-05-03 12:13 ` [PATCH v4 2/6] ASoC: fsl_ssi: The IPG/5 limitation concerns the bitclk, not the sysclk Arnaud Mouiche
2016-05-03 12:23 ` Fabio Estevam
2016-05-10 16:33 ` Caleb Crome
2016-05-03 12:13 ` [PATCH v4 3/6] ASoC: fsl_ssi: Save a dev reference for dev_err() purpose Arnaud Mouiche
2016-05-03 12:17 ` Timur Tabi
2016-05-07 22:54 ` Fabio Estevam
2016-05-10 16:34 ` Caleb Crome [this message]
2016-05-03 12:13 ` [PATCH v4 4/6] ASoC: fsl_ssi: Fix samples being dropped at Playback startup Arnaud Mouiche
2016-05-03 12:24 ` Fabio Estevam
2016-05-10 16:34 ` Caleb Crome
2016-05-03 12:13 ` [PATCH v4 5/6] ASoC: fsl_ssi: Fix channel slipping in Playback at startup Arnaud Mouiche
2016-05-03 12:24 ` Fabio Estevam
2016-05-10 16:34 ` Caleb Crome
2016-05-03 12:14 ` [PATCH v4 6/6] ASoC: fsl_ssi: Fix channel slipping on capture (or playback) restart in full duplex Arnaud Mouiche
2016-05-03 12:24 ` Fabio Estevam
2016-05-10 16:34 ` Caleb Crome
2016-05-13 12:25 ` Applied "ASoC: fsl_ssi: Fix channel slipping on capture (or playback) restart in full duplex." to the asoc tree Mark Brown
2016-05-07 22:56 ` [PATCH v4 0/6] ASoC: fsl_ssi: Fixing various channel slips and bad samples insertions Fabio Estevam
2016-05-07 23:16 ` Nicolin Chen
2016-05-10 16:32 ` Caleb Crome
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG5mAdy=g+MrWFP2DCZOkEU=1_ZYKWWUjY9aqAqQXXA8NtWcLQ@mail.gmail.com' \
--to=caleb@crome.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.mouiche@invoxia.com \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=nicoleotsuka@gmail.com \
--cc=timur@tabi.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).