From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: "Matthew Garrett" <mjg59@srcf.ucam.org>,
"ALSA Development Mailing List" <alsa-devel@alsa-project.org>,
"Mario Limonciello" <mario.limonciello@dell.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Takashi Iwai" <tiwai@suse.com>,
"Platform Driver" <platform-driver-x86@vger.kernel.org>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Darren Hart" <dvhart@infradead.org>,
"Andy Shevchenko" <andy@infradead.org>
Subject: Re: [PATCH v4 2/3] platform/x86: dell-*: Add interface for switchable graphics status query
Date: Mon, 23 Apr 2018 16:43:41 +0300 [thread overview]
Message-ID: <CAHp75VdwtOS_B978JOXqWRnj611jMJyN7BxFr+qu+Ojdf07i2Q@mail.gmail.com> (raw)
In-Reply-To: <20180420094432.13133-2-kai.heng.feng@canonical.com>
On Fri, Apr 20, 2018 at 12:44 PM, Kai-Heng Feng
<kai.heng.feng@canonical.com> wrote:
> On some Dell platforms, there's a BIOS option "Enable Switchable
> Graphics". This information is useful if we want to do different things
> based on this value, e.g. disable unused audio controller that comes
> with the discrete graphics.
> int dell_micmute_led_set(int on);
> +bool dell_switchable_gfx_is_enabled(void);
I would rather preserve existing API, i.e.
- prototype int func(void), where return either state or negative error code.
- naming: dell_switchable_gfx_get()
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-04-23 13:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 9:44 [PATCH v4 1/3] dell-led: Change dell-led.h to dell-common.h Kai-Heng Feng
2018-04-20 9:44 ` [PATCH v4 2/3] platform/x86: dell-*: Add interface for switchable graphics status query Kai-Heng Feng
2018-04-23 13:43 ` Andy Shevchenko [this message]
2018-04-20 9:44 ` [PATCH v4 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics Kai-Heng Feng
2018-04-20 12:10 ` [alsa-devel] " Takashi Iwai
2018-04-23 8:04 ` Kai Heng Feng
2018-04-23 8:08 ` Pali Rohár
2018-04-23 8:18 ` Kai Heng Feng
2018-04-23 8:29 ` [alsa-devel] " Pali Rohár
2018-04-24 21:13 ` Lukas Wunner
2018-04-26 7:52 ` Kai Heng Feng
2018-05-02 7:44 ` [alsa-devel] " Lukas Wunner
2018-04-23 13:52 ` Andy Shevchenko
2018-04-24 16:26 ` [PATCH v4 1/3] dell-led: Change dell-led.h to dell-common.h Takashi Iwai
2018-04-26 7:25 ` Kai Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdwtOS_B978JOXqWRnj611jMJyN7BxFr+qu+Ojdf07i2Q@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=mjg59@srcf.ucam.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).