From: Matt Ranostay <matt@ranostay.consulting>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
alsa-devel@alsa-project.org,
Linux OMAP List <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v7] ASoC: omap-mcbsp: Add PM QoS support for McBSP to prevent glitches
Date: Tue, 17 Jan 2017 15:04:22 -0800 [thread overview]
Message-ID: <CAJ_EiSTCo7ZYTfwFomXfyauEP65REp3Vd7jCCGf-OsT8N0rU7A@mail.gmail.com> (raw)
In-Reply-To: <d35dbc1b-da5b-a482-3688-f7b20278d5fb@ti.com>
On Tue, Jan 17, 2017 at 4:34 AM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
> On 01/16/2017 09:30 PM, Matt Ranostay wrote:
>> Yep I was testing with that enabled. Not sure why I'm not getting it
>> all... maybe different side effects like sample rate of the audio
>> being played?
>>
>> Peter, is there chance that there is race condition is possible
>> between pm_qos_remove_request and omap_mcbsp_dai_shutdown?
>
> Not with my knowledge.
> However one thing might happen which is not handled:
> application opens up the audio card, does some hw_param setup, then it
> decides to close the card. In this case the pm_qos is not placed, but in
> dai_shutdown we try to remove it -> WARN().
>
> I think we need to check either if the pm_qos is active and only then
> bother with the removal/updated or we can check if the
> mcbsp->latency[stream1] is not 0, which should be the same as checking
> for the pm_qos active
Ok makes sense. Weird I'm not seeing it but I wanted to be sure adding
checks wasn't just hiding a issue.
Will submit v8... and hopefully that is the final one! *fingers crossed*
>
> --
> Péter
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2017-01-17 23:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 3:54 [PATCH v7] ASoC: omap-mcbsp: Add PM QoS support for McBSP to prevent glitches Matt Ranostay
2017-01-13 15:20 ` Tony Lindgren
2017-01-13 17:57 ` Matt Ranostay
2017-01-14 5:15 ` Matt Ranostay
2017-01-16 17:17 ` Tony Lindgren
2017-01-16 19:30 ` Matt Ranostay
2017-01-17 12:34 ` Peter Ujfalusi
2017-01-17 23:04 ` Matt Ranostay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ_EiSTCo7ZYTfwFomXfyauEP65REp3Vd7jCCGf-OsT8N0rU7A@mail.gmail.com \
--to=matt@ranostay.consulting \
--cc=alsa-devel@alsa-project.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).