From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A71BEC43463 for ; Mon, 21 Sep 2020 08:27:47 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 158CF206D9 for ; Mon, 21 Sep 2020 08:27:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="d5ZslSN4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="wsnGvCVQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 158CF206D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8556A17FA; Mon, 21 Sep 2020 10:26:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8556A17FA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1600676865; bh=BzRCCHrMyRtEbFXS+WPF2C06UQOXtwZQ6+AR7KwiNeY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=d5ZslSN4exGV8JdQRQbL8MSUCKzUoAfGQvKQl1YU5I8sAWqSrhvEVcpDEkWlmAX8j s1+aO49bHjZIuKWxu6LgzRueT7/hA8xWHEmfVAOCt1YzF3Ud0LA/jb0POgYcfQJZ1L 7Ffcs3xurlyZqr8BP7ptU7uvSJ+UQksFSDwB/PFw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 15D72F803CC; Mon, 21 Sep 2020 10:11:17 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A1BF7F8015A; Fri, 18 Sep 2020 16:30:21 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 99347F8012D for ; Fri, 18 Sep 2020 16:30:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 99347F8012D Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="wsnGvCVQ" Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ECEE62395B for ; Fri, 18 Sep 2020 14:30:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600439416; bh=BzRCCHrMyRtEbFXS+WPF2C06UQOXtwZQ6+AR7KwiNeY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=wsnGvCVQtY3Fjm96gabQ3yL4JGp4SlDe9LHAm1jvpUvHr4V01rcYNvZ8aAR5/K6DI 4ZbsvZ+rAFCvVqvjpfACz0NLKa8hCi2rM2fn+sntjgW8FTh7cdsNOd+SljkNn6CNLZ +rN4wh+xCQKm+ZXfiYaJE9WT1AOlwD7HPuVdyYqE= Received: by mail-ot1-f45.google.com with SMTP id m13so1053313otl.9 for ; Fri, 18 Sep 2020 07:30:15 -0700 (PDT) X-Gm-Message-State: AOAM533/Z0TvsYtF1kSen7bfDoSwdfyU2tG7v55S4yw7MpmZbm0qFAyW Q+YgSgjQW/pvRSx7X8wcL8hNYR2eMNKUEJgmWQ== X-Google-Smtp-Source: ABdhPJwB1Ma/MKweZxwzRdC4MQG3s3W4wg0oVoNXdP8sSb8gUQ626v5DX61EKMyUVGmHFAKJsNKSrOjgarNcaCyLkpU= X-Received: by 2002:a05:6830:1008:: with SMTP id a8mr21429982otp.107.1600439413814; Fri, 18 Sep 2020 07:30:13 -0700 (PDT) MIME-Version: 1.0 References: <20200917165301.23100-1-krzk@kernel.org> <20200917165301.23100-2-krzk@kernel.org> In-Reply-To: <20200917165301.23100-2-krzk@kernel.org> From: Rob Herring Date: Fri, 18 Sep 2020 08:30:02 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 01/13] dt-bindings: gpio: add common schema for GPIO controllers To: Krzysztof Kozlowski Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Mon, 21 Sep 2020 10:10:23 +0200 Cc: Amelie Delaunay , Geert Uytterhoeven , Matti Vaittinen , Linus Walleij , Linux-ALSA , Stefan Agner , Bjorn Andersson , Paul Cercueil , Masahiro Yamada , Chris Brandt , Srinivas Kandagatla , Manivannan Sadhasivam , linux-riscv , Fabio Estevam , "moderated list:ARM/STM32 ARCHITECTURE" , Alexandre Torgue , "open list:MEDIA DRIVERS FOR RENESAS - FCP" , Laurent Pinchart , Anson Huang , Lee Jones , Takashi Iwai , Magnus Damm , Bartosz Golaszewski , Chen-Yu Tsai , Andy Gross , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , NXP Linux Team , Andy Teng , Jacopo Mondi , Sungbo Eo , linux-arm-msm , devicetree@vger.kernel.org, Cristian Ciocaltea , Charles Keepax , Maxime Coquelin , Ray Jui , Sascha Hauer , Sean Wang , Maxime Ripard , "open list:GPIO SUBSYSTEM" , Richard Fitzgerald , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Paul Walmsley , Matthias Brugger , Sricharan R , Mauro Carvalho Chehab , Hoan Tran , linux-arm-kernel , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Scott Branden , linux-unisoc@lists.infradead.org, - , Chris Packham , Liam Girdwood , Serge Semin , "linux-kernel@vger.kernel.org" , Paul Kocialkowski , Yash Shah , Kieran Bingham , Palmer Dabbelt , Pengutronix Kernel Team , Linux Media Mailing List , Shawn Guo , =?UTF-8?Q?Andreas_F=C3=A4rber?= X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Sep 17, 2020 at 10:53 AM Krzysztof Kozlowski wrote: > > Convert parts of gpio.txt bindings into common dtschema file for GPIO > controllers. The schema enforces proper naming of GPIO controller nodes > and GPIO hogs. Did you not see my previous reply about a common schema? We already have a common GPIO and hog schema in dtschema. Please add to it whatever is missing. My goal is all common schema end up in dtschema, but I haven't pushed folks to do that yet. Ones I've done are there though. One issue is what's in dtschema should be GPL/BSD and the existing text bindings are default GPL, so there's a relicensing exercise. In some cases, the schema is there but I haven't copied over the descriptions. Rob > + description: > + Indicates the start and size of the GPIOs that can't be used. > + > + ngpios: > + description: | > + Optionally, a GPIO controller may have a "ngpios" property. This property > + indicates the number of in-use slots of available slots for GPIOs. The > + typical example is something like this: the hardware register is 32 bits > + wide, but only 18 of the bits have a physical counterpart. The driver is > + generally written so that all 32 bits can be used, but the IP block is > + reused in a lot of designs, some using all 32 bits, some using 18 and > + some using 12. In this case, setting "ngpios = <18>;" informs the driver > + that only the first 18 GPIOs, at local offset 0 .. 17, are in use. > + > + If these GPIOs do not happen to be the first N GPIOs at offset 0...N-1, > + an additional set of tuples is needed to specify which GPIOs are > + unusable, with the gpio-reserved-ranges binding. > + > +patternProperties: > + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": > + type: object > + description: > + The GPIO chip may contain GPIO hog definitions. GPIO hogging is a mechanism > + providing automatic GPIO request and configuration as part of the > + gpio-controller's driver probe function. > + Each GPIO hog definition is represented as a child node of the GPIO controller. > + > + properties: > + gpio-hog: true > + gpios: true > + input: true > + output-high: true > + output-low: true > + line-name: > + description: > + The GPIO label name. If not present the node name is used. > + > + required: > + - gpio-hog > + - gpios > + > + oneOf: > + - required: > + - input > + - required: > + - output-high > + - required: > + - output-low > + > + additionalProperties: false > + > +required: > + - "#gpio-cells" > + - gpio-controller > + > +examples: > + - | > + gpio-controller@15000000 { > + compatible = "foo"; > + reg = <0x15000000 0x1000>; > + gpio-controller; > + #gpio-cells = <2>; > + ngpios = <18>; > + gpio-reserved-ranges = <0 4>, <12 2>; > + gpio-line-names = "MMC-CD", "MMC-WP", "VDD eth", "RST eth", "LED R", > + "LED G", "LED B", "Col A", "Col B", "Col C", "Col D", > + "Row A", "Row B", "Row C", "Row D", "NMI button", > + "poweroff", "reset"; > + }; > + > + - | > + gpio-controller@1400 { > + compatible = "fsl,qe-pario-bank-a", "fsl,qe-pario-bank"; > + reg = <0x1400 0x18>; > + gpio-controller; > + #gpio-cells = <2>; > + > + line-b-hog { > + gpio-hog; > + gpios = <6 0>; > + input; > + line-name = "foo-bar-gpio"; > + }; > + }; > -- > 2.17.1 >