From mboxrd@z Thu Jan 1 00:00:00 1970 From: Connor McAdams Subject: Re: [PATCH v3 5/9] ALSA: hda/ca0132: add/change helper functions for R3Di and SBZ Date: Mon, 7 May 2018 09:55:15 -0400 Message-ID: References: <1525547001-17588-1-git-send-email-conmanx360@gmail.com> <1525547001-17588-6-git-send-email-conmanx360@gmail.com> <9918d3d1-d843-6142-ca95-91ee0bde3d6b@sakamocchi.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <9918d3d1-d843-6142-ca95-91ee0bde3d6b@sakamocchi.jp> Sender: linux-kernel-owner@vger.kernel.org To: Takashi Sakamoto Cc: Jaroslav Kysela , Takashi Iwai , =?UTF-8?B?SsOpcsOpbXkgTGVmYXVyZQ==?= , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org Just to make sure, do you mean that I need to add more comments to the SBZ and R3Di changes, or are they good as is? Thanks, Connor. On Sun, May 6, 2018 at 10:29 PM, Takashi Sakamoto wrote: > Hi, > > On May 6 2018 04:03, Connor McAdams wrote: >> >> Edit core functions to support the Sound Blaster Z and Recon3Di for >> startup and loading of the DSP, as well as setting effects. >> >> Signed-off-by: Connor McAdams >> --- >> sound/pci/hda/patch_ca0132.c | 1064 >> ++++++++++++++++++++++++++++++++++++++++-- >> 1 file changed, 1018 insertions(+), 46 deletions(-) > > > In my opinion, this patch is too large. This patch can be split into > several parts: > > * Changes for signature of 'dspio_scp()' to get 'src_id' > * dspio_scp() > * dspio_set_param() > * dspio_set_uint_param() > * dspio_alloc_dma_chan() > * dspio_free_dma_chan() > * Changes for SBZ only > * Changes for R3Di only > > Could you please prepare for these three patches from this large patch in > your next chance? Especially, you can describe enough information to the > latter two patches as patch comment. > > > Thanks > > Takashi Sakamoto