From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8E59C433FE for ; Tue, 11 Oct 2022 14:41:01 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DCA073E08; Tue, 11 Oct 2022 16:40:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DCA073E08 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1665499259; bh=hEEbjFNkUoUyMh2KpcSleFdDACALAdemRBKk4JXGLGE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=YLorKwEaA6pD7LNQeKQHUrHXUI4PDRuxRfO4TRMLGeqtLbe8KqOyfy22n0mMWndeK E2YLx3p4lOTqo3fGBYZ0dB9HlVI3UjATA/4O+OjWz89gJDjC2VyVzGibkBbWTvsCNz D+mp2GaI1v3s/Oum2eIWjipKm7MO4hRypiYR1ekw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 82264F801D5; Tue, 11 Oct 2022 16:40:09 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 67FB5F8021D; Tue, 11 Oct 2022 16:40:08 +0200 (CEST) Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7E050F80130 for ; Tue, 11 Oct 2022 16:40:02 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7E050F80130 Received: by mail-qv1-f49.google.com with SMTP id mx8so9052589qvb.8 for ; Tue, 11 Oct 2022 07:40:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7sKcP+GTT+SWbU28Mvg7qTSCnoQqhpg8QoNv8i57vas=; b=NK3qz+JnfAacVzANmdxh55WOoP/QlpCpWX8IGUj5eHHHp4lZgf4PLTCDPGqch0lZEQ zz1R43jlSez5cmFBeXJBfz7wnMBZZbPfL4eOanaih8my8VJ8ooyNRieZbHNZLu7nLE0T pB1TyUjREm31w++KZJfEnTf/LPWem5N64MqVr/mQq+O2xTKncIT/BX/6ttZEzkkkAwhP JDrvzDANMYcrXDs376A7VGXnXuQ+LZSAZlbNMqeqFe3vrnBqlEyrC4pokOpbZZ2+JZGF UQnF9vm1HLY4DnLlfKmtd6lX4zcx/27xTyxuaK2C0pyWjjd12bZ8MOieJi0kGQJ0Z1i0 Om6A== X-Gm-Message-State: ACrzQf1QfJxZm3ew4hTQ1BAuCEHtvweGOLHDl3h1K+sBYx1rnlu3cPFR d77d8ifekKPvMBYDYKNUVWBfsDKMTKHdaQ== X-Google-Smtp-Source: AMsMyM4PGJIxLetoOGBMr4RUSLPGQ9oUyxKxeqh/1t9do+R5X+wCJpfmAau9hsn1bUszqAhqioGU1w== X-Received: by 2002:a05:6214:252c:b0:4b1:8d8b:9042 with SMTP id gg12-20020a056214252c00b004b18d8b9042mr19150603qvb.29.1665499200781; Tue, 11 Oct 2022 07:40:00 -0700 (PDT) Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com. [209.85.219.176]) by smtp.gmail.com with ESMTPSA id u10-20020a05620a430a00b006e702033b15sm12979182qko.66.2022.10.11.07.39.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Oct 2022 07:39:58 -0700 (PDT) Received: by mail-yb1-f176.google.com with SMTP id y205so16683448yby.13 for ; Tue, 11 Oct 2022 07:39:58 -0700 (PDT) X-Received: by 2002:a25:4fc2:0:b0:6be:afb4:d392 with SMTP id d185-20020a254fc2000000b006beafb4d392mr21857240ybb.604.1665499197788; Tue, 11 Oct 2022 07:39:57 -0700 (PDT) MIME-Version: 1.0 References: <20221010201453.77401-1-andriy.shevchenko@linux.intel.com> <20221010201453.77401-3-andriy.shevchenko@linux.intel.com> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 11 Oct 2022 16:39:46 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 02/36] gpiolib: cdev: Add missed header(s) To: Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Cc: Kent Gibson , linux-omap@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-aspeed@lists.ozlabs.org, patches@opensource.cirrus.com, Bartosz Golaszewski , linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-riscv@lists.infradead.org, alsa-devel@alsa-project.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Andy, On Tue, Oct 11, 2022 at 4:31 PM Andy Shevchenko wrote: > On Tue, Oct 11, 2022 at 10:13:02PM +0800, Kent Gibson wrote: > > On Tue, Oct 11, 2022 at 04:48:17PM +0300, Andy Shevchenko wrote: > > > On Tue, Oct 11, 2022 at 11:05:42AM +0300, Andy Shevchenko wrote: > > > > On Tue, Oct 11, 2022 at 3:02 AM Kent Gibson wrote: > > > > > On Mon, Oct 10, 2022 at 11:14:18PM +0300, Andy Shevchenko wrote: > > ... > > > > > > > -#include > > > > > > #include > > > > > > +#include > > > > > > +#include > > > > > > > > > > Ok with the hte re-order. > > > > > > > > > > But moving the gpio subsystem header after the gpio/driver is not > > > > > alphabetical ('.' precedes '/') and it read better and made more sense > > > > > to me the way it was. > > > > > > > > I see, I guess this is vim sort vs shell sort. Strange, they should > > > > follow the locale settings... > > > > > > I have checked, the shell and vim sort gave the same result as in this patch. > > > > > > > The original order (sans hte.h) was done by VSCode Sort Lines Ascending, > > and that still returns the same result. That matches what I would > > expect to see given the content of the text. > > > > And for me vim also gives the original order. > > > > Just to confirm - is '.' 0x2e and '/' 0x2f in your universe? > > $ LC_COLLATE=C sort test1.txt > #include > #include > > $ LC_COLLATE= sort test1.txt > #include > #include > > I guess this explains the difference. Currently I have en_US.UTF-8. Throwing my can of paint into the mix... I think it is more logical to first include the general , followed by whatever and , irrespective of (language-specific or phonebook) sort order. Yeah, it sucks that this requires some manual work after running sort... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds