alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn
@ 2017-02-17  7:11 Joe Perches
  2017-02-17  7:11 ` [PATCH 35/35] sound/soc: Convert remaining uses of " Joe Perches
       [not found] ` <cover.1487314666.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
  0 siblings, 2 replies; 13+ messages in thread
From: Joe Perches @ 2017-02-17  7:11 UTC (permalink / raw)
  To: Alexander Shishkin, Karol Herbst, Pekka Paalanen,
	Richard Weinberger, Fabio Estevam, linux-kernel, linux-arm-kernel,
	linuxppc-dev, tboot-devel, nouveau, oprofile-list, sfi-devel,
	xen-devel, linux-acpi, drbd-dev, virtualization, linux-crypto,
	linux-ide, gigaset307x-common, linux-media, linux-omap, linux-mtd,
	devicetree, acpi4asus-user, platform-driver-x86, linux-scsi
  Cc: linux-ia64, linux-sh, netdev, linux-input, adi-buildroot-devel,
	amd-gfx, dri-devel, linux-alpha, sparclinux

There are ~4300 uses of pr_warn and ~250 uses of the older
pr_warning in the kernel source tree.

Make the use of pr_warn consistent across all kernel files.

This excludes all files in tools/ as there is a separate
define pr_warning for that directory tree and pr_warn is
not used in tools/.

Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing.

Miscellanea:

o Coalesce formats and realign arguments

Some files not compiled - no cross-compilers

Joe Perches (35):
  alpha: Convert remaining uses of pr_warning to pr_warn
  ARM: ep93xx: Convert remaining uses of pr_warning to pr_warn
  arm64: Convert remaining uses of pr_warning to pr_warn
  arch/blackfin: Convert remaining uses of pr_warning to pr_warn
  ia64: Convert remaining use of pr_warning to pr_warn
  powerpc: Convert remaining uses of pr_warning to pr_warn
  sh: Convert remaining uses of pr_warning to pr_warn
  sparc: Convert remaining use of pr_warning to pr_warn
  x86: Convert remaining uses of pr_warning to pr_warn
  drivers/acpi: Convert remaining uses of pr_warning to pr_warn
  block/drbd: Convert remaining uses of pr_warning to pr_warn
  gdrom: Convert remaining uses of pr_warning to pr_warn
  drivers/char: Convert remaining use of pr_warning to pr_warn
  clocksource: Convert remaining use of pr_warning to pr_warn
  drivers/crypto: Convert remaining uses of pr_warning to pr_warn
  fmc: Convert remaining use of pr_warning to pr_warn
  drivers/gpu: Convert remaining uses of pr_warning to pr_warn
  drivers/ide: Convert remaining uses of pr_warning to pr_warn
  drivers/input: Convert remaining uses of pr_warning to pr_warn
  drivers/isdn: Convert remaining uses of pr_warning to pr_warn
  drivers/macintosh: Convert remaining uses of pr_warning to pr_warn
  drivers/media: Convert remaining use of pr_warning to pr_warn
  drivers/mfd: Convert remaining uses of pr_warning to pr_warn
  drivers/mtd: Convert remaining uses of pr_warning to pr_warn
  drivers/of: Convert remaining uses of pr_warning to pr_warn
  drivers/oprofile: Convert remaining uses of pr_warning to pr_warn
  drivers/platform: Convert remaining uses of pr_warning to pr_warn
  drivers/rapidio: Convert remaining use of pr_warning to pr_warn
  drivers/scsi: Convert remaining use of pr_warning to pr_warn
  drivers/sh: Convert remaining use of pr_warning to pr_warn
  drivers/tty: Convert remaining uses of pr_warning to pr_warn
  drivers/video: Convert remaining uses of pr_warning to pr_warn
  kernel/trace: Convert remaining uses of pr_warning to pr_warn
  lib: Convert remaining uses of pr_warning to pr_warn
  sound/soc: Convert remaining uses of pr_warning to pr_warn

 arch/alpha/kernel/perf_event.c                     |  4 +-
 arch/arm/mach-ep93xx/core.c                        |  4 +-
 arch/arm64/include/asm/syscall.h                   |  8 ++--
 arch/arm64/kernel/hw_breakpoint.c                  |  8 ++--
 arch/arm64/kernel/smp.c                            |  4 +-
 arch/blackfin/kernel/nmi.c                         |  2 +-
 arch/blackfin/kernel/ptrace.c                      |  2 +-
 arch/blackfin/mach-bf533/boards/stamp.c            |  2 +-
 arch/blackfin/mach-bf537/boards/cm_bf537e.c        |  2 +-
 arch/blackfin/mach-bf537/boards/cm_bf537u.c        |  2 +-
 arch/blackfin/mach-bf537/boards/stamp.c            |  2 +-
 arch/blackfin/mach-bf537/boards/tcm_bf537.c        |  2 +-
 arch/blackfin/mach-bf561/boards/cm_bf561.c         |  2 +-
 arch/blackfin/mach-bf561/boards/ezkit.c            |  2 +-
 arch/blackfin/mm/isram-driver.c                    |  4 +-
 arch/ia64/kernel/setup.c                           |  6 +--
 arch/powerpc/kernel/pci-common.c                   |  4 +-
 arch/powerpc/mm/init_64.c                          |  5 +--
 arch/powerpc/mm/mem.c                              |  3 +-
 arch/powerpc/platforms/512x/mpc512x_shared.c       |  4 +-
 arch/powerpc/platforms/85xx/socrates_fpga_pic.c    |  7 ++--
 arch/powerpc/platforms/86xx/mpc86xx_hpcn.c         |  2 +-
 arch/powerpc/platforms/pasemi/dma_lib.c            |  4 +-
 arch/powerpc/platforms/powernv/opal.c              |  8 ++--
 arch/powerpc/platforms/powernv/pci-ioda.c          | 10 ++---
 arch/powerpc/platforms/ps3/device-init.c           | 14 +++----
 arch/powerpc/platforms/ps3/mm.c                    |  4 +-
 arch/powerpc/platforms/ps3/os-area.c               |  2 +-
 arch/powerpc/platforms/pseries/iommu.c             |  8 ++--
 arch/powerpc/platforms/pseries/setup.c             |  4 +-
 arch/powerpc/sysdev/fsl_pci.c                      |  9 ++---
 arch/powerpc/sysdev/mpic.c                         | 10 ++---
 arch/powerpc/sysdev/xics/icp-native.c              | 10 ++---
 arch/powerpc/sysdev/xics/ics-opal.c                |  4 +-
 arch/powerpc/sysdev/xics/ics-rtas.c                |  4 +-
 arch/powerpc/sysdev/xics/xics-common.c             |  8 ++--
 arch/sh/boards/mach-sdk7786/nmi.c                  |  2 +-
 arch/sh/drivers/pci/fixups-sdk7786.c               |  2 +-
 arch/sh/kernel/io_trapped.c                        |  2 +-
 arch/sh/kernel/setup.c                             |  2 +-
 arch/sh/mm/consistent.c                            |  5 +--
 arch/sparc/kernel/smp_64.c                         |  5 +--
 arch/x86/kernel/amd_gart_64.c                      | 12 ++----
 arch/x86/kernel/apic/apic.c                        | 46 ++++++++++------------
 arch/x86/kernel/apic/apic_noop.c                   |  2 +-
 arch/x86/kernel/setup_percpu.c                     |  4 +-
 arch/x86/kernel/tboot.c                            | 15 ++++---
 arch/x86/kernel/tsc_sync.c                         |  8 ++--
 arch/x86/mm/kmmio.c                                |  8 ++--
 arch/x86/mm/mmio-mod.c                             |  5 +--
 arch/x86/mm/numa.c                                 | 12 +++---
 arch/x86/mm/numa_emulation.c                       |  6 +--
 arch/x86/mm/testmmiotrace.c                        |  5 +--
 arch/x86/oprofile/op_x86_model.h                   |  6 +--
 arch/x86/platform/olpc/olpc-xo15-sci.c             |  2 +-
 arch/x86/platform/sfi/sfi.c                        |  3 +-
 arch/x86/xen/debugfs.c                             |  2 +-
 arch/x86/xen/setup.c                               |  2 +-
 drivers/acpi/apei/apei-base.c                      | 32 +++++++--------
 drivers/acpi/apei/einj.c                           |  4 +-
 drivers/acpi/apei/erst-dbg.c                       |  4 +-
 drivers/acpi/apei/ghes.c                           | 30 +++++++-------
 drivers/acpi/apei/hest.c                           | 10 ++---
 drivers/acpi/resource.c                            |  4 +-
 drivers/block/drbd/drbd_nl.c                       | 13 +++---
 drivers/cdrom/gdrom.c                              |  4 +-
 drivers/char/virtio_console.c                      |  2 +-
 drivers/clocksource/samsung_pwm_timer.c            |  4 +-
 drivers/crypto/n2_core.c                           | 12 +++---
 drivers/fmc/fmc-fakedev.c                          |  2 +-
 drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c   |  2 +-
 drivers/gpu/drm/amd/powerplay/inc/pp_debug.h       |  2 +-
 drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c    |  4 +-
 drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c | 14 +++----
 .../gpu/drm/amd/powerplay/smumgr/polaris10_smc.c   |  4 +-
 drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c   |  4 +-
 drivers/ide/tx4938ide.c                            |  2 +-
 drivers/ide/tx4939ide.c                            |  5 +--
 drivers/input/gameport/gameport.c                  |  4 +-
 drivers/input/joystick/gamecon.c                   |  3 +-
 drivers/input/misc/apanel.c                        |  3 +-
 drivers/input/misc/xen-kbdfront.c                  |  8 ++--
 drivers/input/serio/serio.c                        |  8 ++--
 drivers/isdn/gigaset/interface.c                   |  2 +-
 drivers/isdn/hardware/mISDN/avmfritz.c             | 17 ++++----
 drivers/isdn/hardware/mISDN/hfcmulti.c             |  8 ++--
 drivers/isdn/hardware/mISDN/hfcpci.c               |  4 +-
 drivers/isdn/hardware/mISDN/hfcsusb.c              |  4 +-
 drivers/isdn/hardware/mISDN/mISDNipac.c            |  4 +-
 drivers/isdn/hardware/mISDN/mISDNisar.c            | 10 ++---
 drivers/isdn/hardware/mISDN/netjet.c               |  8 ++--
 drivers/isdn/hardware/mISDN/w6692.c                | 12 +++---
 drivers/isdn/mISDN/hwchannel.c                     |  8 ++--
 drivers/macintosh/windfarm_fcu_controls.c          |  5 +--
 drivers/macintosh/windfarm_lm87_sensor.c           |  4 +-
 drivers/macintosh/windfarm_pm72.c                  | 22 +++++------
 drivers/macintosh/windfarm_rm31.c                  |  6 +--
 drivers/media/platform/sh_vou.c                    |  4 +-
 drivers/mfd/db8500-prcmu.c                         |  2 +-
 drivers/mfd/sta2x11-mfd.c                          |  4 +-
 drivers/mfd/twl4030-power.c                        |  7 +---
 drivers/mtd/chips/cfi_cmdset_0002.c                | 12 ++++--
 drivers/mtd/nand/cmx270_nand.c                     |  4 +-
 drivers/mtd/ofpart.c                               |  4 +-
 drivers/of/fdt.c                                   | 20 +++++-----
 drivers/oprofile/oprofile_perf.c                   |  8 ++--
 drivers/platform/x86/asus-laptop.c                 |  2 +-
 drivers/platform/x86/eeepc-laptop.c                |  2 +-
 drivers/platform/x86/intel_oaktrail.c              | 10 ++---
 drivers/rapidio/rio-sysfs.c                        |  4 +-
 drivers/scsi/a3000.c                               |  2 +-
 drivers/sh/intc/core.c                             |  4 +-
 drivers/tty/hvc/hvcs.c                             |  2 +-
 drivers/tty/tty_io.c                               |  4 +-
 drivers/video/fbdev/aty/radeon_base.c              |  4 +-
 drivers/video/fbdev/core/fbmon.c                   |  4 +-
 drivers/video/fbdev/pxafb.c                        |  7 ++--
 kernel/trace/trace_benchmark.c                     |  4 +-
 lib/cpu_rmap.c                                     |  2 +-
 lib/dma-debug.c                                    |  2 +-
 sound/soc/fsl/imx-audmux.c                         |  6 +--
 sound/soc/samsung/s3c-i2s-v2.c                     |  6 +--
 122 files changed, 367 insertions(+), 397 deletions(-)

-- 
2.10.0.rc2.1.g053435c


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH 35/35] sound/soc: Convert remaining uses of pr_warning to pr_warn
  2017-02-17  7:11 [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn Joe Perches
@ 2017-02-17  7:11 ` Joe Perches
  2017-02-17 20:28   ` Nicolin Chen
       [not found] ` <cover.1487314666.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
  1 sibling, 1 reply; 13+ messages in thread
From: Joe Perches @ 2017-02-17  7:11 UTC (permalink / raw)
  To: Timur Tabi, Nicolin Chen, Xiubo Li, Fabio Estevam,
	Krzysztof Kozlowski, Sangbeom Kim, Sylwester Nawrocki
  Cc: alsa-devel, linux-kernel, Takashi Iwai, Liam Girdwood, Mark Brown,
	linuxppc-dev

To enable eventual removal of pr_warning

This makes pr_warn use consistent for sound/soc

Prior to this patch, there were 5 uses of pr_warning and
10 uses of pr_warn in sound/soc

Signed-off-by: Joe Perches <joe@perches.com>
---
 sound/soc/fsl/imx-audmux.c     | 6 +++---
 sound/soc/samsung/s3c-i2s-v2.c | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/sound/soc/fsl/imx-audmux.c b/sound/soc/fsl/imx-audmux.c
index fc57da341d61..41e877d2b400 100644
--- a/sound/soc/fsl/imx-audmux.c
+++ b/sound/soc/fsl/imx-audmux.c
@@ -152,7 +152,7 @@ static void audmux_debugfs_init(void)
 
 	audmux_debugfs_root = debugfs_create_dir("audmux", NULL);
 	if (!audmux_debugfs_root) {
-		pr_warning("Failed to create AUDMUX debugfs root\n");
+		pr_warn("Failed to create AUDMUX debugfs root\n");
 		return;
 	}
 
@@ -160,8 +160,8 @@ static void audmux_debugfs_init(void)
 		snprintf(buf, sizeof(buf), "ssi%lu", i);
 		if (!debugfs_create_file(buf, 0444, audmux_debugfs_root,
 					 (void *)i, &audmux_debugfs_fops))
-			pr_warning("Failed to create AUDMUX port %lu debugfs file\n",
-				   i);
+			pr_warn("Failed to create AUDMUX port %lu debugfs file\n",
+				i);
 	}
 }
 
diff --git a/sound/soc/samsung/s3c-i2s-v2.c b/sound/soc/samsung/s3c-i2s-v2.c
index 644f186fd35c..7423e4257a1b 100644
--- a/sound/soc/samsung/s3c-i2s-v2.c
+++ b/sound/soc/samsung/s3c-i2s-v2.c
@@ -669,13 +669,13 @@ static int s3c2412_i2s_suspend(struct snd_soc_dai *dai)
 		iismod = readl(i2s->regs + S3C2412_IISMOD);
 
 		if (iismod & S3C2412_IISCON_RXDMA_ACTIVE)
-			pr_warning("%s: RXDMA active?\n", __func__);
+			pr_warn("%s: RXDMA active?\n", __func__);
 
 		if (iismod & S3C2412_IISCON_TXDMA_ACTIVE)
-			pr_warning("%s: TXDMA active?\n", __func__);
+			pr_warn("%s: TXDMA active?\n", __func__);
 
 		if (iismod & S3C2412_IISCON_IIS_ACTIVE)
-			pr_warning("%s: IIS active\n", __func__);
+			pr_warn("%s: IIS active\n", __func__);
 	}
 
 	return 0;
-- 
2.10.0.rc2.1.g053435c

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn
       [not found] ` <cover.1487314666.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
@ 2017-02-17 12:27   ` Rafael J. Wysocki
  2017-02-17 12:37     ` Geert Uytterhoeven
  2017-02-23 15:28   ` Rob Herring
  1 sibling, 1 reply; 13+ messages in thread
From: Rafael J. Wysocki @ 2017-02-17 12:27 UTC (permalink / raw)
  To: Joe Perches
  Cc: Alexander Shishkin, Karol Herbst, Pekka Paalanen,
	Richard Weinberger, Fabio Estevam, Linux Kernel Mailing List,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linuxppc-dev, tboot-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
	nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	oprofile-list-TtF/mJH4Jtrk1uMJSBkQmQ,
	sfi-devel-yLnuTTp1/kvcsJTPyzm5gB2eb7JE58TQ,
	xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b,
	ACPI Devel Maling List, drbd-dev-cunTk1MwBs8qoQakbn7OcQ,
	virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
	linux-crypto-u79uwXL29TY76Z2rM5mHXA,
	linux-ide-u79uwXL29TY76Z2rM5mHXA,
	gigaset307x-common-5NWGOfrQmneRv+LV9MX5uv+2+P5yyue3

On Fri, Feb 17, 2017 at 8:11 AM, Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> wrote:
> There are ~4300 uses of pr_warn and ~250 uses of the older
> pr_warning in the kernel source tree.
>
> Make the use of pr_warn consistent across all kernel files.
>
> This excludes all files in tools/ as there is a separate
> define pr_warning for that directory tree and pr_warn is
> not used in tools/.
>
> Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing.

Sorry about asking if that has been asked already.

Wouldn't it be slightly less intrusive to simply redefined
pr_warning() as a synonym for pr_warn()?

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn
  2017-02-17 12:27   ` [PATCH 00/35] treewide trivial patches converting " Rafael J. Wysocki
@ 2017-02-17 12:37     ` Geert Uytterhoeven
  0 siblings, 0 replies; 13+ messages in thread
From: Geert Uytterhoeven @ 2017-02-17 12:37 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: open list:FRAMEBUFFER LAYER, linux-ia64@vger.kernel.org,
	Linux-sh list, Alexander Shishkin, nouveau,
	moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	dri-devel, virtualization, linux-ide@vger.kernel.org,
	MTD Maling List, sparclinux, Lars Ellenberg,
	open list:TARGET SUBSYSTEM, Richard Weinberger, sfi-devel,
	amd-gfx, ACPI Devel Maling List, tboot-devel, oprofil

Hi Rafael,

On Fri, Feb 17, 2017 at 1:27 PM, Rafael J. Wysocki <rafael@kernel.org> wrote:
> On Fri, Feb 17, 2017 at 8:11 AM, Joe Perches <joe@perches.com> wrote:
>> There are ~4300 uses of pr_warn and ~250 uses of the older
>> pr_warning in the kernel source tree.
>>
>> Make the use of pr_warn consistent across all kernel files.
>>
>> This excludes all files in tools/ as there is a separate
>> define pr_warning for that directory tree and pr_warn is
>> not used in tools/.
>>
>> Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing.
>
> Sorry about asking if that has been asked already.
>
> Wouldn't it be slightly less intrusive to simply redefined
> pr_warning() as a synonym for pr_warn()?

That's already the case.

This series cleans up the cruft, so we can catch all users with
"git grep -w pr_warn".

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 35/35] sound/soc: Convert remaining uses of pr_warning to pr_warn
  2017-02-17  7:11 ` [PATCH 35/35] sound/soc: Convert remaining uses of " Joe Perches
@ 2017-02-17 20:28   ` Nicolin Chen
  2017-02-17 23:48     ` Mark Brown
  0 siblings, 1 reply; 13+ messages in thread
From: Nicolin Chen @ 2017-02-17 20:28 UTC (permalink / raw)
  To: Joe Perches
  Cc: alsa-devel, Xiubo Li, Sangbeom Kim, linux-kernel, Takashi Iwai,
	Timur Tabi, Krzysztof Kozlowski, Liam Girdwood, Mark Brown,
	Sylwester Nawrocki, Fabio Estevam, linuxppc-dev

On Thu, Feb 16, 2017 at 11:11:48PM -0800, Joe Perches wrote:
> To enable eventual removal of pr_warning
> 
> This makes pr_warn use consistent for sound/soc
> 
> Prior to this patch, there were 5 uses of pr_warning and
> 10 uses of pr_warn in sound/soc
> 
> Signed-off-by: Joe Perches <joe@perches.com>

For imx-audmux.c,

Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>

> ---
>  sound/soc/fsl/imx-audmux.c     | 6 +++---
>  sound/soc/samsung/s3c-i2s-v2.c | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/sound/soc/fsl/imx-audmux.c b/sound/soc/fsl/imx-audmux.c
> index fc57da341d61..41e877d2b400 100644
> --- a/sound/soc/fsl/imx-audmux.c
> +++ b/sound/soc/fsl/imx-audmux.c
> @@ -152,7 +152,7 @@ static void audmux_debugfs_init(void)
>  
>  	audmux_debugfs_root = debugfs_create_dir("audmux", NULL);
>  	if (!audmux_debugfs_root) {
> -		pr_warning("Failed to create AUDMUX debugfs root\n");
> +		pr_warn("Failed to create AUDMUX debugfs root\n");
>  		return;
>  	}
>  
> @@ -160,8 +160,8 @@ static void audmux_debugfs_init(void)
>  		snprintf(buf, sizeof(buf), "ssi%lu", i);
>  		if (!debugfs_create_file(buf, 0444, audmux_debugfs_root,
>  					 (void *)i, &audmux_debugfs_fops))
> -			pr_warning("Failed to create AUDMUX port %lu debugfs file\n",
> -				   i);
> +			pr_warn("Failed to create AUDMUX port %lu debugfs file\n",
> +				i);
>  	}
>  }
>  
> diff --git a/sound/soc/samsung/s3c-i2s-v2.c b/sound/soc/samsung/s3c-i2s-v2.c
> index 644f186fd35c..7423e4257a1b 100644
> --- a/sound/soc/samsung/s3c-i2s-v2.c
> +++ b/sound/soc/samsung/s3c-i2s-v2.c
> @@ -669,13 +669,13 @@ static int s3c2412_i2s_suspend(struct snd_soc_dai *dai)
>  		iismod = readl(i2s->regs + S3C2412_IISMOD);
>  
>  		if (iismod & S3C2412_IISCON_RXDMA_ACTIVE)
> -			pr_warning("%s: RXDMA active?\n", __func__);
> +			pr_warn("%s: RXDMA active?\n", __func__);
>  
>  		if (iismod & S3C2412_IISCON_TXDMA_ACTIVE)
> -			pr_warning("%s: TXDMA active?\n", __func__);
> +			pr_warn("%s: TXDMA active?\n", __func__);
>  
>  		if (iismod & S3C2412_IISCON_IIS_ACTIVE)
> -			pr_warning("%s: IIS active\n", __func__);
> +			pr_warn("%s: IIS active\n", __func__);
>  	}
>  
>  	return 0;
> -- 
> 2.10.0.rc2.1.g053435c
> 

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 35/35] sound/soc: Convert remaining uses of pr_warning to pr_warn
  2017-02-17 20:28   ` Nicolin Chen
@ 2017-02-17 23:48     ` Mark Brown
  2017-02-17 23:57       ` Nicolin Chen
  0 siblings, 1 reply; 13+ messages in thread
From: Mark Brown @ 2017-02-17 23:48 UTC (permalink / raw)
  To: Nicolin Chen
  Cc: alsa-devel, Xiubo Li, Sangbeom Kim, linux-kernel, Takashi Iwai,
	Timur Tabi, Krzysztof Kozlowski, Liam Girdwood, Fabio Estevam,
	Sylwester Nawrocki, Joe Perches, linuxppc-dev


[-- Attachment #1.1: Type: text/plain, Size: 600 bytes --]

On Fri, Feb 17, 2017 at 12:28:44PM -0800, Nicolin Chen wrote:
> On Thu, Feb 16, 2017 at 11:11:48PM -0800, Joe Perches wrote:
> > To enable eventual removal of pr_warning
> > 
> > This makes pr_warn use consistent for sound/soc
> > 
> > Prior to this patch, there were 5 uses of pr_warning and
> > 10 uses of pr_warn in sound/soc
> > 
> > Signed-off-by: Joe Perches <joe@perches.com>
> 
> For imx-audmux.c,

I don't have this patch, perhaps it got caught in a spam filter or
perhaps it got deleted because as ever you're not using subject lines
reflecting the style for the subsystem.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 35/35] sound/soc: Convert remaining uses of pr_warning to pr_warn
  2017-02-17 23:48     ` Mark Brown
@ 2017-02-17 23:57       ` Nicolin Chen
  2017-02-18  0:20         ` Joe Perches
  0 siblings, 1 reply; 13+ messages in thread
From: Nicolin Chen @ 2017-02-17 23:57 UTC (permalink / raw)
  To: Mark Brown
  Cc: Joe Perches, Timur Tabi, Xiubo Li, Fabio Estevam,
	Krzysztof Kozlowski, Sangbeom Kim, Sylwester Nawrocki,
	Liam Girdwood, Jaroslav Kysela, Takashi Iwai, alsa-devel,
	linuxppc-dev, linux-kernel

On Fri, Feb 17, 2017 at 11:48:54PM +0000, Mark Brown wrote:
> On Fri, Feb 17, 2017 at 12:28:44PM -0800, Nicolin Chen wrote:
> > On Thu, Feb 16, 2017 at 11:11:48PM -0800, Joe Perches wrote:
> > > To enable eventual removal of pr_warning
> > > 
> > > This makes pr_warn use consistent for sound/soc
> > > 
> > > Prior to this patch, there were 5 uses of pr_warning and
> > > 10 uses of pr_warn in sound/soc
> > > 
> > > Signed-off-by: Joe Perches <joe@perches.com>
> > 
> > For imx-audmux.c,
> 
> I don't have this patch, perhaps it got caught in a spam filter or
> perhaps it got deleted because as ever you're not using subject lines
> reflecting the style for the subsystem.

My bad that I didn't pay attention to the subject.

Joe, please fix it in v2. Thanks.

ASoC: Convert remaining uses of pr_warning to pr_warn

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 35/35] sound/soc: Convert remaining uses of pr_warning to pr_warn
  2017-02-17 23:57       ` Nicolin Chen
@ 2017-02-18  0:20         ` Joe Perches
  2017-02-20 19:06           ` Mark Brown
  0 siblings, 1 reply; 13+ messages in thread
From: Joe Perches @ 2017-02-18  0:20 UTC (permalink / raw)
  To: Nicolin Chen, Mark Brown
  Cc: alsa-devel, Xiubo Li, Sangbeom Kim, linux-kernel, Takashi Iwai,
	Timur Tabi, Krzysztof Kozlowski, Liam Girdwood,
	Sylwester Nawrocki, Fabio Estevam, linuxppc-dev

On Fri, 2017-02-17 at 15:57 -0800, Nicolin Chen wrote:
> On Fri, Feb 17, 2017 at 11:48:54PM +0000, Mark Brown wrote:
> > On Fri, Feb 17, 2017 at 12:28:44PM -0800, Nicolin Chen wrote:
> > > On Thu, Feb 16, 2017 at 11:11:48PM -0800, Joe Perches wrote:
> > > > To enable eventual removal of pr_warning
> > > > 
> > > > This makes pr_warn use consistent for sound/soc
> > > > 
> > > > Prior to this patch, there were 5 uses of pr_warning and
> > > > 10 uses of pr_warn in sound/soc
> > > > 
> > > > Signed-off-by: Joe Perches <joe@perches.com>
> > > 
> > > For imx-audmux.c,
> > 
> > I don't have this patch, perhaps it got caught in a spam filter or
> > perhaps it got deleted because as ever you're not using subject lines
> > reflecting the style for the subsystem.
> 
> My bad that I didn't pay attention to the subject.
> 
> Joe, please fix it in v2. Thanks.
> 
> ASoC: Convert remaining uses of pr_warning to pr_warn

This is a treewide scripted patch which is
basically just a sed.

If or when you apply it, you should
fix it up to suit.

$ git log -1000 --pretty=oneline --no-merges sound/soc | \
  cut -f2- -d" " | cut -f1 -d":" |sort | uniq
ALSA
AsoC
ASoc
ASoC
ASOC
ASoC fix up SND_SOC_WM8985 dependency
drm/i915/dp
kthread
lib/vsprintf.c
scripts/spelling.txt
sgtl5000
SoC
sound/soc
treewide

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 35/35] sound/soc: Convert remaining uses of pr_warning to pr_warn
  2017-02-18  0:20         ` Joe Perches
@ 2017-02-20 19:06           ` Mark Brown
  0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2017-02-20 19:06 UTC (permalink / raw)
  To: Joe Perches
  Cc: alsa-devel, Xiubo Li, Sangbeom Kim, linux-kernel, Takashi Iwai,
	Timur Tabi, Krzysztof Kozlowski, Liam Girdwood, Nicolin Chen,
	Sylwester Nawrocki, Fabio Estevam, linuxppc-dev


[-- Attachment #1.1: Type: text/plain, Size: 450 bytes --]

On Fri, Feb 17, 2017 at 04:20:47PM -0800, Joe Perches wrote:

> If or when you apply it, you should
> fix it up to suit.

To repeat, I don't have this patch so someone will need to send it to
me.

> $ git log -1000 --pretty=oneline --no-merges sound/soc | \
>   cut -f2- -d" " | cut -f1 -d":" |sort | uniq
> ALSA
> AsoC
> ASoc
> ASoC
> ASOC
> ASoC fix up SND_SOC_WM8985 dependency

*sigh*  Now try counting the frequency of each...

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn
       [not found] ` <cover.1487314666.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
  2017-02-17 12:27   ` [PATCH 00/35] treewide trivial patches converting " Rafael J. Wysocki
@ 2017-02-23 15:28   ` Rob Herring
  2017-02-23 17:18     ` Joe Perches
  1 sibling, 1 reply; 13+ messages in thread
From: Rob Herring @ 2017-02-23 15:28 UTC (permalink / raw)
  To: Joe Perches
  Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-ia64-u79uwXL29TY76Z2rM5mHXA, SH-Linux, Alexander Shishkin,
	nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Linux-ALSA, dri-devel,
	virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
	linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	sparclinux-u79uwXL29TY76Z2rM5mHXA,
	drbd-dev-cunTk1MwBs8qoQakbn7OcQ,
	linux-scsi-u79uwXL29TY76Z2rM5mHXA, Richard Weinberger,
	sfi-devel-yLnuTTp1/kvcsJTPyzm5gB2eb7JE58TQ,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	tboot-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
	oprofile-list-TtF/mJH4Jtrk1uMJSBkQmQ,
	linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b, linux-media

On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches <joe@perches.com> wrote:
> There are ~4300 uses of pr_warn and ~250 uses of the older
> pr_warning in the kernel source tree.
>
> Make the use of pr_warn consistent across all kernel files.
>
> This excludes all files in tools/ as there is a separate
> define pr_warning for that directory tree and pr_warn is
> not used in tools/.
>
> Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing.
>
> Miscellanea:
>
> o Coalesce formats and realign arguments
>
> Some files not compiled - no cross-compilers
>
> Joe Perches (35):
>   alpha: Convert remaining uses of pr_warning to pr_warn
>   ARM: ep93xx: Convert remaining uses of pr_warning to pr_warn
>   arm64: Convert remaining uses of pr_warning to pr_warn
>   arch/blackfin: Convert remaining uses of pr_warning to pr_warn
>   ia64: Convert remaining use of pr_warning to pr_warn
>   powerpc: Convert remaining uses of pr_warning to pr_warn
>   sh: Convert remaining uses of pr_warning to pr_warn
>   sparc: Convert remaining use of pr_warning to pr_warn
>   x86: Convert remaining uses of pr_warning to pr_warn
>   drivers/acpi: Convert remaining uses of pr_warning to pr_warn
>   block/drbd: Convert remaining uses of pr_warning to pr_warn
>   gdrom: Convert remaining uses of pr_warning to pr_warn
>   drivers/char: Convert remaining use of pr_warning to pr_warn
>   clocksource: Convert remaining use of pr_warning to pr_warn
>   drivers/crypto: Convert remaining uses of pr_warning to pr_warn
>   fmc: Convert remaining use of pr_warning to pr_warn
>   drivers/gpu: Convert remaining uses of pr_warning to pr_warn
>   drivers/ide: Convert remaining uses of pr_warning to pr_warn
>   drivers/input: Convert remaining uses of pr_warning to pr_warn
>   drivers/isdn: Convert remaining uses of pr_warning to pr_warn
>   drivers/macintosh: Convert remaining uses of pr_warning to pr_warn
>   drivers/media: Convert remaining use of pr_warning to pr_warn
>   drivers/mfd: Convert remaining uses of pr_warning to pr_warn
>   drivers/mtd: Convert remaining uses of pr_warning to pr_warn
>   drivers/of: Convert remaining uses of pr_warning to pr_warn
>   drivers/oprofile: Convert remaining uses of pr_warning to pr_warn
>   drivers/platform: Convert remaining uses of pr_warning to pr_warn
>   drivers/rapidio: Convert remaining use of pr_warning to pr_warn
>   drivers/scsi: Convert remaining use of pr_warning to pr_warn
>   drivers/sh: Convert remaining use of pr_warning to pr_warn
>   drivers/tty: Convert remaining uses of pr_warning to pr_warn
>   drivers/video: Convert remaining uses of pr_warning to pr_warn
>   kernel/trace: Convert remaining uses of pr_warning to pr_warn
>   lib: Convert remaining uses of pr_warning to pr_warn
>   sound/soc: Convert remaining uses of pr_warning to pr_warn

Where's the removal of pr_warning so we don't have more sneak in?

Rob
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn
  2017-02-23 15:28   ` Rob Herring
@ 2017-02-23 17:18     ` Joe Perches
  2017-02-23 17:41       ` Emil Velikov
  0 siblings, 1 reply; 13+ messages in thread
From: Joe Perches @ 2017-02-23 17:18 UTC (permalink / raw)
  To: Rob Herring
  Cc: linux-fbdev@vger.kernel.org, linux-ia64, SH-Linux,
	Alexander Shishkin, nouveau, Linux-ALSA, dri-devel,
	virtualization, linux-ide@vger.kernel.org,
	linux-mtd@lists.infradead.org, sparclinux, drbd-dev, linux-scsi,
	Richard Weinberger, sfi-devel, amd-gfx,
	linux-acpi@vger.kernel.org, tboot-devel, oprofile-list,
	linux-input@vger.kernel.org, xen-devel, linux-media

On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote:
> On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches <joe@perches.com> wrote:
> > There are ~4300 uses of pr_warn and ~250 uses of the older
> > pr_warning in the kernel source tree.
> > 
> > Make the use of pr_warn consistent across all kernel files.
> > 
> > This excludes all files in tools/ as there is a separate
> > define pr_warning for that directory tree and pr_warn is
> > not used in tools/.
> > 
> > Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing.
[]
> Where's the removal of pr_warning so we don't have more sneak in?

After all of these actually get applied,
and maybe a cycle or two later, one would
get sent.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn
  2017-02-23 17:18     ` Joe Perches
@ 2017-02-23 17:41       ` Emil Velikov
  2017-02-23 17:53         ` Joe Perches
  0 siblings, 1 reply; 13+ messages in thread
From: Emil Velikov @ 2017-02-23 17:41 UTC (permalink / raw)
  To: Joe Perches
  Cc: linux-fbdev@vger.kernel.org, linux-ia64, SH-Linux,
	Alexander Shishkin, ML nouveau, Linux-ALSA, dri-devel,
	open list:VIRTIO GPU DRIVER, linux-ide@vger.kernel.org,
	linux-mtd@lists.infradead.org, sparclinux, drbd-dev, Rob Herring,
	linux-omap, linux-scsi, Richard Weinberger, tboot-devel,
	amd-gfx mailing list, linux-acpi@vger.kernel.org, sfi-devel

On 23 February 2017 at 17:18, Joe Perches <joe@perches.com> wrote:
> On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote:
>> On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches <joe@perches.com> wrote:
>> > There are ~4300 uses of pr_warn and ~250 uses of the older
>> > pr_warning in the kernel source tree.
>> >
>> > Make the use of pr_warn consistent across all kernel files.
>> >
>> > This excludes all files in tools/ as there is a separate
>> > define pr_warning for that directory tree and pr_warn is
>> > not used in tools/.
>> >
>> > Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing.
> []
>> Where's the removal of pr_warning so we don't have more sneak in?
>
> After all of these actually get applied,
> and maybe a cycle or two later, one would
> get sent.
>
By which point you'll get a few reincarnation of it. So you'll have to
do the same exercise again :-(

I guess the question is - are you expecting to get the series merged
all together/via one tree ? If not, your plan is perfectly reasonable.
Fwiw in the DRM subsystem, similar cleanups does purge the respective
macros/other with the final commit. But there one can pull the lot in
one go.

Regards,
Emil

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn
  2017-02-23 17:41       ` Emil Velikov
@ 2017-02-23 17:53         ` Joe Perches
  0 siblings, 0 replies; 13+ messages in thread
From: Joe Perches @ 2017-02-23 17:53 UTC (permalink / raw)
  To: Emil Velikov
  Cc: linux-fbdev@vger.kernel.org, linux-ia64, SH-Linux,
	Alexander Shishkin, ML nouveau, Linux-ALSA, dri-devel,
	open list:VIRTIO GPU DRIVER, linux-ide@vger.kernel.org,
	linux-mtd@lists.infradead.org, sparclinux, drbd-dev, Rob Herring,
	linux-omap, linux-scsi, Richard Weinberger, tboot-devel,
	amd-gfx mailing list, linux-acpi@vger.kernel.org, sfi-devel

On Thu, 2017-02-23 at 17:41 +0000, Emil Velikov wrote:
> On 23 February 2017 at 17:18, Joe Perches <joe@perches.com> wrote:
> > On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote:
> > > On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches <joe@perches.com> wrote:
> > > > There are ~4300 uses of pr_warn and ~250 uses of the older
> > > > pr_warning in the kernel source tree.
> > > > 
> > > > Make the use of pr_warn consistent across all kernel files.
> > > > 
> > > > This excludes all files in tools/ as there is a separate
> > > > define pr_warning for that directory tree and pr_warn is
> > > > not used in tools/.
> > > > 
> > > > Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing.
> > 
> > []
> > > Where's the removal of pr_warning so we don't have more sneak in?
> > 
> > After all of these actually get applied,
> > and maybe a cycle or two later, one would
> > get sent.
> > 
> 
> By which point you'll get a few reincarnation of it. So you'll have to
> do the same exercise again :-(

Maybe to one or two files.  Not a big deal.

> I guess the question is - are you expecting to get the series merged
> all together/via one tree ?

No.  The only person that could do that effectively is Linus.

> If not, your plan is perfectly reasonable.

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2017-02-23 17:53 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-17  7:11 [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn Joe Perches
2017-02-17  7:11 ` [PATCH 35/35] sound/soc: Convert remaining uses of " Joe Perches
2017-02-17 20:28   ` Nicolin Chen
2017-02-17 23:48     ` Mark Brown
2017-02-17 23:57       ` Nicolin Chen
2017-02-18  0:20         ` Joe Perches
2017-02-20 19:06           ` Mark Brown
     [not found] ` <cover.1487314666.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2017-02-17 12:27   ` [PATCH 00/35] treewide trivial patches converting " Rafael J. Wysocki
2017-02-17 12:37     ` Geert Uytterhoeven
2017-02-23 15:28   ` Rob Herring
2017-02-23 17:18     ` Joe Perches
2017-02-23 17:41       ` Emil Velikov
2017-02-23 17:53         ` Joe Perches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).