alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Haojian Zhuang <haojian.zhuang@gmail.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Eric Miao <eric.y.miao@gmail.com>,
	Haojian Zhuang <haojian.zhuang@marvell.com>,
	Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 2/4] ASoC: Use dai_fmt in spitz machine driver
Date: Sat, 31 Dec 2011 08:17:47 +0800	[thread overview]
Message-ID: <CAN1soZxxkFDuapcSRnnpw5cqj4yQzSoRaoVLSezcesARtOb2pg@mail.gmail.com> (raw)
In-Reply-To: <1325259775.4755.7.camel@phoenix>

On Fri, Dec 30, 2011 at 11:42 PM, Axel Lin <axel.lin@gmail.com> wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
>  sound/soc/pxa/spitz.c |   14 ++------------
>  1 files changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/sound/soc/pxa/spitz.c b/sound/soc/pxa/spitz.c
> index bb06048..76288ad 100644
> --- a/sound/soc/pxa/spitz.c
> +++ b/sound/soc/pxa/spitz.c
> @@ -143,18 +143,6 @@ static int spitz_hw_params(struct snd_pcm_substream *substream,
>                break;
>        }
>
> -       /* set codec DAI configuration */
> -       ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S |
> -               SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS);
> -       if (ret < 0)
> -               return ret;
> -
> -       /* set cpu DAI configuration */
> -       ret = snd_soc_dai_set_fmt(cpu_dai, SND_SOC_DAIFMT_I2S |
> -               SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS);
> -       if (ret < 0)
> -               return ret;
> -
>        /* set the codec system clock for DAC and ADC */
>        ret = snd_soc_dai_set_sysclk(codec_dai, WM8750_SYSCLK, clk,
>                SND_SOC_CLOCK_IN);
> @@ -313,6 +301,8 @@ static struct snd_soc_dai_link spitz_dai = {
>        .platform_name = "pxa-pcm-audio",
>        .codec_name = "wm8750.0-001b",
>        .init = spitz_wm8750_init,
> +       .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
> +                  SND_SOC_DAIFMT_CBS_CFS,
>        .ops = &spitz_ops,
>  };
>
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>

  reply	other threads:[~2011-12-31  0:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-30 15:41 [PATCH 1/4] ASoC: Use dai_fmt in saarb machine driver Axel Lin
2011-12-30 15:42 ` [PATCH 2/4] ASoC: Use dai_fmt in spitz " Axel Lin
2011-12-31  0:17   ` Haojian Zhuang [this message]
2011-12-30 15:43 ` [PATCH 3/4] ASoC: Use dai_fmt in tavorevb3 " Axel Lin
2011-12-31  0:18   ` Haojian Zhuang
2011-12-30 15:44 ` [PATCH 4/4] ASoC: Use dai_fmt in z2 " Axel Lin
2011-12-31  0:19   ` Haojian Zhuang
2011-12-31  0:17 ` [PATCH 1/4] ASoC: Use dai_fmt in saarb " Haojian Zhuang
2012-01-02 12:44 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN1soZxxkFDuapcSRnnpw5cqj4yQzSoRaoVLSezcesARtOb2pg@mail.gmail.com \
    --to=haojian.zhuang@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=axel.lin@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=eric.y.miao@gmail.com \
    --cc=haojian.zhuang@marvell.com \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).