From: Fabio Estevam <festevam@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: wm9712: Fix build due to missing definition of "runtime"
Date: Tue, 10 Apr 2012 18:48:47 -0300 [thread overview]
Message-ID: <CAOMZO5CXtC8xAVB+6cSDeKMLNj6RfSjV7cA1LM0WCyL9oJoFqQ@mail.gmail.com> (raw)
In-Reply-To: <20120410213809.GV7499@opensource.wolfsonmicro.com>
On Tue, Apr 10, 2012 at 6:38 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Tue, Apr 10, 2012 at 06:33:07PM -0300, Fabio Estevam wrote:
>> Fix the following build error:
>>
>> sound/soc/codecs/wm9712.c:482:32: error: 'runtime' undeclared (first use in this function)
>> sound/soc/codecs/wm9712.c:499:33: error: 'runtime' undeclared (first use in this function)
>
> On second thoughts looking at what the setting is being used for
> applied... the code is rather odd here, though.
>
> In general changes like this which make no attempt to understand what
> they're changing are a bad idea - don't just cut'n'paste some errors
> into your changelog, explain what's gone wrong and why. It's like when
> people just initialise a variable to some random value to shut a warning
> up without understanding why, the fact that the error goes away doesn't
> mean that the fix is sensible.
Ok, this is currently breaking imx_v4_v5_defconfig in linux-next and
would like to get it fixed.
I will try to understand this breakage better.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2012-04-10 21:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 21:33 [PATCH] ASoC: wm9712: Fix build due to missing definition of "runtime" Fabio Estevam
2012-04-10 21:34 ` Mark Brown
2012-04-10 21:38 ` Mark Brown
2012-04-10 21:48 ` Fabio Estevam [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-10 21:29 Fabio Estevam
2012-04-10 21:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5CXtC8xAVB+6cSDeKMLNj6RfSjV7cA1LM0WCyL9oJoFqQ@mail.gmail.com \
--to=festevam@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=fabio.estevam@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).