Re: [PATCH] ASoC: jack: export gpio detect

[Christopher Freeman <cfreeman@nvidia.com>]

On 4/3/14 3:07 PM, "Mark Brown" <broonie@kernel.org> wrote:

>* PGP Signed by an unknown key
>
>On Thu, Apr 03, 2014 at 03:03:55PM -0700, cfreeman@nvidia.com wrote:
>> From: Christopher Freeman <cfreeman@nvidia.com>
>> 
>> Export the gpio detect function so machine drivers
>> may call it.  Interrupts for the jack may be disabled
>> during sleep, so this allows a machine driver to have
>> the jack status updated during resume.
>
>It seems better to have explicit callbacks for this doesn't it, ideally
>ones that get triggered by the core without the machine driver having to
>do anything?  This is a common need so having to open code it would be a
>bit depressing.

Mark, do you have a suggestion on how to plumb this up?  The way I see it,
the machine drivers own the context for the gpios and soc-jack acts as a
helper library.  I don't see a way to do this from the core.


>
>* Unknown Key
>* 0x7EA229BD

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------