From: Darren Hart <dvhart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Oder Chiou <oder_chiou@realtek.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Ben Zhang <benzh@chromium.org>,
Anatol Pomozov <anatol@google.com>,
Grant Likely <grant.likely@linaro.org>,
Bard Liao <bardliao@realtek.com>,
Dylan Reid <dgreid@chromium.org>
Subject: Re: [PATCH 2/2] ASoC: rt5677: Switch to use unified device property API
Date: Mon, 22 Jun 2015 17:05:37 -0700 [thread overview]
Message-ID: <D1ADF0B6.D4C8F%dvhart@linux.intel.com> (raw)
In-Reply-To: <20150622225031.GW14071@sirena.org.uk>
On 6/22/15, 3:50 PM, "Mark Brown" <broonie@kernel.org> wrote:
>On Tue, Jun 23, 2015 at 12:18:54AM +0200, Pierre-Louis Bossart wrote:
>> On 6/22/15 8:13 PM, Ben Zhang wrote:
>
>> >+ rt5677->pdata.in1_diff = device_property_read_bool(dev,
>> >+ "realtek,in1-differential");
>
>> Shouldn't it be device_property_present() ?
>
>At least on the DT side they should be equivalent - I don't know if ACPI
>works differently?
>
>> thanks for starting this transition, this will be very useful for
>>ACPI-based
>> solutions.
>
>Have the Intel audio people been speaking to the UEFI forum about using
>the new registration process for these properties? More from interest
>than anything else.
Yes (although "audio people" is a rather broad term at Intel :-)
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2015-06-23 0:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 18:12 [PATCH 1/2] ASoC: rt5677: Switch to use descriptor-based gpiod API Ben Zhang
2015-06-22 18:13 ` [PATCH 2/2] ASoC: rt5677: Switch to use unified device property API Ben Zhang
2015-06-22 22:18 ` Pierre-Louis Bossart
2015-06-22 22:50 ` Mark Brown
2015-06-22 23:07 ` Ben Zhang
2015-06-23 0:05 ` Darren Hart [this message]
2015-06-23 9:46 ` Mark Brown
2015-07-07 13:57 ` Applied "ASoC: rt5677: Switch to use unified device property API" to the asoc tree Mark Brown
2015-07-07 13:57 ` Applied "ASoC: rt5677: Switch to use descriptor-based gpiod " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D1ADF0B6.D4C8F%dvhart@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=anatol@google.com \
--cc=bardliao@realtek.com \
--cc=benzh@chromium.org \
--cc=broonie@kernel.org \
--cc=dgreid@chromium.org \
--cc=grant.likely@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox