From: "Handrigan, Paul" <Paul.Handrigan@cirrus.com>
To: Nicolin Chen <nicoleotsuka@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"Austin, Brian" <Brian.Austin@cirrus.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 2/2] ASoC: cs53l30: Check return value of regcache_sync()
Date: Wed, 1 Jun 2016 01:28:25 +0000 [thread overview]
Message-ID: <D373A44D.1446E%Paul.Handrigan@cirrus.com> (raw)
In-Reply-To: <1464735999-10384-2-git-send-email-nicoleotsuka@gmail.com>
On 5/31/16, 6:06 PM, "Nicolin Chen" <nicoleotsuka@gmail.com> wrote:
>Regcache_sync() might fail. So this patch adds a return value Check for
>it.
>
>Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
>---
> sound/soc/codecs/cs53l30.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
>index 9aff449..ac90dd7 100644
>--- a/sound/soc/codecs/cs53l30.c
>+++ b/sound/soc/codecs/cs53l30.c
>@@ -1055,7 +1055,11 @@ static int cs53l30_runtime_resume(struct device
>*dev)
> gpiod_set_value_cansleep(cs53l30->reset_gpio, 1);
>
> regcache_cache_only(cs53l30->regmap, false);
>- regcache_sync(cs53l30->regmap);
>+ ret = regcache_sync(cs53l30->regmap);
>+ if (ret) {
>+ dev_err(dev, "failed to synchronize regcache: %d\n", ret);
>+ return ret;
>+ }
>
> return 0;
> }
>--
>2.1.4
Acked-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
next prev parent reply other threads:[~2016-06-01 1:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 23:06 [PATCH 1/2] ASoC: cs53l30: Rename the volume controls for preamplifier Nicolin Chen
2016-05-31 23:06 ` [PATCH 2/2] ASoC: cs53l30: Check return value of regcache_sync() Nicolin Chen
2016-06-01 1:28 ` Handrigan, Paul [this message]
2016-06-02 10:18 ` Applied "ASoC: cs53l30: Check return value of regcache_sync()" to the asoc tree Mark Brown
2016-06-01 1:27 ` [PATCH 1/2] ASoC: cs53l30: Rename the volume controls for preamplifier Handrigan, Paul
2016-06-02 10:18 ` Applied "ASoC: cs53l30: Rename the volume controls for preamplifier" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D373A44D.1446E%Paul.Handrigan@cirrus.com \
--to=paul.handrigan@cirrus.com \
--cc=Brian.Austin@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).