From: Mark Brown <broonie@kernel.org>
To: "Dharageswari.R" <dharageswari.r@intel.com>,
Jayachandran B <jayachandran.b@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Subject: Applied "ASoC: Intel: Skylake: Use CGCTL.MISCBDCGE for Phrase detection notification" to the asoc tree
Date: Sun, 10 Jan 2016 12:22:32 +0000 [thread overview]
Message-ID: <E1aIF0y-0008Rp-JG@debutante> (raw)
In-Reply-To: <1450431729-27259-9-git-send-email-vinod.koul@intel.com>
The patch
ASoC: Intel: Skylake: Use CGCTL.MISCBDCGE for Phrase detection notification
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 721c3e36f774150f453216efcf5e1895577ac68c Mon Sep 17 00:00:00 2001
From: "Dharageswari.R" <dharageswari.r@intel.com>
Date: Fri, 18 Dec 2015 15:12:04 +0530
Subject: [PATCH] ASoC: Intel: Skylake: Use CGCTL.MISCBDCGE for Phrase
detection notification
Per HW recommendation, SW shall clear the CGCTL.MISCBDCGE and set
it back once data is transferred. So clear this when we get the
IPC and track using a driver flag, and set back on closure
Signed-off-by: Dharageswari.R <dharageswari.r@intel.com>
Signed-off-by: Jayachandran B <jayachandran.b@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/intel/skylake/skl-pcm.c | 13 +++++++++++++
sound/soc/intel/skylake/skl-sst-ipc.c | 15 +++++++++++++++
2 files changed, 28 insertions(+)
diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c
index b89ae6f7c096..8039a0479053 100644
--- a/sound/soc/intel/skylake/skl-pcm.c
+++ b/sound/soc/intel/skylake/skl-pcm.c
@@ -25,6 +25,8 @@
#include <sound/soc.h>
#include "skl.h"
#include "skl-topology.h"
+#include "skl-sst-dsp.h"
+#include "skl-sst-ipc.h"
#define HDA_MONO 1
#define HDA_STEREO 2
@@ -272,6 +274,7 @@ static void skl_pcm_close(struct snd_pcm_substream *substream,
struct hdac_ext_stream *stream = get_hdac_ext_stream(substream);
struct hdac_ext_bus *ebus = dev_get_drvdata(dai->dev);
struct skl_dma_params *dma_params = NULL;
+ struct skl *skl = ebus_to_skl(ebus);
dev_dbg(dai->dev, "%s: %s\n", __func__, dai->name);
@@ -285,6 +288,16 @@ static void skl_pcm_close(struct snd_pcm_substream *substream,
snd_soc_dai_set_dma_data(dai, substream, NULL);
skl_set_suspend_active(substream, dai, false);
+ /*
+ * check if close is for "Reference Pin" and set back the
+ * CGCTL.MISCBDCGE if disabled by driver
+ */
+ if (!strncmp(dai->name, "Reference Pin", 13) &&
+ skl->skl_sst->miscbdcg_disabled) {
+ skl->skl_sst->enable_miscbdcge(dai->dev, true);
+ skl->skl_sst->miscbdcg_disabled = false;
+ }
+
kfree(dma_params);
}
diff --git a/sound/soc/intel/skylake/skl-sst-ipc.c b/sound/soc/intel/skylake/skl-sst-ipc.c
index 62e665a3b8f7..543460293b00 100644
--- a/sound/soc/intel/skylake/skl-sst-ipc.c
+++ b/sound/soc/intel/skylake/skl-sst-ipc.c
@@ -16,8 +16,10 @@
#include "../common/sst-dsp.h"
#include "../common/sst-dsp-priv.h"
+#include "skl.h"
#include "skl-sst-dsp.h"
#include "skl-sst-ipc.h"
+#include "sound/hdaudio_ext.h"
#define IPC_IXC_STATUS_BITS 24
@@ -322,6 +324,19 @@ static int skl_ipc_process_notification(struct sst_generic_ipc *ipc,
wake_up(&skl->boot_wait);
break;
+ case IPC_GLB_NOTIFY_PHRASE_DETECTED:
+ dev_dbg(ipc->dev, "***** Phrase Detected **********\n");
+
+ /*
+ * Per HW recomendation, After phrase detection,
+ * clear the CGCTL.MISCBDCGE.
+ *
+ * This will be set back on stream closure
+ */
+ skl->enable_miscbdcge(ipc->dev, false);
+ skl->miscbdcg_disabled = true;
+ break;
+
default:
dev_err(ipc->dev, "ipc: Unhandled error msg=%x",
header.primary);
--
2.7.0.rc3
next prev parent reply other threads:[~2016-01-10 12:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 9:41 [PATCH v4 00/13] ASoC: Intel: Skylake: Update to SKL driver Vinod Koul
2015-12-18 9:41 ` [PATCH v4 01/13] ASoC: Intel: Skylake: Clear stream registers before stream setup Vinod Koul
2015-12-18 9:41 ` [PATCH v4 02/13] ASoC: Intel: Skylake: Fix to set pipe state to invalid when deleting Vinod Koul
2015-12-18 9:41 ` [PATCH v4 03/13] ALSA: hdac: Add support for hda DMA Resume capability Vinod Koul
2016-01-04 5:57 ` Vinod Koul
2016-01-05 15:51 ` Mark Brown
2016-01-06 9:03 ` Takashi Iwai
2016-01-06 9:18 ` Vinod Koul
2016-01-06 9:16 ` Takashi Iwai
2016-01-06 9:27 ` Vinod Koul
2015-12-18 9:42 ` [PATCH v4 04/13] ALSA: hdac: couple the hda DMA stream in cleanup Vinod Koul
2015-12-18 9:42 ` [PATCH v4 05/13] ALSA: hdac: Increase timeout value for link power check Vinod Koul
2015-12-18 9:42 ` [PATCH v4 06/13] ALSA: hdac: add snd_hdac_ext_bus_link_power_up_all Vinod Koul
2015-12-18 9:42 ` [PATCH v4 07/13] ASoC: Intel: Skylake: fix reset controller sequencing Vinod Koul
2016-01-10 12:22 ` Applied "ASoC: Intel: Skylake: fix reset controller sequencing" to the asoc tree Mark Brown
2015-12-18 9:42 ` [PATCH v4 08/13] ASoC: Intel: Skylake: Use CGCTL.MISCBDCGE for Phrase detection notification Vinod Koul
2016-01-10 12:22 ` Mark Brown [this message]
2015-12-18 9:42 ` [PATCH v4 09/13] ASoC: Intel: Skylake: manage link power in active suspend Vinod Koul
2015-12-18 9:42 ` [PATCH v4 10/13] ASoC: Intel: Skylake: enable interrupt as wake source " Vinod Koul
2015-12-18 9:42 ` [PATCH v4 11/13] ASoC: Intel: Skylake: Add DMA resume position in Trigger resume/suspend Vinod Koul
2015-12-18 9:42 ` [PATCH v4 12/13] ASoC: Intel: Skylake: Reconfigure Link stream on suspend/resume Vinod Koul
2015-12-18 9:42 ` [PATCH v4 13/13] ASoC: Intel: Skylake: Add Resume capability in PCM info Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1aIF0y-0008Rp-JG@debutante \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=dharageswari.r@intel.com \
--cc=jayachandran.b@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox