Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>, Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Subject: Applied "ASoC: wm8904: Fix enum ctl accesses in a wrong type" to the asoc tree
Date: Tue, 01 Mar 2016 12:21:46 +0900	[thread overview]
Message-ID: <E1aaasc-000835-Mj@finisterre> (raw)
In-Reply-To: <1456765278-5435-3-git-send-email-tiwai@suse.de>

The patch

   ASoC: wm8904: Fix enum ctl accesses in a wrong type

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From c41a024c4e770fff999f4164cc4d1696e5f17437 Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@suse.de>
Date: Mon, 29 Feb 2016 18:01:11 +0100
Subject: [PATCH] ASoC: wm8904: Fix enum ctl accesses in a wrong type

"DRC Mode" and "EQ Mode" ctls in wm8904 codec driver are enum, while
the current driver accesses wrongly via value.integer.value[].  They
have to be via value.enumerated.item[] instead.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/wm8904.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c
index 8172e499e6ed..edd7a7709194 100644
--- a/sound/soc/codecs/wm8904.c
+++ b/sound/soc/codecs/wm8904.c
@@ -396,7 +396,7 @@ static int wm8904_put_drc_enum(struct snd_kcontrol *kcontrol,
 	struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
 	struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);
 	struct wm8904_pdata *pdata = wm8904->pdata;
-	int value = ucontrol->value.integer.value[0];
+	int value = ucontrol->value.enumerated.item[0];
 
 	if (value >= pdata->num_drc_cfgs)
 		return -EINVAL;
@@ -467,7 +467,7 @@ static int wm8904_put_retune_mobile_enum(struct snd_kcontrol *kcontrol,
 	struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
 	struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);
 	struct wm8904_pdata *pdata = wm8904->pdata;
-	int value = ucontrol->value.integer.value[0];
+	int value = ucontrol->value.enumerated.item[0];
 
 	if (value >= pdata->num_retune_mobile_cfgs)
 		return -EINVAL;
-- 
2.7.0

  reply	other threads:[~2016-03-01  3:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29 17:01 [PATCH 0/9] ASoC: wm*: Fix enum ctl accesses Takashi Iwai
2016-02-29 17:01 ` [PATCH 1/9] ASoC: wm8753: Fix enum ctl accesses in a wrong type Takashi Iwai
2016-03-01  3:21   ` Applied "ASoC: wm8753: Fix enum ctl accesses in a wrong type" to the asoc tree Mark Brown
2016-02-29 17:01 ` [PATCH 2/9] ASoC: wm8904: Fix enum ctl accesses in a wrong type Takashi Iwai
2016-03-01  3:21   ` Mark Brown [this message]
2016-02-29 17:01 ` [PATCH 3/9] ASoC: wm8958: " Takashi Iwai
2016-03-01  3:21   ` Applied "ASoC: wm8958: Fix enum ctl accesses in a wrong type" to the asoc tree Mark Brown
2016-02-29 17:01 ` [PATCH 4/9] ASoC: wm8983: Fix enum ctl accesses in a wrong type Takashi Iwai
2016-03-01  3:20   ` Applied "ASoC: wm8983: Fix enum ctl accesses in a wrong type" to the asoc tree Mark Brown
2016-02-29 17:01 ` [PATCH 5/9] ASoC: wm8985: Fix enum ctl accesses in a wrong type Takashi Iwai
2016-03-01  3:20   ` Applied "ASoC: wm8985: Fix enum ctl accesses in a wrong type" to the asoc tree Mark Brown
2016-02-29 17:01 ` [PATCH 6/9] ASoC: wm8994: Fix enum ctl accesses in a wrong type Takashi Iwai
2016-03-01  3:19   ` Applied "ASoC: wm8994: Fix enum ctl accesses in a wrong type" to the asoc tree Mark Brown
2016-02-29 17:01 ` [PATCH 7/9] ASoC: wm8996: Fix enum ctl accesses in a wrong type Takashi Iwai
2016-03-01  3:19   ` Applied "ASoC: wm8996: Fix enum ctl accesses in a wrong type" to the asoc tree Mark Brown
2016-02-29 17:01 ` [PATCH 8/9] ASoC: wm9081: Fix enum ctl accesses in a wrong type Takashi Iwai
2016-03-01  3:19   ` Applied "ASoC: wm9081: Fix enum ctl accesses in a wrong type" to the asoc tree Mark Brown
2016-02-29 17:01 ` [PATCH 9/9] ASoC: wm_adsp: Fix enum ctl accesses in a wrong type Takashi Iwai
2016-03-01  3:19   ` Applied "ASoC: wm_adsp: Fix enum ctl accesses in a wrong type" to the asoc tree Mark Brown
2016-03-08  9:02 ` [PATCH 0/9] ASoC: wm*: Fix enum ctl accesses Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1aaasc-000835-Mj@finisterre \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox