* [PATCH 1/3] ASoC: Intel: Skylake: correct direction in blob query
2016-03-01 2:29 [PATCH 0/3] ASoC: Intel: Skylake: Update the IVI feedback path Vinod Koul
@ 2016-03-01 2:29 ` Vinod Koul
2016-03-02 4:00 ` Applied "ASoC: Intel: Skylake: correct direction in blob query" to the asoc tree Mark Brown
2016-03-01 2:29 ` [PATCH 2/3] ASoC: Intel: Skylake: Add IVI feedback path in nau88125_ssm4567 machine Vinod Koul
2016-03-01 2:29 ` [PATCH 3/3] ASoC: Intel: Skylake: remove IVI codec loop in skl_nau88l25_ssm4567 machine Vinod Koul
2 siblings, 1 reply; 7+ messages in thread
From: Vinod Koul @ 2016-03-01 2:29 UTC (permalink / raw)
To: alsa-devel; +Cc: liam.r.girdwood, patches.audio, broonie, Vinod Koul, Jeeja KP
From: Jeeja KP <jeeja.kp@intel.com>
The blob query for BE skl_tplg_update_be_blob() was not using
right values for direction for blob query, so fix that.
Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
sound/soc/intel/skylake/skl-topology.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c
index c95bbce8ad5d..af7722ab7207 100644
--- a/sound/soc/intel/skylake/skl-topology.c
+++ b/sound/soc/intel/skylake/skl-topology.c
@@ -273,10 +273,11 @@ static int skl_tplg_update_be_blob(struct snd_soc_dapm_widget *w,
if (m_cfg->formats_config.caps_size > 0)
return 0;
+ dev_dbg(ctx->dev, "Applying default cfg blob\n");
switch (m_cfg->dev_type) {
case SKL_DEVICE_DMIC:
link_type = NHLT_LINK_DMIC;
- dir = 1;
+ dir = SNDRV_PCM_STREAM_CAPTURE;
s_freq = m_cfg->in_fmt[0].s_freq;
s_fmt = m_cfg->in_fmt[0].bit_depth;
ch = m_cfg->in_fmt[0].channels;
@@ -285,15 +286,15 @@ static int skl_tplg_update_be_blob(struct snd_soc_dapm_widget *w,
case SKL_DEVICE_I2S:
link_type = NHLT_LINK_SSP;
if (m_cfg->hw_conn_type == SKL_CONN_SOURCE) {
- dir = 1;
- s_freq = m_cfg->in_fmt[0].s_freq;
- s_fmt = m_cfg->in_fmt[0].bit_depth;
- ch = m_cfg->in_fmt[0].channels;
- } else {
- dir = 0;
+ dir = SNDRV_PCM_STREAM_PLAYBACK;
s_freq = m_cfg->out_fmt[0].s_freq;
s_fmt = m_cfg->out_fmt[0].bit_depth;
ch = m_cfg->out_fmt[0].channels;
+ } else {
+ dir = SNDRV_PCM_STREAM_CAPTURE;
+ s_freq = m_cfg->in_fmt[0].s_freq;
+ s_fmt = m_cfg->in_fmt[0].bit_depth;
+ ch = m_cfg->in_fmt[0].channels;
}
break;
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Applied "ASoC: Intel: Skylake: correct direction in blob query" to the asoc tree
2016-03-01 2:29 ` [PATCH 1/3] ASoC: Intel: Skylake: correct direction in blob query Vinod Koul
@ 2016-03-02 4:00 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2016-03-02 4:00 UTC (permalink / raw)
To: Jeeja KP, Vinod Koul, Mark Brown; +Cc: alsa-devel
The patch
ASoC: Intel: Skylake: correct direction in blob query
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From c7c6c73604ed4018cf7c22575d336a448ef8ccf5 Mon Sep 17 00:00:00 2001
From: Jeeja KP <jeeja.kp@intel.com>
Date: Tue, 1 Mar 2016 07:59:10 +0530
Subject: [PATCH] ASoC: Intel: Skylake: correct direction in blob query
The blob query for BE skl_tplg_update_be_blob() was not using
right values for direction for blob query, so fix that.
Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/intel/skylake/skl-topology.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c
index c95bbce8ad5d..af7722ab7207 100644
--- a/sound/soc/intel/skylake/skl-topology.c
+++ b/sound/soc/intel/skylake/skl-topology.c
@@ -273,10 +273,11 @@ static int skl_tplg_update_be_blob(struct snd_soc_dapm_widget *w,
if (m_cfg->formats_config.caps_size > 0)
return 0;
+ dev_dbg(ctx->dev, "Applying default cfg blob\n");
switch (m_cfg->dev_type) {
case SKL_DEVICE_DMIC:
link_type = NHLT_LINK_DMIC;
- dir = 1;
+ dir = SNDRV_PCM_STREAM_CAPTURE;
s_freq = m_cfg->in_fmt[0].s_freq;
s_fmt = m_cfg->in_fmt[0].bit_depth;
ch = m_cfg->in_fmt[0].channels;
@@ -285,15 +286,15 @@ static int skl_tplg_update_be_blob(struct snd_soc_dapm_widget *w,
case SKL_DEVICE_I2S:
link_type = NHLT_LINK_SSP;
if (m_cfg->hw_conn_type == SKL_CONN_SOURCE) {
- dir = 1;
- s_freq = m_cfg->in_fmt[0].s_freq;
- s_fmt = m_cfg->in_fmt[0].bit_depth;
- ch = m_cfg->in_fmt[0].channels;
- } else {
- dir = 0;
+ dir = SNDRV_PCM_STREAM_PLAYBACK;
s_freq = m_cfg->out_fmt[0].s_freq;
s_fmt = m_cfg->out_fmt[0].bit_depth;
ch = m_cfg->out_fmt[0].channels;
+ } else {
+ dir = SNDRV_PCM_STREAM_CAPTURE;
+ s_freq = m_cfg->in_fmt[0].s_freq;
+ s_fmt = m_cfg->in_fmt[0].bit_depth;
+ ch = m_cfg->in_fmt[0].channels;
}
break;
--
2.7.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/3] ASoC: Intel: Skylake: Add IVI feedback path in nau88125_ssm4567 machine
2016-03-01 2:29 [PATCH 0/3] ASoC: Intel: Skylake: Update the IVI feedback path Vinod Koul
2016-03-01 2:29 ` [PATCH 1/3] ASoC: Intel: Skylake: correct direction in blob query Vinod Koul
@ 2016-03-01 2:29 ` Vinod Koul
2016-03-02 4:00 ` Applied "ASoC: Intel: Skylake: Add IVI feedback path in nau88125_ssm4567 machine" to the asoc tree Mark Brown
2016-03-01 2:29 ` [PATCH 3/3] ASoC: Intel: Skylake: remove IVI codec loop in skl_nau88l25_ssm4567 machine Vinod Koul
2 siblings, 1 reply; 7+ messages in thread
From: Vinod Koul @ 2016-03-01 2:29 UTC (permalink / raw)
To: alsa-devel; +Cc: liam.r.girdwood, patches.audio, broonie, Vinod Koul, Jeeja KP
From: Jeeja KP <jeeja.kp@intel.com>
We can enable the IVI feedback path by connecting Left/Right
speaker sensors (codec) to ssp0 Rx (soc-dsp). This way aDSP gets
feedback data from codec to DSP algorithms
Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
sound/soc/intel/boards/skl_nau88l25_ssm4567.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/intel/boards/skl_nau88l25_ssm4567.c b/sound/soc/intel/boards/skl_nau88l25_ssm4567.c
index a75c09343f84..f6a672c55be9 100644
--- a/sound/soc/intel/boards/skl_nau88l25_ssm4567.c
+++ b/sound/soc/intel/boards/skl_nau88l25_ssm4567.c
@@ -132,6 +132,8 @@ static const struct snd_soc_dapm_route skylake_map[] = {
/* IV feedback path */
{ "codec0_lp_in", NULL, "ssp0 Rx"},
+ { "ssp0 Rx", NULL, "Left Capture Sense" },
+ { "ssp0 Rx", NULL, "Right Capture Sense" },
{ "Playback", NULL, "ssp1 Tx"},
{ "ssp1 Tx", NULL, "codec1_out"},
@@ -534,6 +536,7 @@ static struct snd_soc_dai_link skylake_dais[] = {
.ignore_pmdown_time = 1,
.be_hw_params_fixup = skylake_ssp_fixup,
.dpcm_playback = 1,
+ .dpcm_capture = 1,
},
{
/* SSP1 - Codec */
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Applied "ASoC: Intel: Skylake: Add IVI feedback path in nau88125_ssm4567 machine" to the asoc tree
2016-03-01 2:29 ` [PATCH 2/3] ASoC: Intel: Skylake: Add IVI feedback path in nau88125_ssm4567 machine Vinod Koul
@ 2016-03-02 4:00 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2016-03-02 4:00 UTC (permalink / raw)
To: Jeeja KP, Vinod Koul, Mark Brown; +Cc: alsa-devel
The patch
ASoC: Intel: Skylake: Add IVI feedback path in nau88125_ssm4567 machine
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 5188b95a60ce33d5445833f9b0a374a2ad3200f4 Mon Sep 17 00:00:00 2001
From: Jeeja KP <jeeja.kp@intel.com>
Date: Tue, 1 Mar 2016 07:59:11 +0530
Subject: [PATCH] ASoC: Intel: Skylake: Add IVI feedback path in
nau88125_ssm4567 machine
We can enable the IVI feedback path by connecting Left/Right
speaker sensors (codec) to ssp0 Rx (soc-dsp). This way aDSP gets
feedback data from codec to DSP algorithms
Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/intel/boards/skl_nau88l25_ssm4567.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/intel/boards/skl_nau88l25_ssm4567.c b/sound/soc/intel/boards/skl_nau88l25_ssm4567.c
index a75c09343f84..f6a672c55be9 100644
--- a/sound/soc/intel/boards/skl_nau88l25_ssm4567.c
+++ b/sound/soc/intel/boards/skl_nau88l25_ssm4567.c
@@ -132,6 +132,8 @@ static const struct snd_soc_dapm_route skylake_map[] = {
/* IV feedback path */
{ "codec0_lp_in", NULL, "ssp0 Rx"},
+ { "ssp0 Rx", NULL, "Left Capture Sense" },
+ { "ssp0 Rx", NULL, "Right Capture Sense" },
{ "Playback", NULL, "ssp1 Tx"},
{ "ssp1 Tx", NULL, "codec1_out"},
@@ -534,6 +536,7 @@ static struct snd_soc_dai_link skylake_dais[] = {
.ignore_pmdown_time = 1,
.be_hw_params_fixup = skylake_ssp_fixup,
.dpcm_playback = 1,
+ .dpcm_capture = 1,
},
{
/* SSP1 - Codec */
--
2.7.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] ASoC: Intel: Skylake: remove IVI codec loop in skl_nau88l25_ssm4567 machine
2016-03-01 2:29 [PATCH 0/3] ASoC: Intel: Skylake: Update the IVI feedback path Vinod Koul
2016-03-01 2:29 ` [PATCH 1/3] ASoC: Intel: Skylake: correct direction in blob query Vinod Koul
2016-03-01 2:29 ` [PATCH 2/3] ASoC: Intel: Skylake: Add IVI feedback path in nau88125_ssm4567 machine Vinod Koul
@ 2016-03-01 2:29 ` Vinod Koul
2016-03-02 4:00 ` Applied "ASoC: Intel: Skylake: remove IVI codec loop in skl_nau88l25_ssm4567 machine" to the asoc tree Mark Brown
2 siblings, 1 reply; 7+ messages in thread
From: Vinod Koul @ 2016-03-01 2:29 UTC (permalink / raw)
To: alsa-devel; +Cc: liam.r.girdwood, patches.audio, broonie, Vinod Koul, Jeeja KP
From: Jeeja KP <jeeja.kp@intel.com>
The IVI loop is removed in skl_nau88l25_ssm4567 machine as we
enable this path thru DAPM graph using the PCM device and not
thru loop
Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
sound/soc/intel/boards/skl_nau88l25_ssm4567.c | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/sound/soc/intel/boards/skl_nau88l25_ssm4567.c b/sound/soc/intel/boards/skl_nau88l25_ssm4567.c
index f6a672c55be9..5f1ca99ae9b0 100644
--- a/sound/soc/intel/boards/skl_nau88l25_ssm4567.c
+++ b/sound/soc/intel/boards/skl_nau88l25_ssm4567.c
@@ -156,14 +156,6 @@ static const struct snd_soc_dapm_route skylake_map[] = {
{ "Headset Mic", NULL, "Platform Clock" },
};
-static const struct snd_soc_pcm_stream skl_ssm4567_loop_params = {
- .formats = SNDRV_PCM_FMTBIT_S24_LE,
- .rate_min = 48000,
- .rate_max = 48000,
- .channels_min = 4,
- .channels_max = 4,
-};
-
static struct snd_soc_codec_conf ssm4567_codec_conf[] = {
{
.dev_name = "i2c-INT343B:00",
@@ -508,16 +500,6 @@ static struct snd_soc_dai_link skylake_dais[] = {
.nonatomic = 1,
.dynamic = 1,
},
- /* Codec-codec link */
- {
- .name = "Skylake IV loop",
- .stream_name = "SKL IV Loop",
- .cpu_dai_name = "SSP0 Pin",
- .platform_name = "0000:00:1f.3",
- .codecs = ssm4567_codec_components,
- .num_codecs = ARRAY_SIZE(ssm4567_codec_components),
- .params = &skl_ssm4567_loop_params,
- },
/* Back End DAI links */
{
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Applied "ASoC: Intel: Skylake: remove IVI codec loop in skl_nau88l25_ssm4567 machine" to the asoc tree
2016-03-01 2:29 ` [PATCH 3/3] ASoC: Intel: Skylake: remove IVI codec loop in skl_nau88l25_ssm4567 machine Vinod Koul
@ 2016-03-02 4:00 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2016-03-02 4:00 UTC (permalink / raw)
To: Jeeja KP, Vinod Koul, Mark Brown; +Cc: alsa-devel
The patch
ASoC: Intel: Skylake: remove IVI codec loop in skl_nau88l25_ssm4567 machine
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From fdd69c57370dbd9f81072b14aaeb90d80ab0b2f9 Mon Sep 17 00:00:00 2001
From: Jeeja KP <jeeja.kp@intel.com>
Date: Tue, 1 Mar 2016 07:59:12 +0530
Subject: [PATCH] ASoC: Intel: Skylake: remove IVI codec loop in
skl_nau88l25_ssm4567 machine
The IVI loop is removed in skl_nau88l25_ssm4567 machine as we
enable this path thru DAPM graph using the PCM device and not
thru loop
Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/intel/boards/skl_nau88l25_ssm4567.c | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/sound/soc/intel/boards/skl_nau88l25_ssm4567.c b/sound/soc/intel/boards/skl_nau88l25_ssm4567.c
index f6a672c55be9..5f1ca99ae9b0 100644
--- a/sound/soc/intel/boards/skl_nau88l25_ssm4567.c
+++ b/sound/soc/intel/boards/skl_nau88l25_ssm4567.c
@@ -156,14 +156,6 @@ static const struct snd_soc_dapm_route skylake_map[] = {
{ "Headset Mic", NULL, "Platform Clock" },
};
-static const struct snd_soc_pcm_stream skl_ssm4567_loop_params = {
- .formats = SNDRV_PCM_FMTBIT_S24_LE,
- .rate_min = 48000,
- .rate_max = 48000,
- .channels_min = 4,
- .channels_max = 4,
-};
-
static struct snd_soc_codec_conf ssm4567_codec_conf[] = {
{
.dev_name = "i2c-INT343B:00",
@@ -508,16 +500,6 @@ static struct snd_soc_dai_link skylake_dais[] = {
.nonatomic = 1,
.dynamic = 1,
},
- /* Codec-codec link */
- {
- .name = "Skylake IV loop",
- .stream_name = "SKL IV Loop",
- .cpu_dai_name = "SSP0 Pin",
- .platform_name = "0000:00:1f.3",
- .codecs = ssm4567_codec_components,
- .num_codecs = ARRAY_SIZE(ssm4567_codec_components),
- .params = &skl_ssm4567_loop_params,
- },
/* Back End DAI links */
{
--
2.7.0
^ permalink raw reply related [flat|nested] 7+ messages in thread