Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
	Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>Mark Brown
	<broonie@kernel.org>,
	linux-renesas-soc@vger.kernel.org, alsa-devel@alsa-project.org,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	patches@opensource.wolfsonmicro.com,
	Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: Applied "ASoC: wm8940: Enable cache usage to fix crashes on resume" to the asoc tree
Date: Fri, 17 Jun 2016 12:43:24 +0100	[thread overview]
Message-ID: <E1bDsBI-000269-6C@debutante> (raw)
In-Reply-To: <1466080472-9817-4-git-send-email-geert+renesas@glider.be>

The patch

   ASoC: wm8940: Enable cache usage to fix crashes on resume

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 50c7a0ef2d97e56c7ce2f1ea5fe1d8e25aadc1bb Mon Sep 17 00:00:00 2001
From: Geert Uytterhoeven <geert+renesas@glider.be>
Date: Thu, 16 Jun 2016 14:34:32 +0200
Subject: [PATCH] ASoC: wm8940: Enable cache usage to fix crashes on resume

The wm8940 driver is using a regmap cache sync to restore the
configuration of the chip when switching from OFF to STANDBY, but does
not actually define a register cache which means that the restore is
never going to work and we trigger asserts in regmap.  Fix this by
enabling caching.

Based on commit d3030d11961a8c10 ("ASoC: ak4642: Enable cache usage to
fix crashes on resume") by Mark Brown <broonie@kernel.org>.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/wm8940.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/wm8940.c b/sound/soc/codecs/wm8940.c
index f6f9395ea38e..1c600819f768 100644
--- a/sound/soc/codecs/wm8940.c
+++ b/sound/soc/codecs/wm8940.c
@@ -743,6 +743,7 @@ static const struct regmap_config wm8940_regmap = {
 	.max_register = WM8940_MONOMIX,
 	.reg_defaults = wm8940_reg_defaults,
 	.num_reg_defaults = ARRAY_SIZE(wm8940_reg_defaults),
+	.cache_type = REGCACHE_RBTREE,
 
 	.readable_reg = wm8940_readable_register,
 	.volatile_reg = wm8940_volatile_register,
-- 
2.8.1

      parent reply	other threads:[~2016-06-17 11:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16 12:34 [PATCH 0/3] ASoC: ak4613/wm8940: Regmap cache fixes Geert Uytterhoeven
2016-06-16 12:34 ` [PATCH 1/3] ASoC: ak4613: Enable cache usage to fix crashes on resume Geert Uytterhoeven
2016-06-17 11:43   ` Applied "ASoC: ak4613: Enable cache usage to fix crashes on resume" to the asoc tree Mark Brown
2016-06-16 12:34 ` [PATCH 2/3] ASoC: ak4613: Implement suspend callback Geert Uytterhoeven
2016-06-17 11:43   ` Applied "ASoC: ak4613: Implement suspend callback" to the asoc tree Mark Brown
2016-06-16 12:34 ` [PATCH 3/3] ASoC: wm8940: Enable cache usage to fix crashes on resume Geert Uytterhoeven
2016-06-16 15:16   ` Charles Keepax
2016-06-17 11:43   ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1bDsBI-000269-6C@debutante \
    --to=broonie@kernel.org \
    --cc=ckeepax@opensource.wolfsonmicro.com \
    --cc=geert+renesas@glider.be \
    --cc=lgirdwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox